Skip to content

London | 25-ITP-May | Kayanat Suleman | Sprint 3 | Practice TDD#1021

Open
KayanatSuleman wants to merge 14 commits intoCodeYourFuture:mainfrom
KayanatSuleman:coursework/sprint-3-practice-tdd
Open

London | 25-ITP-May | Kayanat Suleman | Sprint 3 | Practice TDD#1021
KayanatSuleman wants to merge 14 commits intoCodeYourFuture:mainfrom
KayanatSuleman:coursework/sprint-3-practice-tdd

Conversation

@KayanatSuleman
Copy link

@KayanatSuleman KayanatSuleman commented Feb 22, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Implemented countChar using TDD approach.
  • Implemented getOrdinalNumber with correct handling of 11, 12, 13 special cases.
  • Implemented repeatStr including edge cases (0 count and negative count error).
  • Added Jest tests to cover normal cases, edge cases, and error scenarios.

@KayanatSuleman
checking to see the output of count using terminal
dd85a1d
@KayanatSuleman
Updating the script with comments detailing my understanding of the s…
c7ddaed 
…cript
@KayanatSuleman
Adding a jest test for 0 or empty string
035ca52
@KayanatSuleman
ensuring the test case is passing
ea81dae
@KayanatSuleman
Adding jest test for numbers ending in 2
4377262
@KayanatSuleman
Adding jest test case for numbers ending in three
3a89cc4
@KayanatSuleman
Adding jest cases for numbers ending in 4-9, and 0
8b055ae
@KayanatSuleman
Adding jest test case for special cases
c87f2ab
@KayanatSuleman
Adding a few other instances to cover the requirements correctly for …
64d94f8 
…test case5
@KayanatSuleman
Adding jest test case for case: handle count of 1
6916541
@KayanatSuleman
Implementing the solution for the function repeatStr
ac6fa53
@KayanatSuleman
Adding jest test case for throw an error for negative count
86215d3
@KayanatSuleman
Remove Sprint-1 1-count.js from practice-tdd branch
2239ca4
@KayanatSuleman KayanatSuleman mentioned this pull request Feb 22, 2026
Open
10 tasks
@KayanatSuleman KayanatSuleman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 3 Assigned during Sprint 3 of this module labels Feb 22, 2026
This was referenced Feb 23, 2026
Closed
Open
cjyuan
cjyuan reviewed Mar 3, 2026
View reviewed changes
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 3, 2026
@KayanatSuleman KayanatSuleman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 4, 2026
cjyuan
cjyuan reviewed Mar 4, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KayanatSuleman @cjyuan