London | 26-ITP-Jan | Boualem Larbi Djebbour | sprint 1 | Coursework

[djebsoft]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

I completed the mandatory sections of sprint 1 for the second module

Questions

[djebsoft]

thanks for the review
I did the following:
1-prettier already installed and set
I couldn't figure out what peace of code you pointed to, so I reviewed the whole codes of sprint 1.
2- trailing slash removed from the value assigned to dir
3- recomended approach taken
4- demonstrated what's included and what's excluded
5- parentheses omitted automatically when I formatted with prettier
6- avoided starting variable name with a $ and
sugested to begin the name with a lowercase letter.
7- suggested more descriptive name
8- reverted the changes made in the Sprint-2 folder

[cjyuan]

• Changes in in Sprint-2 reverted. Well done.

• Code seems consistently formatted -- if you have successfully enabled "Format on save" and assign Prettier as the default formatter for JS code, then you won't need to worry about your code "not properly formatted". The inconsistency was small but prettier would have taken care of them for you.

• Other changes look good.

• You could practice responding inline comments though. Doing so could help the reviewer track what you have done.
  You can ask AI how to address inline comments in a PR and practice what you find in future PRs.