Skip to content

Glasgow | 26-ITP-JAN | Prakash Dcosta | Sprint 2 | Structuring and Testing Data#1098

Open
dcostaprakash wants to merge 2 commits intoCodeYourFuture:mainfrom
dcostaprakash:Sprint-2
Open

Glasgow | 26-ITP-JAN | Prakash Dcosta | Sprint 2 | Structuring and Testing Data#1098
dcostaprakash wants to merge 2 commits intoCodeYourFuture:mainfrom
dcostaprakash:Sprint-2

Conversation

@dcostaprakash
Copy link

Glasgow | 26-ITP-JAN | Prakash Dcosta | Sprint 2 | Structuing and Testing Data

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the [style guide]

Have completed the coursework as per instructions

@github-actions

This comment has been minimized.

@dcostaprakash dcostaprakash changed the title Changes made as per the coursework Glasgow | 26-ITP-JAN | Prakash Dcosta | Sprint 2 | Structuing and Testing Data Feb 28, 2026
@dcostaprakash dcostaprakash added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 28, 2026
@dcostaprakash dcostaprakash changed the title Glasgow | 26-ITP-JAN | Prakash Dcosta | Sprint 2 | Structuing and Testing Data Glasgow | 26-ITP-JAN | Prakash Dcosta | Sprint 2 | Structuring and Testing Data Mar 1, 2026
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 7, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and explanation are correct. However, some of the code is not consistently formatted.

Have you installed the prettier VSCode extension and enabled "Format on save/paste" on VSCode, as recommended in
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md
?

After you have enabled that, can you resave all the files in this Sprint exercise?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 7, 2026
@dcostaprakash
Copy link
Author

dcostaprakash commented Mar 7, 2026

Hi, I see it now. I had only clicked the format on save in Prettier in User option earlier when doing the prep. I have now enabled it for editor and save in both user and workspace areas. I have made the changes as per the review and saved the files. Thank you

@dcostaprakash dcostaprakash added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 7, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Mar 7, 2026

The code is not yet consistently formatted.

Enabling "Format on Save" sometimes may not be enough if you have installed multiple extensions that can serve as a formatter for JS code.

You may want to carry out this test on your VSCode:

  1. Open a JS file.
  2. Mess up the indentation of one or two lines of code.
  3. Save the file.
  4. If the indentation does not change on save, go to step 5, otherwise you are set.
  5. Right click the code in the editor and then select "Format document". If you see a dialog asking you to configure the formatter for JS, then pick "Configure" and then select "Prettier" from the selection.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 7, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Mar 7, 2026

I have marked this PR as "Complete" first, but you should try to ensure "Format on save" is working as intended.

@dcostaprakash
Copy link
Author

I tried the steps as mentioned above. It was not working. Then i did step 5 and it is now working. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants