Glasgow | 26-ITP-JAN | Prakash Dcosta | Sprint 2 | Structuring and Testing Data#1098
Glasgow | 26-ITP-JAN | Prakash Dcosta | Sprint 2 | Structuring and Testing Data#1098dcostaprakash wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
cjyuan
left a comment
There was a problem hiding this comment.
Code and explanation are correct. However, some of the code is not consistently formatted.
Have you installed the prettier VSCode extension and enabled "Format on save/paste" on VSCode, as recommended in
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md
?
After you have enabled that, can you resave all the files in this Sprint exercise?
|
Hi, I see it now. I had only clicked the format on save in Prettier in User option earlier when doing the prep. I have now enabled it for editor and save in both user and workspace areas. I have made the changes as per the review and saved the files. Thank you |
|
The code is not yet consistently formatted. Enabling "Format on Save" sometimes may not be enough if you have installed multiple extensions that can serve as a formatter for JS code. You may want to carry out this test on your VSCode:
|
|
I have marked this PR as "Complete" first, but you should try to ensure "Format on save" is working as intended. |
|
I tried the steps as mentioned above. It was not working. Then i did step 5 and it is now working. Thank you very much! |
Glasgow | 26-ITP-JAN | Prakash Dcosta | Sprint 2 | Structuing and Testing Data
Self checklist
Have completed the coursework as per instructions