Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 3 | Implement and Rewrite tests

[MehrozMunir]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

I have completed the exercises of implement and wrote test cases uing jest

[cjyuan]

This requirement has not yet been met:

// When the card string is invalid (not following the above format), the function should
// throw an error

Currently your function returns a string when a card is invalid.

Note: The error is supposed to be thrown to the caller.

[MehrozMunir]

Yes that's right I was not throwing an error. I have fixed it now.

[MehrozMunir]

I have created a separate function with the name assertThrows in the 3-get-card-value.js file to catch the error. But, I am not sure how can I test this thrown error in 3-get-card-value.test.js file where I am using jest test.

[cjyuan]

See lines 43-45 in 3-get-card-value.test.js

// To learn how to test whether a function throws an error as expected in Jest,
// please refer to the Jest documentation:
// https://jestjs.io/docs/expect#tothrowerror

[MehrozMunir]

Thanks. I should have looked at this. Fixed now.

[cjyuan]

Please remember to add the "Needs Review" label when the PR is ready to be re-reviewed.

[MehrozMunir]

Hi @cjyuan I made sure that i am in the right branch when making changes and I have made changes only in the 3-get-card-value.js and its test file and carefully pushed the code from the same branch. However the git bot is giving me the following error when i am trying to add needs review label.

thread 'main' (2433) panicked at src/bin/pr-metadata-validator.rs:64:6:
Failed to validate PR: UserFacing("Failed to parse issue #1246 - no submit label.\n\nIf this issue was made my a curriculum team member it should be given a sprint label.\nIf this issue was created by a trainee for step submission, it should probably be closed (and they should create the issue in their fork).")
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
Error: Process completed with exit code 101.

I don't know what is wrong. I have not faced this kind of error before and there is one more strange thing on this page now written beside the name of file "outdated"

[cjyuan]

Changes look good. Well done!

Don't worry about the validation result. It is caused by something unrelated to your PR.