Skip to content

Manchester | 26-ITP-Jan | Abdu Mussa | Sprint 2 |Module Structuring and Testing Data #1121

Open
Abduhasen wants to merge 4 commits intoCodeYourFuture:mainfrom
Abduhasen:coursework/sprint-2
Open

Manchester | 26-ITP-Jan | Abdu Mussa | Sprint 2 |Module Structuring and Testing Data #1121
Abduhasen wants to merge 4 commits intoCodeYourFuture:mainfrom
Abduhasen:coursework/sprint-2

Conversation

@Abduhasen
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

fixing errors and debugs

Questions

N/A

@github-actions

This comment has been minimized.

@Abduhasen Abduhasen added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module labels Mar 1, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 1, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Abduhasen Abduhasen changed the title Manchester | 26-ITP-Jan | Abdu Mussa | Sprint-2 |Module Structuring and Testing Data Manchester | 26-ITP-Jan | Abdu Mussa | Sprint 2 |Module Structuring and Testing Data Mar 1, 2026
@Abduhasen Abduhasen added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 1, 2026
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 7, 2026
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 7, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Mar 8, 2026

Changes look good.

The answer to question (d) in the file Sprint-2/4-mandatory-interpret/time-format.js is not quite correct.

Note: When your PR is ready to be re-reviewed, you should also add the "Needs Review" label to the PR.

@Abduhasen Abduhasen added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 8, 2026
Comment on lines +31 to +34
// =============> write your answer here: pad(00):pad(01):pad(01) because it will take the value of totalHours,remainingMinutes,remainingSeconds.

// e) What is the return value assigned to num when pad is called for the last time in this program? Explain your answer
// =============> write your answer here
// =============> write your answer here: the return value will be 1 because 61 seconds has 1 second left after converting to minutes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You modified the answer of (e) instead of (d). The previous answer of (e) is correct.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was the question that we were discussing before i didn't noticed it now i fixed it i hope my answer is correct

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

The typo in question (e) was a bit misleading. It has now been revised.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 8, 2026
@Abduhasen Abduhasen added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 8, 2026
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants