Sheffield | 26-ITP-jan | Richard Frimpong | Sprint 2 | Structuring and Testing Data#1125
Open
Richiealx wants to merge 17 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-jan | Richard Frimpong | Sprint 2 | Structuring and Testing Data#1125Richiealx wants to merge 17 commits intoCodeYourFuture:mainfrom
Richiealx wants to merge 17 commits intoCodeYourFuture:mainfrom
Conversation
Richiealx
added
the
Needs Review
cjyuan
reviewed
Mar 6, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code and explanation look good.
cjyuan
added
Reviewed
Richiealx
added
the
Needs Review
cjyuan
reviewed
Mar 7, 2026
Comment on lines
+18
to
+20
| const bmi = weight / (height * height); | ||
| return Number(bmi.toFixed(1)); | ||
| } |
Contributor
There was a problem hiding this comment.
Indentation is off. Can you fix it?
Consider install prettier VSCode extension and enable formatting on save/paste on VSCode
as recommended in
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md
Author
There was a problem hiding this comment.
Hi @cjyuan,
Thanks for the feedback.
I have installed the Prettier VS Code extension and enabled format on save as recommended in the repository guidelines. I reformatted the files and pushed the updated changes to the branch.
cjyuan
removed
the
Needs Review
Richiealx
added
the
Needs Review
cjyuan
added
Complete
Contributor
|
Changes look good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed Sprint 2 coursework:
Sprint-2/1-key-errors/answers.md