Manchester | 26-ITP-Sep | Khalidbih | Sprint 2 | Sprint-2#1138

Closed

khalidbih wants to merge 23 commits intoCodeYourFuture:mainfrom

khalidbih:sprint-2-redo-26

khalidbih commented Mar 3, 2026 •

edited

Loading

Self checklist :

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist :

I have completed all the exercises in Sprint-2.

khalidbih added 22 commits

February 18, 2026 14:58


           complete 1-count exercise

a5f11ec


          complete 2-initials exercise

321c1d2


          complete 3-path exercise

64ab32e


           complete 4-random exercise

622028f


          complete 0.js exercise

f76840d


          complete 1.js exercise

cbbe383


          Fix error caused by using const before declaration

e3ae3a8


          Fix last4Digits, convert number to string before slicing

974f8af


          Fix 12-hour and 24-hour clock values

e33cbfd


          Convert price strings to numbers for calculation

da1bcac


          complete exercise time format

885713a


          Format pence string into pounds and pence output

7d36f59


          remove duplicate variable declaration in capitalise function

56c1ae7


          correct convertToPercentage function

68d57ce


          correct square function parameter

508504c


          fix multiply function to return result

42ce6cb


          fix sum function to return correct value

8486d54


          fix getLastDigit function to use parameter

ddee225


          Implement BMI formula and round result to 1 decimal place

6050f8e


          Add toUpperSnakeCase function using replaceAll and toUpperCase

0ee89c8


          Add toPounds function to convert pence string to formatted pounds

f50de6d


          Answer questions on formatTimeDisplay and pad function

42fe3fc

github-actions bot commented Mar 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

khalidbih added 📅 Sprint 2 Needs Review Module-Structuring-And-Testing-Data labels

github-actions bot commented Mar 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot removed the Needs Review label

github-actions bot commented Mar 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment

github-actions bot commented Mar 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot removed the Needs Review label

github-actions bot commented Mar 3, 2026

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment

github-actions bot commented Mar 3, 2026

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

khalidbih changed the title ~~Manchester | 26-ITP-Sep | Khalidbih | Sprint 2 l Sprint-2~~ Manchester | 26-ITP-Sep | Khalidbih | Sprint 2 l Coursework/sprint-2`

khalidbih added the Needs Review label

github-actions bot commented Mar 3, 2026

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot removed the Needs Review label

github-actions bot commented Mar 3, 2026

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

khalidbih changed the title ~~Manchester | 26-ITP-Sep | Khalidbih | Sprint 2 l Coursework/sprint-2`~~ Manchester | 26-ITP-Sep | Khalidbih | Sprint 2 l Coursework/sprint-2

github-actions bot commented Mar 3, 2026

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

khalidbih changed the title ~~Manchester | 26-ITP-Sep | Khalidbih | Sprint 2 l Coursework/sprint-2~~ Manchester | 25-ITP-Sep | Khalidbih | Sprint 2 | Sprint-2

khalidbih added the Needs Review label

github-actions bot commented Mar 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot removed the Needs Review label

github-actions bot commented Mar 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

khalidbih changed the title ~~Manchester | 25-ITP-Sep | Khalidbih | Sprint 2 | Sprint-2~~ Manchester | 25-ITP-Sep | Khalidbih | Sprint 2 | sprint-2-redo-26

github-actions bot commented Mar 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

khalidbih added the Needs Review label

khalidbih changed the title ~~Manchester | 25-ITP-Sep | Khalidbih | Sprint 2 | sprint-2-redo-26~~ Manchester | 25-ITP-Sep | Khalidbih | Sprint 2 | sprint-2

github-actions bot commented Mar 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot removed the Needs Review label

github-actions bot commented Mar 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

khalidbih changed the title ~~Manchester | 25-ITP-Sep | Khalidbih | Sprint 2 | sprint-2~~ Manchester | 26-ITP-Sep | Khalidbih | Sprint 2 | sprint-2

khalidbih added the Needs Review label

github-actions bot commented Mar 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot removed the Needs Review label

github-actions bot commented Mar 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

khalidbih changed the title ~~Manchester | 26-ITP-Sep | Khalidbih | Sprint 2 | sprint-2~~ Manchester | 26-ITP-Sep | Khalidbih | Sprint 2 | Sprint-2

github-actions bot commented Mar 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

khalidbih closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Structuring-And-Testing-Data 📅 Sprint 2