generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 338
London | ITP-JAN-2026 | Said Fayaz Sadat | Sprint 3 | coursework/sprint-3/implement-and-rewrite-tests #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fayaz551
wants to merge
20
commits into
CodeYourFuture:main
Choose a base branch
from
fayaz551:coursework/Sprint-3-implement-and-rewrite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
62f2bc9
corrected the branch to individual folders of sprint-3 implement and …
fayaz551 5218dc7
Updated isProperFraction implementation and correct tests for negativ…
fayaz551 4541230
added implementation for invalid cards and removed direct calls from …
fayaz551 60dd1f1
ensure only valid cards return numbers
fayaz551 d0b2a26
return "Invalid angle" for angles <0 or >360 and added explicit inval…
fayaz551 22cbee3
clarify invalid angle tests using valid range 0–360
fayaz551 9ab2716
fixed the indentation in the function
fayaz551 a517fe7
fixed the indentation issue
fayaz551 40bd7ce
categorize cases with descriptive messages
fayaz551 8c587a2
used shorter descriptive text for test
fayaz551 560d5c6
implementation to handle boundary angles correctly with test case
fayaz551 401d8cb
implementation for small valid angle and test case for it
fayaz551 48cfeba
smallest valid angle
fayaz551 595de00
updated the test description and function to match task specification
fayaz551 e21d0fd
tests to include negative numerator and denominator cases
fayaz551 921a30a
align angle tests and implementation of function with specification o…
fayaz551 8a9fab6
removed the test written twice
fayaz551 89c02e7
combined all invalid angles into one test
fayaz551 b3bbf8a
added another test case (0,0)
fayaz551 0f7221f
changes description for category 3.
fayaz551 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.