-
-
Notifications
You must be signed in to change notification settings - Fork 337
Manchester| 26-ITP-Jan | Ofonime Edak | Sprint 3 | TDD #1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,13 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| let count = 0; | ||
| for (let i = 0; i < stringOfCharacters.length; i++) { | ||
| if (stringOfCharacters[i] === findCharacter) { | ||
| count++; | ||
| } else { | ||
| return 0; | ||
| } | ||
| } | ||
| return count; | ||
| } | ||
|
|
||
| module.exports = countChar; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,21 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| const numStr = num.toString(); | ||
| const numLength = numStr.length; | ||
| if (numStr[numLength - 2] === "1" && numStr[numLength - 1] === "1") { | ||
| return num + "th"; | ||
| } else if (numStr[numLength - 2] === "1" && numStr[numLength - 1] === "2") { | ||
| return num + "th"; | ||
| } else if (numStr[numLength - 1] === "1") { | ||
| return num + "st"; | ||
| } else if (numStr[numLength - 2] === "1" && numStr[numLength - 1] === "3") { | ||
| return num + "th"; | ||
| } else if (numStr[numLength - 1] === "3") { | ||
| return num + "rd"; | ||
| } else if (numStr[numLength - 1] === "2") { | ||
| return num + "nd"; | ||
| } else { | ||
| return num + "th"; | ||
| } | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,3 +18,51 @@ test("should append 'st' for numbers ending with 1, except those ending with 11" | |
| expect(getOrdinalNumber(21)).toEqual("21st"); | ||
| expect(getOrdinalNumber(131)).toEqual("131st"); | ||
| }); | ||
|
|
||
| //case 2: Numbers ending with 11 | ||
| test("should return 'th' for numbers ending with 11", () => { | ||
| expect(getOrdinalNumber(11)).toEqual("11th"); | ||
| expect(getOrdinalNumber(111)).toEqual("111th"); | ||
| expect(getOrdinalNumber(211)).toEqual("211th"); | ||
| expect(getOrdinalNumber(1011)).toEqual("1011th"); | ||
| }); | ||
|
|
||
| //case:3 Numbers ending with 3 but not 13 | ||
| test("Should return 'rd' for numbers ending with 3", () => { | ||
| expect(getOrdinalNumber(73)).toEqual("73rd"); | ||
| expect(getOrdinalNumber(93)).toEqual("93rd"); | ||
| expect(getOrdinalNumber(43)).toEqual("43rd"); | ||
| expect(getOrdinalNumber(2003)).toEqual("2003rd"); | ||
| }); | ||
|
|
||
| //case:4 expect Numbers ending with 13 to return th | ||
| test(" should return 'th' for numbers ending with 13", () => { | ||
| expect(getOrdinalNumber(13)).toEqual("13th"); | ||
| expect(getOrdinalNumber(413)).toEqual("413th"); | ||
| expect(getOrdinalNumber(613)).toEqual("613th"); | ||
| }); | ||
|
|
||
| //case:5 expect Numbers ending with 12 to return th | ||
| test(" should return 'th' for numbers ending with 12", () => { | ||
| expect(getOrdinalNumber(12)).toEqual("12th"); | ||
| expect(getOrdinalNumber(41)).toEqual("412th"); | ||
| expect(getOrdinalNumber(612)).toEqual("612th"); | ||
| }); | ||
|
|
||
| //case 6: expect number ending with 2 to return nd | ||
| test(" should return 'nd' for numbers ending with 2", () => { | ||
| expect(getOrdinalNumber(22)).toEqual("22nd"); | ||
| expect(getOrdinalNumber(42)).toEqual("42nd"); | ||
| expect(getOrdinalNumber(102)).toEqual("102nd"); | ||
| }); | ||
|
|
||
| // case 7: expect number not included in the above case to return th | ||
| test("should return 'th' for numbers ending with 4, 5,6,7,8,9,0", () => { | ||
| expect(getOrdinalNumber(4)).toEqual("4th"); | ||
| expect(getOrdinalNumber(5)).toEqual("5th"); | ||
| expect(getOrdinalNumber(6)).toEqual("6th"); | ||
| expect(getOrdinalNumber(7)).toEqual("7th"); | ||
| expect(getOrdinalNumber(8)).toEqual("8th"); | ||
| expect(getOrdinalNumber(9)).toEqual("9th"); | ||
| expect(getOrdinalNumber(10)).toEqual("10th"); | ||
|
Comment on lines
+58
to
+67
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Your tests are fine. But there might be one edge case you are missing out on. You handled 11 and 13; is there one more key group you might have missed?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes you caught me I think is 12 |
||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,11 @@ | ||
| function repeatStr() { | ||
| return "hellohellohello"; | ||
| function repeatStr(str, count) { | ||
| if (count >= 1) { | ||
| return str.repeat(count); | ||
| } else if (count === 0) { | ||
| return ""; | ||
| } else { | ||
| throw new Error("Invalid count"); | ||
| } | ||
| } | ||
|
|
||
| module.exports = repeatStr; |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a better arithmetic operator to be used for this function instead of string indexing. This ensures all edge cases are handled in your tests. To ensure code clarity and to avoid string manipulation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have a look at that said operator and how to use it moving forward.