Skip to content

Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 1 | Coursework#999

Open
MehrozMunir wants to merge 4 commits intoCodeYourFuture:mainfrom
MehrozMunir:coursework/sprint-1
Open

Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 1 | Coursework#999
MehrozMunir wants to merge 4 commits intoCodeYourFuture:mainfrom
MehrozMunir:coursework/sprint-1

Conversation

@MehrozMunir
Copy link

@MehrozMunir MehrozMunir commented Feb 20, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have completed all the exercises in Sprint-1 inluding key-exercises, mandatory errors, mandatory interpret abd stretch explore

Questions

I have one question regarding the code already provided in 3-to-pounds.js file in mandatory-interpret section.
I have added my note on line no. 36 of this file.
My questions is regarding the below piece of code in that file:
.padEnd(2, "0")
As I think, we don't need the padding there and it does not serve any purpose.

@MehrozMunir MehrozMunir added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Feb 20, 2026
@JaypeeLan JaypeeLan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 1, 2026
JaypeeLan
JaypeeLan reviewed Mar 1, 2026
View reviewed changes
Sprint-1/2-mandatory-errors/3.js Outdated
//After running the code, I have realized that the code is not working because cardNumber is a number and the slice is a method in String class
//so, in order to make it work, we need to change cardNumber to String before calling the slice method

const last4Digits = (cardNumber + "").slice(-4);
Copy link

@JaypeeLan JaypeeLan Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but other people might not be able to understand. So always use the String() function to convert to string.

Copy link
Author

@MehrozMunir MehrozMunir Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for highlighint this issue. I have fixed it by using the String class instead of concatenation. I have pushed my changes. Please review the changes. Thanks.

Copy link

@JaypeeLan JaypeeLan Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Some heads up, please update the label back to need review when you make a new push, after a review.

Copy link
Author

@MehrozMunir MehrozMunir Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I did that, but the git bot is not letting me as there is some issue if by mistake I made any changes in other sprints for this commit. Though in the commit it is showing me the changes made to only sprint 1 files. I am figuring out how to resolve this issue.

Once I be able to do that, I will add the needs review label and would let you know.

Thanks.

@JaypeeLan JaypeeLan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 1, 2026
@MehrozMunir MehrozMunir added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 2, 2026
@JaypeeLan JaypeeLan added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@JaypeeLan JaypeeLan added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@MehrozMunir
Copy link
Author

MehrozMunir commented Mar 2, 2026 •
edited
Loading

Hi @JaypeeLan
There is some issue with the new commit, the git bot is not accepting it. Let me resolve that and then I will be able to change this to needs review.

@JaypeeLan JaypeeLan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@MehrozMunir MehrozMunir force-pushed the coursework/sprint-1 branch from 6349e37 to 3d20367 Compare March 2, 2026 13:28
@MehrozMunir MehrozMunir added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 2, 2026
@MehrozMunir
Copy link
Author

MehrozMunir commented Mar 2, 2026 •
edited
Loading

Hi @JaypeeLan
I just fixed the issue of commit. Check the change now and review my code please. I have added the needs review label now.

Thanks

@JaypeeLan JaypeeLan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JaypeeLan JaypeeLan JaypeeLan left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MehrozMunir @JaypeeLan