onPostInputUpdate is now an event#948
Open
betpowo wants to merge 1 commit intoCodenameCrew:mainfrom
Open
Conversation
since it had practically no info passed onto it it was basically useless. but now there is info so now it can actually be used to like get the finalized changes done inside onInputUpdate ## will break mods that do use this function, as a required argument has been added
Contributor
|
Why? In HScript, when calling the |
Contributor
|
If it still uses |
Contributor
This is false since HScript doesn't care if you leave out paramaters in a function, thought it does care if there are more parameters than required Example: function onPostInputUpdate() {
trace("valid");
}
function onPostInputUpdate(event:InputEvent) {
trace("valid");
}
function onPostInputUpdate(event:InputEvent, whatever:Dynamic) {
trace("invalid and will die");
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since it had practically no info passed onto it it was basically useless. but now there is info so now it can actually be used to like get the finalized changes done inside onInputUpdate
will break mods that do use this function, as a required argument has been added