Skip to content

Pin dependencies #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Coldaine wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pin dependencies #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f542a9
Pin dependencies
renovate-bot Sep 22, 2026
5c4c363
Keep the pinned lint jobs on Python 3.11 and drop unused checkout cre…
Coldaine Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
with:
persist-credentials: false

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
with:
python-version: ${{ matrix.python-version }}
cache: 'pip'
Expand Down Expand Up @@ -70,7 +72,7 @@ jobs:
QT_QPA_PLATFORM: offscreen

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@ab904c41d6ece82784817410c45d8b8c02684457 # v3

@kilo-code-bot kilo-code-bot Bot Sep 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: codecov/codecov-action is pinned to the deprecated v3 line, and this diff is the last cheap chance to move off it.

Every other action in this PR keeps its prior major (checkout v4, setup-python v5, upload-artifact v4); only codecov stops at v3. codecov/codecov-action@v3 depends on the legacy Codecov uploader, which Codecov deprecated and which is scheduled for full shutdown — after that the upload step at .github/workflows/ci.yml:74-80 silently stops reporting (fail_ci_if_error: false hides the failure), and the coverage gate must then be read only from the pytest step's --cov-fail-under=75.

Moving the pre-existing v3 pin to a v4/v5 commit digest is a larger change than this Renovate PR's scope, so this is a follow-up rather than a blocker. When you take it, add codecov/codecov-action to renovate.json's grouping (or a dedicated PR) and re-verify the updated file: input, which changed shape between v3 and v4+ (file: is deprecated in favor of files:).

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

with:
file: ./coverage.xml
flags: unittests
Expand All @@ -81,10 +83,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
with:
persist-credentials: false

- name: Set up Python
uses: actions/setup-python@v5
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
with:
python-version: '3.11'

Expand Down
14 changes: 9 additions & 5 deletions .github/workflows/visual-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
with:
persist-credentials: false

- name: Set up Python ${{ inputs.python_version || '3.11' }}
uses: actions/setup-python@v5
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
with:
python-version: ${{ inputs.python_version || '3.11' }}
cache: 'pip'
Expand Down Expand Up @@ -149,7 +151,7 @@ jobs:

- name: Upload screenshots
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
with:
name: overlay-screenshots-${{ github.sha }}
path: screenshots/
Expand Down Expand Up @@ -228,10 +230,12 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
with:
persist-credentials: false

- name: Set up Python 3.11
uses: actions/setup-python@v5
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
with:
python-version: '3.11'
cache: 'pip'
Expand Down
Loading