Skip to content

ci: enable worker leg in production deploy (dual-target) — Phase 2 Part 3#1729

Merged
tarunnjoshi merged 4 commits into
devfrom
ci/enable-worker-deploy
Jul 15, 2026
Merged

ci: enable worker leg in production deploy (dual-target) — Phase 2 Part 3#1729
tarunnjoshi merged 4 commits into
devfrom
ci/enable-worker-deploy

Conversation

@Satendra-SR

@Satendra-SR Satendra-SR commented Jul 14, 2026

Copy link
Copy Markdown
Member

Uncomments the worker matrix leg in production-deployment.yml, so a push to main deploys to both the web and worker tiers in parallel (fail-fast: false, workflow-level concurrency).

Worker target: PROD_SSH_WORKER_HOST = Elastic IP 13.207.97.62 (stable). Reached over SSH — same mechanism as web (login via PROD_SSH_PRIVATE_KEYgit reset --hard as apache via sudo). Key A verified authenticating to the worker via the EIP; the worker inherits the same git checkout/docroot from the prod clone.

Before merging

  • Coordinate with the Part 4 cutover so both tiers are code-synced going into go-live.
  • Shared-DB caveat: git reset --hard runs per host; any CiviCRM DB-upgrade/schema/cache step must run once, not per-host (see the deploy runbook).

Draft until cutover timing.

Ref: coloredcow-admin/goonj-crm#342

Summary by CodeRabbit

  • New Features
    • Production deployments now target both web and worker servers.
    • Worker deployments are automatically included in the deployment process.

tarunnjoshi and others added 4 commits July 14, 2026 13:47
Production release 14 july (2)
Uncomment the worker matrix leg so a push to main deploys to both the web and
worker tiers in parallel. Worker reachable via PROD_SSH_WORKER_HOST (SSH, same
Key A + apache-sudo path as web). Phase 2 Part 3.

Ref: coloredcow-admin/goonj-crm#342
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The production deployment workflow now runs its SSH deployment step for both web and worker targets by activating the worker entry in the deployment matrix.

Changes

Production deployment

Layer / File(s) Summary
Enable worker deployment
.github/workflows/production-deployment.yml
The deployment matrix now includes PROD_SSH_WORKER_HOST as an active worker target alongside the web target.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

Web and worker join the flight,
SSH carries code through night.
One matrix row, deployment bright—
Two hosts now launch right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: enabling the worker deployment leg in the production deploy workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/enable-worker-deploy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Satendra-SR Satendra-SR changed the base branch from main to dev July 15, 2026 05:40
@Satendra-SR Satendra-SR marked this pull request as ready for review July 15, 2026 05:40

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/production-deployment.yml (1)

18-18: 🗄️ Data Integrity & Integration | 🔵 Trivial

Keep shared production mutations out of the matrix job.

Enabling the worker causes every matrix step to run twice in parallel. The shown Git sync is host-local, but verify that no subsequent steps perform database migrations, schema changes, cache flushes, or other singleton operations; those must run in a separate one-time job.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/production-deployment.yml at line 18, Update the
production deployment workflow’s matrix configuration around the worker entry so
host-local Git synchronization remains parallelizable, while any subsequent
singleton operations such as migrations, schema changes, or cache flushes are
removed from the matrix path and moved into a separate one-time deployment job.
Preserve independent per-host deployment steps for the matrix targets.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/production-deployment.yml:
- Line 18: Update the production deployment workflow’s matrix configuration
around the worker entry so host-local Git synchronization remains
parallelizable, while any subsequent singleton operations such as migrations,
schema changes, or cache flushes are removed from the matrix path and moved into
a separate one-time deployment job. Preserve independent per-host deployment
steps for the matrix targets.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 33e5b4ff-5d3e-4bcc-b4ae-828ac54d731b

📥 Commits

Reviewing files that changed from the base of the PR and between 7b3aa93 and 4fb871d.

📒 Files selected for processing (1)
  • .github/workflows/production-deployment.yml

@tarunnjoshi tarunnjoshi merged commit 234ac79 into dev Jul 15, 2026
1 check passed
@tarunnjoshi tarunnjoshi deleted the ci/enable-worker-deploy branch July 15, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants