[13.1] Use `WithHttpsCertificateConfiguration` to configure tls cert for Otel Collector #1058

afscrome · 2025-12-11T19:34:12Z

Closes #981

Use the new WithHttpsCertificateConfiguration apis in 13.1 rather than the previous custom implementation of exporting the dev cert.

Added some telemetry generator resources to the otel collector's playground app to generate some dummy otel, as well as to test telemetry for container --> container.

PR Checklist

Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
Based off latest main branch of toolkit
PR doesn't include merge commits (always rebase on top of our main, if needed)
Code follows all style conventions

Other information

martinjt

I don't think we need the TelemetryGen as part of this change.

afscrome · 2025-12-15T21:18:05Z

I'll see what I can do tomorrow - reason I added telemetry generator is that I needed something that generated container from a container as I wanted to make sure the cert was being trusted both in host --> container scenarios
(as was already covered by the playground project) and container --> container scenarios

Copilot

Pull request overview

This PR modernizes the OpenTelemetry Collector integration by adopting Aspire 13.1's new WithHttpsCertificateConfiguration API for TLS certificate management, replacing a custom dev certificate export implementation. The change simplifies the codebase by leveraging built-in Aspire functionality.

Replaced custom dev certificate export logic with WithHttpsCertificateConfiguration API
Removed DevCertHostingExtensions.cs shared utility file and associated tests
Enhanced the example app with telemetry generators to demonstrate container-to-container communication

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector/OpenTelemetryCollectorExtensions.cs	Refactored certificate configuration to use new Aspire 13.1 API instead of custom implementation
src/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector.csproj	Removed reference to shared DevCertHostingExtensions.cs file
src/Shared/DevCertHostingExtensions.cs	Deleted entire custom dev certificate hosting extensions utility
tests/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector.Tests/ResourceCreationTests.cs	Removed tests specific to custom dev certificate export implementation
examples/opentelemetry-collector/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector.AppHost/AppHost.cs	Added telemetry generator containers to demonstrate collector functionality

Copilot · 2025-12-15T21:28:53Z

src/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector/OpenTelemetryCollectorExtensions.cs

+            var scheme = useHttpsForRecievers ? "https" : "http";
+            resourceBuilder.WithEndpoint(targetPort: port, name: protocol, scheme: scheme);
+
+            if (!useHttpsForRecievers)


The variable name has a spelling error: "Recievers" should be "Receivers" (the 'i' and 'e' are transposed).

Copilot · 2025-12-15T21:28:54Z

src/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector/OpenTelemetryCollectorExtensions.cs

+                return Task.CompletedTask;
+            });
+#pragma warning restore ASPIRECERTIFICATES001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
+        }        


There is trailing whitespace after the closing brace. This should be removed for consistent code formatting.

Suggested change

}

}

Copilot · 2025-12-15T21:28:54Z

...elemetry-collector/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector.AppHost/AppHost.cs

+        .WithArgs(signal,
+            "--duration", "inf",
+            "--otlp-endpoint", collector.GetEndpoint("grpc").Property(EndpointProperty.HostAndPort))
+        .WithArgs(args)


The variable args is not defined in the scope of the AddTelemetryGenerator method. This appears to be a bug as it references the command-line arguments from the Main method which are not accessible here. This line should likely be removed since the necessary arguments are already added on lines 21-23.

Suggested change

.WithArgs(args)

Copilot · 2025-12-15T21:28:54Z

src/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector/OpenTelemetryCollectorExtensions.cs

-        if (!settings.ForceNonSecureReceiver && isHttpsEnabled && builder.ExecutionContext.IsRunMode)
-        {
-            resourceBuilder.RunWithHttpsDevCertificate();
+        var useHttpsForRecievers = !settings.ForceNonSecureReceiver && url.StartsWith("https", StringComparison.OrdinalIgnoreCase);


The variable name has a spelling error: "Recievers" should be "Receivers" (the 'i' and 'e' are transposed).

Copilot · 2025-12-15T21:28:55Z

src/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector/OpenTelemetryCollectorExtensions.cs

+
+        void ConfigureReceiver(int port, string protocol)
+        {
+            var scheme = useHttpsForRecievers ? "https" : "http";


The variable name has a spelling error: "Recievers" should be "Receivers" (the 'i' and 'e' are transposed).

Copilot · 2025-12-15T21:28:55Z

src/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector/OpenTelemetryCollectorExtensions.cs

+                ctx.Arguments.Add(ReferenceExpression.Create($@"--config=yaml:receivers::otlp::protocols::{protocol}::tls::cert_file: ""{ctx.CertificatePath}"""));
+                ctx.Arguments.Add(ReferenceExpression.Create($@"--config=yaml:receivers::otlp::protocols::{protocol}::tls::key_file: ""{ctx.KeyPath}"""));


Default 'ToString()': ReferenceExpression inherits 'ToString()' from 'Object', and so is not suitable for printing.

Suggested change

ctx.Arguments.Add(ReferenceExpression.Create($@"--config=yaml:receivers::otlp::protocols::{protocol}::tls::cert_file: ""{ctx.CertificatePath}"""));

ctx.Arguments.Add(ReferenceExpression.Create($@"--config=yaml:receivers::otlp::protocols::{protocol}::tls::key_file: ""{ctx.KeyPath}"""));

ctx.Arguments.Add($@"--config=yaml:receivers::otlp::protocols::{protocol}::tls::cert_file: ""{ctx.CertificatePath}""");

ctx.Arguments.Add($@"--config=yaml:receivers::otlp::protocols::{protocol}::tls::key_file: ""{ctx.KeyPath}""");

ReferenceExpression is absolutely required here as certificate and key paths cannot be resolve until after the app host starts.

Copilot · 2025-12-15T21:28:55Z

src/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector/OpenTelemetryCollectorExtensions.cs

+                ctx.Arguments.Add(ReferenceExpression.Create($@"--config=yaml:receivers::otlp::protocols::{protocol}::tls::cert_file: ""{ctx.CertificatePath}"""));
+                ctx.Arguments.Add(ReferenceExpression.Create($@"--config=yaml:receivers::otlp::protocols::{protocol}::tls::key_file: ""{ctx.KeyPath}"""));


Default 'ToString()': ReferenceExpression inherits 'ToString()' from 'Object', and so is not suitable for printing.

Suggested change

ctx.Arguments.Add(ReferenceExpression.Create($@"--config=yaml:receivers::otlp::protocols::{protocol}::tls::cert_file: ""{ctx.CertificatePath}"""));

ctx.Arguments.Add(ReferenceExpression.Create($@"--config=yaml:receivers::otlp::protocols::{protocol}::tls::key_file: ""{ctx.KeyPath}"""));

ctx.Arguments.Add($@"--config=yaml:receivers::otlp::protocols::{protocol}::tls::cert_file: ""{ctx.CertificatePath}""");

ctx.Arguments.Add($@"--config=yaml:receivers::otlp::protocols::{protocol}::tls::key_file: ""{ctx.KeyPath}""");

ReferenceExpression is absolutely required here as certificate and key paths cannot be resolve until after the app host starts.

Use the new `WithHttpsCertificateConfiguration` apis in 13.1 rather than the previous custom implementation of exporting the dev cert.

afscrome requested a review from martinjt as a code owner December 11, 2025 19:34

afscrome changed the title ~~Use WithHttpsCertificateConfiguration to configure tls cert for the…~~ [13.1] Use WithHttpsCertificateConfiguration to configure tls cert for Otel Collector Dec 11, 2025

martinjt requested changes Dec 15, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings December 15, 2025 21:18

Copilot started reviewing on behalf of afscrome December 15, 2025 21:18 View session

Copilot AI reviewed Dec 15, 2025

View reviewed changes

Use the new WithHttpsCertificateConfiguration apis for Otel Collector

163148e

Use the new `WithHttpsCertificateConfiguration` apis in 13.1 rather than the previous custom implementation of exporting the dev cert.

afscrome force-pushed the otel-tls-injection2 branch from 04e47c4 to 163148e Compare December 17, 2025 22:30

		ctx.Arguments.Add(ReferenceExpression.Create($@"--config=yaml:receivers::otlp::protocols::{protocol}::tls::cert_file: ""{ctx.CertificatePath}"""));
		ctx.Arguments.Add(ReferenceExpression.Create($@"--config=yaml:receivers::otlp::protocols::{protocol}::tls::key_file: ""{ctx.KeyPath}"""));

[13.1] Use WithHttpsCertificateConfiguration to configure tls cert for Otel Collector #1058

Are you sure you want to change the base?

[13.1] Use WithHttpsCertificateConfiguration to configure tls cert for Otel Collector #1058

Uh oh!

Conversation

afscrome commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Other information

Uh oh!

martinjt left a comment

Choose a reason for hiding this comment

Uh oh!

afscrome commented Dec 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

afscrome Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

afscrome Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[13.1] Use `WithHttpsCertificateConfiguration` to configure tls cert for Otel Collector #1058

[13.1] Use `WithHttpsCertificateConfiguration` to configure tls cert for Otel Collector #1058

afscrome commented Dec 11, 2025 •

edited

Loading