Sorting resources in Farmer/Arm for ease of maintenance.#1098
Sorting resources in Farmer/Arm for ease of maintenance.#1098ninjarobot wants to merge 1 commit intomasterfrom
Conversation
|
@isaacabraham the project has gotten pretty big and needs a little more organization. I made a few changes here to reduce the dependencies between IArmResource modules and allow most of them to be alphabetically sorted. What do you think? Any recommendations to make it easier to navigate? |
mattgallagher92
left a comment
mattgallagher92
left a comment
There was a problem hiding this comment.
Thanks @ninjarobot, looks a fair bit tidier! I have a few small queries (in other threads).
|
|
||
| let fileShares = | ||
| ResourceType("Microsoft.Storage/storageAccounts/fileServices/shares", "2019-06-01") | ||
| let fileShares = ResourceTypes.Storage.fileServices |
There was a problem hiding this comment.
Looks like this is wrong? I don't think it should be the same as the value above.
| let routeTables = ResourceType("Microsoft.Network/routeTables", "2021-01-01") | ||
| let routes = ResourceType("Microsoft.Network/routeTables/routes", "2021-01-01") | ||
|
|
||
| let routeServers = ResourceType("Microsoft.Network/virtualHubs", "2022-11-01") |
There was a problem hiding this comment.
routeServers and virtualHubs sound quite different. What's the reason for the discrepancy?
|
@ninjarobot This looks good - assuming that the conflicts can be resolved + Matt's questions addressed? |
Yes, they can be, I will need to get back to this cleanup. |
3 participants
The changes in this PR are as follows:
I have read the contributing guidelines and have completed the following: