Open
Conversation
ninjarobot
reviewed
Sep 22, 2022
Collaborator
ninjarobot
left a comment
ninjarobot
left a comment
There was a problem hiding this comment.
This looks good - my one suggestion is to have a separate workflow for building and publishing the nuget package so it can be triggered on releases instead of on merges.
| run: dotnet build -c release | ||
| - name: Run Tests | ||
| run: dotnet test -c release -l trx --collect:"XPlat Code Coverage" | ||
| - name: Create NuGet Package |
Collaborator
There was a problem hiding this comment.
You might want to consider moving this to a different action so it's triggered when releases are created rather than on every push to master. Here's an example from one of my other projects.
Contributor
|
@isaacabraham any chance you will have some time to re visit this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.