⚡ Bolt: [성능 개선] validate_opencode_failed_check_review.sh 파이썬 정규식 사전 컴파일#351
Closed
seonghobae wants to merge 6 commits into
Closed
⚡ Bolt: [성능 개선] validate_opencode_failed_check_review.sh 파이썬 정규식 사전 컴파일#351seonghobae wants to merge 6 commits into
seonghobae wants to merge 6 commits into
Conversation
… 최적화 validate_opencode_failed_check_review.sh 스크립트 내부의 Python 코드에서 반복적으로 호출되는 `clean`, `starts_new_field`, `_handle_window_start`, `_handle_continuation`, `_parse_field` 함수 내의 정규식(`re.sub`, `re.match` 등)을 모듈 레벨에서 미리 컴파일(`re.compile`)하도록 개선하여 반복적인 텍스트 파싱 과정의 성능을 향상시켰습니다.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
… 최적화 validate_opencode_failed_check_review.sh 스크립트 내부의 Python 코드에서 반복적으로 호출되는 `clean`, `starts_new_field`, `_handle_window_start`, `_handle_continuation`, `_parse_field` 함수 내의 정규식(`re.sub`, `re.match` 등)을 모듈 레벨에서 미리 컴파일(`re.compile`)하도록 개선하여 반복적인 텍스트 파싱 과정의 성능을 향상시켰습니다.
Contributor
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Evidence
Python project dependencies (.)
Python coverage with missing-line report (.)
Python docstring coverage advisory
Coverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow (2 files)"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow (2 files)"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file: bolt.md"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file: bolt.md"]
R2 --> V2["required checks"]
Evidence --> S3["CI script (4 files)"]
S3 --> I3["review and security gate shell path"]
I3 --> R3["Review risk: CI script (4 files)"]
R3 --> V3["bash -n plus Strix self-test"]
Evidence --> S4["Test (2 files)"]
S4 --> I4["regression suite"]
I4 --> R4["Review risk: Test (2 files)"]
R4 --> V4["targeted test run"]
|
… 최적화 validate_opencode_failed_check_review.sh 스크립트 내부의 Python 코드에서 반복적으로 호출되는 `clean`, `starts_new_field`, `_handle_window_start`, `_handle_continuation`, `_parse_field` 함수 내의 정규식(`re.sub`, `re.match` 등)을 모듈 레벨에서 미리 컴파일(`re.compile`)하도록 개선하여 반복적인 텍스트 파싱 과정의 성능을 향상시켰습니다.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head2c96ba878bd9d170c0eb44ab654758a65c86c13d. -
Head SHA:
2c96ba878bd9d170c0eb44ab654758a65c86c13d -
Workflow run: 29056207644
-
Workflow attempt: 1
Coverage evidence
Coverage Evidence
- Head SHA:
2c96ba878bd9d170c0eb44ab654758a65c86c13d - Required test evidence: supported repository test suites must pass.
- Required docstring evidence: repository-owned docstring gates must pass when configured; otherwise docstring coverage is advisory.
Python project dependencies (.)
Using CPython 3.12.3 interpreter at: /usr/bin/python3
Creating virtual environment at: .venv
Resolved 17 packages in 251ms
Downloading pygments (1.2MiB)
Downloaded pygments
Prepared 13 packages in 143ms
Installed 13 packages in 11ms
+ attrs==26.1.0
+ click==8.4.2
+ colorama==0.4.6
+ coverage==7.15.0
+ iniconfig==2.3.0
+ interrogate==1.7.0
+ packaging==26.2
+ pluggy==1.6.0
+ py==1.11.0
+ pygments==2.20.0
+ pytest==9.1.1
+ pytest-cov==7.1.0
+ tabulate==0.10.0
- Result: PASS
Python coverage with missing-line report (.)
============================= test session starts ==============================
platform linux -- Python 3.12.3, pytest-9.1.1, pluggy-1.6.0
rootdir: /home/runner/work/.github/.github/pr-head
configfile: pyproject.toml
plugins: cov-7.1.0
collected 174 items
tests/test_assert_opencode_reasoning_effort.py ........ [ 4%]
tests/test_codeql_pr_workflow_contract.py . [ 5%]
tests/test_noema_review_gate.py .......F... [ 11%]
tests/test_opencode_agent_contract.py .....F...F... [ 18%]
tests/test_opencode_review_normalize_output.py ......................... [ 33%]
[ 33%]
tests/test_opencode_workflow_shell_syntax.py . [ 33%]
tests/test_pr_governance_audit_contract.py ... [ 35%]
tests/test_pr_review_fix_scheduler.py ................... [ 46%]
tests/test_pr_review_fix_scheduler_coverage.py .. [ 47%]
tests/test_pr_review_merge_scheduler.py ................................ [ 66%]
............................... [ 83%]
tests/test_render_opencode_prompt_template.py .... [ 86%]
tests/test_required_workflow_queue_contract.py ....... [ 90%]
tests/test_review_execution_contracts.py .. [ 91%]
tests/test_sandboxed_verify.py ......... [ 96%]
tests/test_sandboxed_web_e2e.py ...... [100%]
=================================== FAILURES ===================================
_______________ test_call_llm_handles_configuration_and_verdicts _______________
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7fc77136ae40>
def test_call_llm_handles_configuration_and_verdicts(monkeypatch):
pr = make_pr()
monkeypatch.delenv("NOEMA_LLM_API_URL", raising=False)
monkeypatch.delenv("NOEMA_LLM_API_KEY", raising=False)
assert noema.call_llm("owner/repo", 1, pr, "diff", False) is None
monkeypatch.setenv("NOEMA_LLM_API_URL", "file:///etc/passwd")
monkeypatch.setenv("NOEMA_LLM_API_KEY", "secret")
> with pytest.raises(ValueError, match="must start with http:// or https://"):
E AssertionError: Regex pattern did not match.
E Expected regex: 'must start with http:// or https://'
E Actual message: 'URL scheme must be http or https'
tests/test_noema_review_gate.py:209: AssertionError
----------------------------- Captured stdout call -----------------------------
Noema LLM review unavailable: NOEMA_LLM_API_URL or NOEMA_LLM_API_KEY is not configured.
___________ test_workflow_provisions_sandbox_tool_and_reviewer_agent ___________
def test_workflow_provisions_sandbox_tool_and_reviewer_agent():
"""Guard the runtime OpenCode workspace, not only repo-local config."""
workflow = Path(".github/workflows/opencode-review.yml").read_text(
encoding="utf-8"
)
assert "code-reviewer-prompt.md" in workflow
assert "sandboxed_verify.py" in workflow
assert "sandboxed_web_e2e.py" in workflow
assert "review_execution_contracts.py" in workflow
assert "SANDBOXED_VERIFY_RESULT" in workflow
assert "SANDBOXED_WEB_E2E_RESULT" in workflow
assert "Docker Compose, devcontainer, Nix, or temporary package-install sandbox" in workflow
assert "scientific, statistical, simulation" in workflow
assert "skewed true" in workflow
assert "object naming" in workflow
assert "connected code paths, rendering paths" in workflow
assert "CHECK_LOOKUP_GH_TOKEN" in workflow
assert "retrying with workflow github token" in workflow
assert 'review_write_token="$GH_TOKEN"' in workflow
assert 'review_write_token="$OPENCODE_APP_TOKEN"' in workflow
assert 'review_write_token="$CHECK_LOOKUP_GH_TOKEN"' in workflow
assert 'review_write_token="${OPENCODE_APP_TOKEN:-$GH_TOKEN}"' not in workflow
assert "Review execution contracts" in workflow
assert "Accessibility/i18n:" in workflow
assert "Supply-chain/license:" in workflow
assert "Packaging:" in workflow
assert 'gsub("`"; "\'")' not in workflow
assert 'gsub("`"; "'")' in workflow
assert '"code-reviewer"' in workflow
assert workflow.count('"reasoningEffort": "high"') >= 10
assert '"task": "allow"' in workflow
assert 'cat >"$prompt_file" <<EOF' not in workflow
assert 'cat >"$prompt_file" <<\'EOF\'' not in workflow
assert "Run OpenCode PR Review model pool" in workflow
assert "opencode_review_model_pool" in workflow
assert "run_opencode_review_model_pool.sh" in workflow
assert "OPENCODE_MODEL_CANDIDATES" in workflow
model_pool_runner = Path("scripts/ci/run_opencode_review_model_pool.sh").read_text(encoding="utf-8")
assert "assert_reasoning_effort_for_candidate" in model_pool_runner
assert "assert_opencode_reasoning_effort.py" in model_pool_runner
assert "--config opencode.jsonc" in model_pool_runner
reasoning_effort_guard = Path("scripts/ci/assert_opencode_reasoning_effort.py").read_text(encoding="utf-8")
assert 'options.reasoningEffort=high' in reasoning_effort_guard
assert 'variants.high.reasoningEffort=high' in reasoning_effort_guard
assert "deepseek/deepseek-r1" in reasoning_effort_guard
assert "--config \"$OPENCODE_REVIEW_WORKDIR/opencode.jsonc\"" in workflow
assert 'timeout --kill-after=15s "${export_timeout_seconds}s" opencode export' in model_pool_runner
assert "session export did not complete within %ss" in model_pool_runner
assert "Follow the complete review contract" in model_pool_runner
assert "packet-first entry point" in model_pool_runner
assert "Current-head evidence packet" in model_pool_runner
assert "not a generic model-exhaustion message" in model_pool_runner
assert "is_context_overflow_failure" in model_pool_runner
assert "tokens_limit_reached" in model_pool_runner
assert "skipping remaining attempts for this model" in model_pool_runner
assert "approve_low_risk_review_fallback_after_model_exhaustion" not in workflow
assert "changed_file_is_low_risk_review_fallback" not in workflow
assert "approve_central_review_process_fallback" not in workflow
assert "opencode.jsonc | \\" in workflow
assert "scripts/ci/run_opencode_review_model_pool.sh | \\" in workflow
assert "tests/test_opencode_agent_contract.py | \\" in workflow
assert "ContextualWisdomLab/appguardrail:scripts/ci/collect_org_security_failures.py" in workflow
assert "ContextualWisdomLab/appguardrail:.github/workflows/org-security-failure-collector.yml" in workflow
assert "ContextualWisdomLab/appguardrail:tests/test_org_security_failure_collector.py" in workflow
assert "appguardrail org-security failure collector" in workflow
assert 'max_changed_count=3' in workflow
assert "changed_count\" -gt \"$max_changed_count\"" in workflow
assert "steps.central_review_process_fallback_scope.outputs.eligible != 'true'" not in workflow
assert workflow.index("Detect central review-process scope") < workflow.index(
"Initialize CodeGraph index for OpenCode"
)
assert "CENTRAL_REVIEW_PROCESS_FALLBACK_ELIGIBLE" in workflow
assert "CENTRAL_REVIEW_PROCESS_FALLBACK_SCOPE_LABEL" in workflow
assert "model pool was intentionally skipped" not in workflow
assert "deterministic fallback" not in workflow
assert "production source 또는 package manifest 변경이 없습니다" not in workflow
assert "request_changes_for_coverage_evidence_failure" in workflow
assert '"## Review outcome"' in workflow
assert '"## Check outcome"' not in workflow
assert "publish REQUEST_CHANGES when coverage-evidence blocker states" in workflow
> assert re.search(r"opencode-review-target:[\s\S]{0,240}timeout-minutes: 360", workflow)
E assert None
E + where None = <function search at 0x7fc772c90220>('opencode-review-target:[\\s\\S]{0,240}timeout-minutes: 360', 'name: Required OpenCode Review\n\non:\n pull_request_target:\n types: [opened, synchronize, reopened, ready_for_r... The scheduled and PR-event scheduler paths remain authoritative.\\n\' "$GH_REPOSITORY" "$base_branch"\n fi\n')
E + where <function search at 0x7fc772c90220> = re.search
tests/test_opencode_agent_contract.py:283: AssertionError
__________ test_merge_scheduler_uses_escalating_mutation_credentials ___________
def test_merge_scheduler_uses_escalating_mutation_credentials():
"""Guard immediate merge/update execution credentials for central scheduling."""
workflow = Path(".github/workflows/pr-review-merge-scheduler.yml").read_text(
encoding="utf-8"
)
assert "id-token: write" in workflow
assert "Exchange OpenCode app token for scheduler mutations" in workflow
assert "secrets.PR_REVIEW_MERGE_TOKEN" in workflow
assert "secrets.OPENCODE_APPROVE_TOKEN" in workflow
assert "steps.scheduler_app_token.outputs.token" in workflow
assert "SCHEDULER_READ_TOKEN: ${{ github.token }}" in workflow
assert "SCHEDULER_MUTATION_TOKEN_SOURCE" in workflow
> assert 'default: "-1"' in workflow
E assert 'default: "-1"' in 'name: Required PR Review Merge Scheduler\n\non:\n push:\n branches: [main, develop, master]\n pull_request_targe... args+=(--no-update-branches)\n fi\n python3 scripts/ci/pr_review_merge_scheduler.py "${args[@]}"\n'
tests/test_opencode_agent_contract.py:415: AssertionError
=============================== warnings summary ===============================
tests/test_assert_opencode_reasoning_effort.py::test_module_entrypoint_success
<frozen runpy>:128: RuntimeWarning: 'scripts.ci.assert_opencode_reasoning_effort' found in sys.modules after import of package 'scripts.ci', but prior to execution of 'scripts.ci.assert_opencode_reasoning_effort'; this may result in unpredictable behaviour
tests/test_render_opencode_prompt_template.py::test_module_entrypoint
<frozen runpy>:128: RuntimeWarning: 'scripts.ci.render_opencode_prompt_template' found in sys.modules after import of package 'scripts.ci', but prior to execution of 'scripts.ci.render_opencode_prompt_template'; this may result in unpredictable behaviour
tests/test_review_execution_contracts.py::test_discovers_package_managers_java_r_json_and_main
<frozen runpy>:128: RuntimeWarning: 'scripts.ci.review_execution_contracts' found in sys.modules after import of package 'scripts.ci', but prior to execution of 'scripts.ci.review_execution_contracts'; this may result in unpredictable behaviour
tests/test_sandboxed_verify.py::test_module_main_entrypoint
<frozen runpy>:128: RuntimeWarning: 'scripts.ci.sandboxed_verify' found in sys.modules after import of package 'scripts.ci', but prior to execution of 'scripts.ci.sandboxed_verify'; this may result in unpredictable behaviour
tests/test_sandboxed_web_e2e.py::test_module_import_and_main_entrypoint
<frozen runpy>:128: RuntimeWarning: 'scripts.ci.sandboxed_web_e2e' found in sys.modules after import of package 'scripts.ci', but prior to execution of 'scripts.ci.sandboxed_web_e2e'; this may result in unpredictable behaviour
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/test_noema_review_gate.py::test_call_llm_handles_configuration_and_verdicts - AssertionError: Regex pattern did not match.
Expected regex: 'must start with http:// or https://'
Actual message: 'URL scheme must be http or https'
FAILED tests/test_opencode_agent_contract.py::test_workflow_provisions_sandbox_tool_and_reviewer_agent - assert None
+ where None = <function search at 0x7fc772c90220>('opencode-review-target:[\\s\\S]{0,240}timeout-minutes: 360', 'name: Required OpenCode Review\n\non:\n pull_request_target:\n types: [opened, synchronize, reopened, ready_for_r... The scheduled and PR-event scheduler paths remain authoritative.\\n\' "$GH_REPOSITORY" "$base_branch"\n fi\n')
+ where <function search at 0x7fc772c90220> = re.search
FAILED tests/test_opencode_agent_contract.py::test_merge_scheduler_uses_escalating_mutation_credentials - assert 'default: "-1"' in 'name: Required PR Review Merge Scheduler\n\non:\n push:\n branches: [main, develop, master]\n pull_request_targe... args+=(--no-update-branches)\n fi\n python3 scripts/ci/pr_review_merge_scheduler.py "${args[@]}"\n'
================== 3 failed, 171 passed, 5 warnings in 5.73s ===================
- Result: FAIL (exit 1)
Python docstring coverage advisory
RESULT: PASSED (minimum: 100.0%, actual: 100.0%)
- Result: PASS
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow (2 files)"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow (2 files)"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file: bolt.md"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file: bolt.md"]
R2 --> V2["required checks"]
Evidence --> S3["CI script (4 files)"]
S3 --> I3["review and security gate shell path"]
I3 --> R3["Review risk: CI script (4 files)"]
R3 --> V3["bash -n plus Strix self-test"]
Evidence --> S4["Test (2 files)"]
S4 --> I4["regression suite"]
I4 --> R4["Review risk: Test (2 files)"]
R4 --> V4["targeted test run"]
Contributor
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head9b12fc743d26e23db6e73592dd2cfa50b56e2dd1. -
Head SHA:
9b12fc743d26e23db6e73592dd2cfa50b56e2dd1 -
Workflow run: 29056783654
-
Workflow attempt: 1
Coverage evidence
Coverage Evidence
- Head SHA:
9b12fc743d26e23db6e73592dd2cfa50b56e2dd1 - Required test evidence: supported repository test suites must pass.
- Required docstring evidence: repository-owned docstring gates must pass when configured; otherwise docstring coverage is advisory.
Python project dependencies (.)
Using CPython 3.12.3 interpreter at: /usr/bin/python3
Creating virtual environment at: .venv
Resolved 17 packages in 128ms
Downloading pygments (1.2MiB)
Downloaded pygments
Prepared 13 packages in 104ms
Installed 13 packages in 15ms
+ attrs==26.1.0
+ click==8.4.2
+ colorama==0.4.6
+ coverage==7.15.0
+ iniconfig==2.3.0
+ interrogate==1.7.0
+ packaging==26.2
+ pluggy==1.6.0
+ py==1.11.0
+ pygments==2.20.0
+ pytest==9.1.1
+ pytest-cov==7.1.0
+ tabulate==0.10.0
- Result: PASS
Python coverage with missing-line report (.)
============================= test session starts ==============================
platform linux -- Python 3.12.3, pytest-9.1.1, pluggy-1.6.0
rootdir: /home/runner/work/.github/.github/pr-head
configfile: pyproject.toml
plugins: cov-7.1.0
collected 174 items
tests/test_assert_opencode_reasoning_effort.py ........ [ 4%]
tests/test_codeql_pr_workflow_contract.py . [ 5%]
tests/test_noema_review_gate.py .......F... [ 11%]
tests/test_opencode_agent_contract.py .....F...F... [ 18%]
tests/test_opencode_review_normalize_output.py ......................... [ 33%]
[ 33%]
tests/test_opencode_workflow_shell_syntax.py . [ 33%]
tests/test_pr_governance_audit_contract.py ... [ 35%]
tests/test_pr_review_fix_scheduler.py ................... [ 46%]
tests/test_pr_review_fix_scheduler_coverage.py .. [ 47%]
tests/test_pr_review_merge_scheduler.py ................................ [ 66%]
............................... [ 83%]
tests/test_render_opencode_prompt_template.py .... [ 86%]
tests/test_required_workflow_queue_contract.py ....... [ 90%]
tests/test_review_execution_contracts.py .. [ 91%]
tests/test_sandboxed_verify.py ......... [ 96%]
tests/test_sandboxed_web_e2e.py ...... [100%]
=================================== FAILURES ===================================
_______________ test_call_llm_handles_configuration_and_verdicts _______________
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7fc7ad3a4f50>
def test_call_llm_handles_configuration_and_verdicts(monkeypatch):
pr = make_pr()
monkeypatch.delenv("NOEMA_LLM_API_URL", raising=False)
monkeypatch.delenv("NOEMA_LLM_API_KEY", raising=False)
assert noema.call_llm("owner/repo", 1, pr, "diff", False) is None
monkeypatch.setenv("NOEMA_LLM_API_URL", "file:///etc/passwd")
monkeypatch.setenv("NOEMA_LLM_API_KEY", "secret")
> with pytest.raises(ValueError, match="must start with http:// or https://"):
E AssertionError: Regex pattern did not match.
E Expected regex: 'must start with http:// or https://'
E Actual message: 'URL scheme must be http or https'
tests/test_noema_review_gate.py:209: AssertionError
----------------------------- Captured stdout call -----------------------------
Noema LLM review unavailable: NOEMA_LLM_API_URL or NOEMA_LLM_API_KEY is not configured.
___________ test_workflow_provisions_sandbox_tool_and_reviewer_agent ___________
def test_workflow_provisions_sandbox_tool_and_reviewer_agent():
"""Guard the runtime OpenCode workspace, not only repo-local config."""
workflow = Path(".github/workflows/opencode-review.yml").read_text(
encoding="utf-8"
)
assert "code-reviewer-prompt.md" in workflow
assert "sandboxed_verify.py" in workflow
assert "sandboxed_web_e2e.py" in workflow
assert "review_execution_contracts.py" in workflow
assert "SANDBOXED_VERIFY_RESULT" in workflow
assert "SANDBOXED_WEB_E2E_RESULT" in workflow
assert "Docker Compose, devcontainer, Nix, or temporary package-install sandbox" in workflow
assert "scientific, statistical, simulation" in workflow
assert "skewed true" in workflow
assert "object naming" in workflow
assert "connected code paths, rendering paths" in workflow
assert "CHECK_LOOKUP_GH_TOKEN" in workflow
assert "retrying with workflow github token" in workflow
assert 'review_write_token="$GH_TOKEN"' in workflow
assert 'review_write_token="$OPENCODE_APP_TOKEN"' in workflow
assert 'review_write_token="$CHECK_LOOKUP_GH_TOKEN"' in workflow
assert 'review_write_token="${OPENCODE_APP_TOKEN:-$GH_TOKEN}"' not in workflow
assert "Review execution contracts" in workflow
assert "Accessibility/i18n:" in workflow
assert "Supply-chain/license:" in workflow
assert "Packaging:" in workflow
assert 'gsub("`"; "\'")' not in workflow
assert 'gsub("`"; "'")' in workflow
assert '"code-reviewer"' in workflow
assert workflow.count('"reasoningEffort": "high"') >= 10
assert '"task": "allow"' in workflow
assert 'cat >"$prompt_file" <<EOF' not in workflow
assert 'cat >"$prompt_file" <<\'EOF\'' not in workflow
assert "Run OpenCode PR Review model pool" in workflow
assert "opencode_review_model_pool" in workflow
assert "run_opencode_review_model_pool.sh" in workflow
assert "OPENCODE_MODEL_CANDIDATES" in workflow
model_pool_runner = Path("scripts/ci/run_opencode_review_model_pool.sh").read_text(encoding="utf-8")
assert "assert_reasoning_effort_for_candidate" in model_pool_runner
assert "assert_opencode_reasoning_effort.py" in model_pool_runner
assert "--config opencode.jsonc" in model_pool_runner
reasoning_effort_guard = Path("scripts/ci/assert_opencode_reasoning_effort.py").read_text(encoding="utf-8")
assert 'options.reasoningEffort=high' in reasoning_effort_guard
assert 'variants.high.reasoningEffort=high' in reasoning_effort_guard
assert "deepseek/deepseek-r1" in reasoning_effort_guard
assert "--config \"$OPENCODE_REVIEW_WORKDIR/opencode.jsonc\"" in workflow
assert 'timeout --kill-after=15s "${export_timeout_seconds}s" opencode export' in model_pool_runner
assert "session export did not complete within %ss" in model_pool_runner
assert "Follow the complete review contract" in model_pool_runner
assert "packet-first entry point" in model_pool_runner
assert "Current-head evidence packet" in model_pool_runner
assert "not a generic model-exhaustion message" in model_pool_runner
assert "is_context_overflow_failure" in model_pool_runner
assert "tokens_limit_reached" in model_pool_runner
assert "skipping remaining attempts for this model" in model_pool_runner
assert "approve_low_risk_review_fallback_after_model_exhaustion" not in workflow
assert "changed_file_is_low_risk_review_fallback" not in workflow
assert "approve_central_review_process_fallback" not in workflow
assert "opencode.jsonc | \\" in workflow
assert "scripts/ci/run_opencode_review_model_pool.sh | \\" in workflow
assert "tests/test_opencode_agent_contract.py | \\" in workflow
assert "ContextualWisdomLab/appguardrail:scripts/ci/collect_org_security_failures.py" in workflow
assert "ContextualWisdomLab/appguardrail:.github/workflows/org-security-failure-collector.yml" in workflow
assert "ContextualWisdomLab/appguardrail:tests/test_org_security_failure_collector.py" in workflow
assert "appguardrail org-security failure collector" in workflow
assert 'max_changed_count=3' in workflow
assert "changed_count\" -gt \"$max_changed_count\"" in workflow
assert "steps.central_review_process_fallback_scope.outputs.eligible != 'true'" not in workflow
assert workflow.index("Detect central review-process scope") < workflow.index(
"Initialize CodeGraph index for OpenCode"
)
assert "CENTRAL_REVIEW_PROCESS_FALLBACK_ELIGIBLE" in workflow
assert "CENTRAL_REVIEW_PROCESS_FALLBACK_SCOPE_LABEL" in workflow
assert "model pool was intentionally skipped" not in workflow
assert "deterministic fallback" not in workflow
assert "production source 또는 package manifest 변경이 없습니다" not in workflow
assert "request_changes_for_coverage_evidence_failure" in workflow
assert '"## Review outcome"' in workflow
assert '"## Check outcome"' not in workflow
assert "publish REQUEST_CHANGES when coverage-evidence blocker states" in workflow
> assert re.search(r"opencode-review-target:[\s\S]{0,240}timeout-minutes: 360", workflow)
E assert None
E + where None = <function search at 0x7fc7aec90220>('opencode-review-target:[\\s\\S]{0,240}timeout-minutes: 360', 'name: Required OpenCode Review\n\non:\n pull_request_target:\n types: [opened, synchronize, reopened, ready_for_r... The scheduled and PR-event scheduler paths remain authoritative.\\n\' "$GH_REPOSITORY" "$base_branch"\n fi\n')
E + where <function search at 0x7fc7aec90220> = re.search
tests/test_opencode_agent_contract.py:283: AssertionError
__________ test_merge_scheduler_uses_escalating_mutation_credentials ___________
def test_merge_scheduler_uses_escalating_mutation_credentials():
"""Guard immediate merge/update execution credentials for central scheduling."""
workflow = Path(".github/workflows/pr-review-merge-scheduler.yml").read_text(
encoding="utf-8"
)
assert "id-token: write" in workflow
assert "Exchange OpenCode app token for scheduler mutations" in workflow
assert "secrets.PR_REVIEW_MERGE_TOKEN" in workflow
assert "secrets.OPENCODE_APPROVE_TOKEN" in workflow
assert "steps.scheduler_app_token.outputs.token" in workflow
assert "SCHEDULER_READ_TOKEN: ${{ github.token }}" in workflow
assert "SCHEDULER_MUTATION_TOKEN_SOURCE" in workflow
> assert 'default: "-1"' in workflow
E assert 'default: "-1"' in 'name: Required PR Review Merge Scheduler\n\non:\n push:\n branches: [main, develop, master]\n pull_request_targe... args+=(--no-update-branches)\n fi\n python3 scripts/ci/pr_review_merge_scheduler.py "${args[@]}"\n'
tests/test_opencode_agent_contract.py:415: AssertionError
=============================== warnings summary ===============================
tests/test_assert_opencode_reasoning_effort.py::test_module_entrypoint_success
<frozen runpy>:128: RuntimeWarning: 'scripts.ci.assert_opencode_reasoning_effort' found in sys.modules after import of package 'scripts.ci', but prior to execution of 'scripts.ci.assert_opencode_reasoning_effort'; this may result in unpredictable behaviour
tests/test_render_opencode_prompt_template.py::test_module_entrypoint
<frozen runpy>:128: RuntimeWarning: 'scripts.ci.render_opencode_prompt_template' found in sys.modules after import of package 'scripts.ci', but prior to execution of 'scripts.ci.render_opencode_prompt_template'; this may result in unpredictable behaviour
tests/test_review_execution_contracts.py::test_discovers_package_managers_java_r_json_and_main
<frozen runpy>:128: RuntimeWarning: 'scripts.ci.review_execution_contracts' found in sys.modules after import of package 'scripts.ci', but prior to execution of 'scripts.ci.review_execution_contracts'; this may result in unpredictable behaviour
tests/test_sandboxed_verify.py::test_module_main_entrypoint
<frozen runpy>:128: RuntimeWarning: 'scripts.ci.sandboxed_verify' found in sys.modules after import of package 'scripts.ci', but prior to execution of 'scripts.ci.sandboxed_verify'; this may result in unpredictable behaviour
tests/test_sandboxed_web_e2e.py::test_module_import_and_main_entrypoint
<frozen runpy>:128: RuntimeWarning: 'scripts.ci.sandboxed_web_e2e' found in sys.modules after import of package 'scripts.ci', but prior to execution of 'scripts.ci.sandboxed_web_e2e'; this may result in unpredictable behaviour
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/test_noema_review_gate.py::test_call_llm_handles_configuration_and_verdicts - AssertionError: Regex pattern did not match.
Expected regex: 'must start with http:// or https://'
Actual message: 'URL scheme must be http or https'
FAILED tests/test_opencode_agent_contract.py::test_workflow_provisions_sandbox_tool_and_reviewer_agent - assert None
+ where None = <function search at 0x7fc7aec90220>('opencode-review-target:[\\s\\S]{0,240}timeout-minutes: 360', 'name: Required OpenCode Review\n\non:\n pull_request_target:\n types: [opened, synchronize, reopened, ready_for_r... The scheduled and PR-event scheduler paths remain authoritative.\\n\' "$GH_REPOSITORY" "$base_branch"\n fi\n')
+ where <function search at 0x7fc7aec90220> = re.search
FAILED tests/test_opencode_agent_contract.py::test_merge_scheduler_uses_escalating_mutation_credentials - assert 'default: "-1"' in 'name: Required PR Review Merge Scheduler\n\non:\n push:\n branches: [main, develop, master]\n pull_request_targe... args+=(--no-update-branches)\n fi\n python3 scripts/ci/pr_review_merge_scheduler.py "${args[@]}"\n'
================== 3 failed, 171 passed, 5 warnings in 5.68s ===================
- Result: FAIL (exit 1)
Python docstring coverage advisory
RESULT: PASSED (minimum: 100.0%, actual: 100.0%)
- Result: PASS
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow (2 files)"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow (2 files)"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file: bolt.md"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file: bolt.md"]
R2 --> V2["required checks"]
Evidence --> S3["CI script (4 files)"]
S3 --> I3["review and security gate shell path"]
I3 --> R3["Review risk: CI script (4 files)"]
R3 --> V3["bash -n plus Strix self-test"]
Evidence --> S4["Test (2 files)"]
S4 --> I4["regression suite"]
I4 --> R4["Review risk: Test (2 files)"]
R4 --> V4["targeted test run"]
Contributor
Author
|
Closing this as superseded/stale rather than rebasing it. Current evidence checked on the live PR:
I am not carrying this branch forward because it also carries stale central review workflow state that would undo newer governance changes: direct OpenAI provider wiring, current timeout/retry policy, Strix timeout bounds, and current scheduler defaults. The longer OpenCode timing / DeepSeek-v3 ordering discussion is being handled in the newer central review-policy PR instead of through this superseded duplicate. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What:
validate_opencode_failed_check_review.sh내부의 Python 코드에서 함수 내부에 인라인으로 사용되던 정규 표현식(re.sub,re.match,re.search)들을 모듈 레벨의re.compile객체로 추출하여 미리 컴파일되도록 변경했습니다.🎯 Why: 해당 파이썬 스크립트는 CI 로그 파일(수백~수천 줄에 달할 수 있음)을 한 줄씩 읽어 들이면서 파싱을 수행합니다. 루프의 각 단계에서
clean,starts_new_field,_parse_field등의 함수가 반복적으로 호출되는데, 기존 방식은 호출될 때마다 동일한 패턴의 정규식을 새로 해석/컴파일하는 오버헤드를 유발하고 있었습니다. 이를 방지하기 위한 코드베이스 특정 최적화 패턴입니다.📊 Impact: 각 라인 처리에 필요한 반복적인 정규식 컴파일 비용이 제거되어, 특히 방대한 CI 로그의
FAILED_CHECK_EVIDENCE_FILE를 처리할 때 스크립트 실행 시간이 향상됩니다.🔬 Measurement: 변경 사항은
scripts/ci/test_opencode_fact_gate_contract.sh등의 기존 팩트 게이트 계약 검증을 모두 성공적으로 통과하여 동작에 변화가 없음을 보장합니다.PR created automatically by Jules for task 6107382583812514709 started by @seonghobae