fix(opencode-review): keep model fallback inside runner budget#385
Closed
seonghobae wants to merge 6 commits into
Closed
fix(opencode-review): keep model fallback inside runner budget#385seonghobae wants to merge 6 commits into
seonghobae wants to merge 6 commits into
Conversation
…budget The Required OpenCode Review check timed out red on every gyeot PR (ContextualWisdomLab/gyeot #4, #5, #6 — including a one-file docs PR), so the model-pool step is structurally, not transiently, broken. Root cause (from the job logs): the 3-4 front-loaded mini models (o4-mini, gpt-5-mini, gpt-5-nano) each hang/rate-limit and are killed at the 90-min (5400s) per-model `timeout` (exit 124). Three hangs burn ~270 min before the pool can reach any high-quota fallback (deepseek/mistral/llama, candidates #6-11), so the 350-min hard step timeout kills the job first — opaquely, with no recorded review_status. Fix: - OPENCODE_RUN_TIMEOUT_SECONDS 5400 -> 1800 (30 min): still ample for a deep tool-using review (5x the 600s that was too short), but low enough that the full 13-candidate list is traversable inside the 350-min step even if every leading model hangs, so a responsive fallback is reached. - OPENCODE_TOTAL_RETRY_BUDGET_SECONDS 0 -> 20400 (340 min): a clean internal deadline 10 min under the step timeout. The pool already caps each run at min(run_timeout, deadline-now) and exits with an explicit "retry deadline elapsed" reason + recorded status, so a genuine exhaustion now prints its cause instead of GitHub's opaque "timed out after 350 minutes". Also updates the strix quick-gate assertions that pin these two values. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RTAMs4bpSZS77Xe3RQjv9P
Contributor
Author
auto-merge was automatically disabled
July 9, 2026 06:57
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The central OpenCode review workflow was timing out before it could independently complete review on larger repositories. That blocks downstream repositories such as ContextualWisdomLab/aFIPC from receiving required review approval through the central process.
Validation
scripts/ci/test_strix_quick_gate.shassertion updated to matchopencode-review.ymlubuntu-latestwas removed, so the PR should run on standard GitHub-hosted runners