Skip to content

๐ŸŽจ Palette: ContextSection ์ ‘๊ทผ์„ฑ ๊ฐœ์„  (aria-controls ์—ฐ๊ฒฐ ๋ฐ ์‹œ๊ฐ์  ํฌ์ปค์Šค)#111

Closed
seonghobae wants to merge 11 commits into
developmentalfrom
palette/context-section-a11y-6098934553673410577
Closed

๐ŸŽจ Palette: ContextSection ์ ‘๊ทผ์„ฑ ๊ฐœ์„  (aria-controls ์—ฐ๊ฒฐ ๋ฐ ์‹œ๊ฐ์  ํฌ์ปค์Šค)#111
seonghobae wants to merge 11 commits into
developmentalfrom
palette/context-section-a11y-6098934553673410577

Conversation

@seonghobae

Copy link
Copy Markdown

๐Ÿ’ก What: ContextSection ์ปดํฌ๋„ŒํŠธ์˜ ์ ‘๊ทผ์„ฑ์„ ํ–ฅ์ƒ์‹œ์ผฐ์Šต๋‹ˆ๋‹ค.

  • ํ† ๊ธ€ ๋ฒ„ํŠผ๊ณผ ๋‚ด๋ถ€ ์ฝ˜ํ…์ธ ๋ฅผ ์—ฐ๊ฒฐํ•˜๊ธฐ ์œ„ํ•ด aria-controls๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ๋…ธ์ด์ฆˆ๋ฅผ ์ค„์ด๊ธฐ ์œ„ํ•ด ํ† ๊ธ€ ์•„์ด์ฝ˜(ChevronUp, ChevronDown)์— aria-hidden="true"๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ํ‚ค๋ณด๋“œ ๋‚ด๋น„๊ฒŒ์ด์…˜ ์‚ฌ์šฉ์ž๋ฅผ ์œ„ํ•ด ๋ฒ„ํŠผ์— ๋ช…ํ™•ํ•œ focus-visible ์Šคํƒ€์ผ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐ŸŽฏ Why: ํ‚ค๋ณด๋“œ๋งŒ ์‚ฌ์šฉํ•˜์—ฌ ๋Œ€์‹œ๋ณด๋“œ๋ฅผ ํƒ์ƒ‰ํ•˜๋Š” ์‚ฌ์šฉ์ž๋“ค์—๊ฒŒ ํ˜„์žฌ ํฌ์ปค์Šค ์œ„์น˜๋ฅผ ๋ช…ํ™•ํžˆ ๋ณด์—ฌ์ฃผ๊ณ , ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž๊ฐ€ ํ•ด๋‹น ๋ฒ„ํŠผ์ด ์–ด๋–ค ์˜์—ญ์„ ์ œ์–ดํ•˜๋Š”์ง€ ๋ช…ํ™•ํ•˜๊ฒŒ ์ดํ•ดํ•  ์ˆ˜ ์žˆ๋„๋ก ํ•˜๊ธฐ ์œ„ํ•จ์ž…๋‹ˆ๋‹ค. ์ž‘์€ ๋””ํ…Œ์ผ์ด์ง€๋งŒ ๊ฒฝํ—˜์„ ํฌ๊ฒŒ ํ–ฅ์ƒ์‹œํ‚ต๋‹ˆ๋‹ค.

๐Ÿ“ธ Before/After: ์ถ”๊ฐ€๋œ Playwright ์‹œ๊ฐ ํ…Œ์ŠคํŠธ๋ฅผ ํ†ตํ•ด ํฌ์ปค์Šค ์‹œ ring-2 ํ…Œ๋‘๋ฆฌ๊ฐ€ ์ƒ๊ธฐ๋Š” ๊ฒƒ์„ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.

โ™ฟ Accessibility:

  • aria-controls
  • aria-hidden on decorative elements
  • focus-visible states

์ฐธ๊ณ : ํ•ด๋‹น ์ปดํฌ๋„ŒํŠธ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๋ฅผ ์ž‘์„ฑํ•˜๋ ค ํ•˜์˜€์œผ๋‚˜, ํ•ด๋‹น ํŒจํ‚ค์ง€์˜ vitest๊ฐ€ node ํ™˜๊ฒฝ์œผ๋กœ ์„ค์ •๋˜์–ด ์žˆ์–ด DOM ๋ Œ๋”๋ง ๊ธฐ๋ฐ˜ ํ…Œ์ŠคํŠธ(React Testing Library ๋“ฑ)๊ฐ€ ๋ถˆ๊ฐ€๋Šฅํ•จ์„ ํ™•์ธํ•˜์˜€์Šต๋‹ˆ๋‹ค.


PR created automatically by Jules for task 6098934553673410577 started by @seonghobae

seonghobae and others added 11 commits June 22, 2026 10:26
โ€ฆlicate calculation

`buildTimelineGroups` was calculated redundantly inside both `EventList` and `SessionActivityRibbon` inside `useMemo` hooks. This commit moves the `useMemo` computation into the parent `page.tsx` component and passes down `groups` as a prop to its children, preventing duplicate O(n) array iterations per `events` change.
Replace chained `.reduce()` and `Object.values()` with a single `for...of` loop over `Object.keys()` to avoid unnecessary intermediate array allocations and improve iteration performance during report aggregation.
overview-stats ์ปดํฌ๋„ŒํŠธ์˜ ์„ค๋ช… ํ…์ŠคํŠธ๋ฅผ ํŽผ์น˜๊ฑฐ๋‚˜ ์ ‘๋Š” ๋ฒ„ํŠผ์— ํ‚ค๋ณด๋“œ ํฌ์ปค์Šค ์Šคํƒ€์ผ์ด ๋ˆ„๋ฝ๋˜์–ด ์žˆ์–ด, ํ‚ค๋ณด๋“œ ๋‚ด๋น„๊ฒŒ์ด์…˜ ์‚ฌ์šฉ์ž์—๊ฒŒ ํ˜„์žฌ ํฌ์ปค์Šค ์œ„์น˜๋ฅผ ๋ช…ํ™•ํžˆ ๋ณด์—ฌ์ฃผ์ง€ ๋ชปํ•˜๋Š” ๋ฌธ์ œ๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

Tailwind CSS์˜ `focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring rounded-sm` ํด๋ž˜์Šค๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ํƒญ(Tab) ํ‚ค ์ด๋™ ์‹œ ํฌ์ปค์Šค ๋ง์ด ๋ณด์ด๋„๋ก ์ ‘๊ทผ์„ฑ์„ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
- `TokenUsageChart`์™€ `WeeklyFlowChart`์˜ ๋ฐ์ดํ„ฐ ๋ณ€ํ™˜ ๋กœ์ง์— `useMemo`๋ฅผ ์ ์šฉํ•˜์—ฌ ๋ถˆํ•„์š”ํ•œ ๋ฆฌ๋ Œ๋”๋ง ์ตœ์ ํ™”.
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings June 24, 2026 20:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the accessibility of the dashboard ContextSection disclosure by strengthening the relationship between the toggle button and its content, reducing screen-reader noise from decorative icons, and adding keyboard focus styling.

Changes:

  • Add aria-controls wiring via a generated id (useId).
  • Mark decorative chevron icons as aria-hidden="true".
  • Add focus-visible styles to the toggle button for clearer keyboard focus indication.

๐Ÿ’ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 37 to 41
{open && (
<div className="px-4 pb-4 pt-1">
<div id={contentId} className="px-4 pb-4 pt-1">
{children}
</div>
)}
Comment on lines 22 to 26
className={cn(
'w-full flex items-center justify-between px-4 py-3 text-left',
'hover:bg-card-elevated transition-colors',
'focus-visible:outline-none focus-visible:bg-card-elevated focus-visible:ring-2 focus-visible:ring-ring'
)}
Comment on lines +25 to +28
'focus-visible:outline-none focus-visible:bg-card-elevated focus-visible:ring-2 focus-visible:ring-ring'
)}
aria-expanded={open}
aria-controls={contentId}
@seonghobae

Copy link
Copy Markdown
Author

Closing as superseded during org-wide PR triage. Keeping #210 as the canonical PR for the same overlapping topic: ContextSection/accessibility accordion. This PR is stale/conflicted or has review blockers, so retaining one current PR reduces duplicated review and merge conflict work.

@seonghobae seonghobae closed this Jul 7, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded during org-wide PR triage. Keeping #210 as the canonical PR for the same overlapping topic: ContextSection/accessibility accordion. This PR is stale/conflicted or has review blockers, so retaining one current PR reduces duplicated review and merge conflict work.

Understood. Acknowledging that this work is now obsolete and superseded by PR #210, and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants