π¨ Palette: μ κ·Όμ± κ°μ μ μν ContextSection μμ #122
π¨ Palette: μ κ·Όμ± κ°μ μ μν ContextSection μμ #122seonghobae wants to merge 11 commits into
Conversation
β¦licate calculation `buildTimelineGroups` was calculated redundantly inside both `EventList` and `SessionActivityRibbon` inside `useMemo` hooks. This commit moves the `useMemo` computation into the parent `page.tsx` component and passes down `groups` as a prop to its children, preventing duplicate O(n) array iterations per `events` change.
Replace chained `.reduce()` and `Object.values()` with a single `for...of` loop over `Object.keys()` to avoid unnecessary intermediate array allocations and improve iteration performance during report aggregation.
overview-stats μ»΄ν¬λνΈμ μ€λͺ ν μ€νΈλ₯Ό νΌμΉκ±°λ μ λ λ²νΌμ ν€λ³΄λ ν¬μ»€μ€ μ€νμΌμ΄ λλ½λμ΄ μμ΄, ν€λ³΄λ λ΄λΉκ²μ΄μ μ¬μ©μμκ² νμ¬ ν¬μ»€μ€ μμΉλ₯Ό λͺ νν 보μ¬μ£Όμ§ λͺ»νλ λ¬Έμ λ₯Ό μμ νμ΅λλ€. Tailwind CSSμ `focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring rounded-sm` ν΄λμ€λ₯Ό μΆκ°νμ¬ ν(Tab) ν€ μ΄λ μ ν¬μ»€μ€ λ§μ΄ 보μ΄λλ‘ μ κ·Όμ±μ κ°μ νμ΅λλ€.
- `TokenUsageChart`μ `WeeklyFlowChart`μ λ°μ΄ν° λ³ν λ‘μ§μ `useMemo`λ₯Ό μ μ©νμ¬ λΆνμν 리λ λλ§ μ΅μ ν.
β¦y-improvements-7782421783208925042
β¦data-8534904799192449677
β¦tats-focus-1138085163110647654
β¦-loops-in-reports-11490543380196529130
β¦line-groups-memo-10280015208843955185
- Reactμ `useId()`λ₯Ό μ¬μ©νμ¬ `aria-controls`μ `id`λ₯Ό λμ μΌλ‘ λ°μΈλ©ν΄ μ¬λ¬ μΈμ€ν΄μ€ λ λλ§ μ λ°μνλ ID μΆ©λ λ¬Έμ ν΄κ²° - μκ°μ μν μ νλ ChevronUp/Down μμ΄μ½μ `aria-hidden="true"`λ₯Ό μΆκ°νμ¬ μ€ν¬λ¦° 리λ λ Έμ΄μ¦ μ κ±°
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
ContextSection μ»΄ν¬λνΈμ μ κ·Όμ±(A11y)μ κ°μ νκΈ° μν΄, ν κΈ λ²νΌκ³Ό μ½ν
μΈ μμ κ°μ μ°κ²°μ κ³ μ IDλ‘ λ§€ννκ³ (React useId()), μ₯μμ© μμ΄μ½μ μ€ν¬λ¦° 리λμμ μ¨κΈ°λλ‘ μμ ν PRμ
λλ€.
Changes:
useId()λ‘ μμ±ν λμ IDλ₯Όaria-controls/idμ μ°κ²°- Chevron μμ΄μ½μ
aria-hidden="true"μΆκ° - κ΄λ ¨ νμ΅ λ΄μ©μ
.Jules/palette.mdμ κΈ°λ‘
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web/src/components/dashboard/reports/context-section.tsx | useId() λ° aria-hiddenλ₯Ό ν΅ν΄ ν κΈ UIμ A11y μ°κ²°/λ
Έμ΄μ¦λ₯Ό κ°μ |
| .Jules/palette.md | ContextSection A11y κ°μ νμ΅/μ‘μ λ‘κ·Έ μΆκ° |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {open && ( | ||
| <div className="px-4 pb-4 pt-1"> | ||
| <div id={contentId} className="px-4 pb-4 pt-1"> | ||
| {children} | ||
| </div> | ||
| )} |
|
Closing as superseded during org-wide PR triage. Keeping #210 as the canonical PR for the same overlapping topic: ContextSection/accessibility accordion. This PR is stale/conflicted or has review blockers, so retaining one current PR reduces duplicated review and merge conflict work. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
π‘ What
ContextSectionμ»΄ν¬λνΈμ μ κ·Όμ±(A11y)μ ν₯μμμΌ°μ΅λλ€.useId()ν μ μ¬μ©νμ¬ ν κΈ λ²νΌ(aria-controls)κ³Ό μ½ν μΈ μ»¨ν μ΄λ(id) κ°μ κ³ μ νκ³ λμ μΈ ID 맀ν μ μ©<ChevronUp>λ°<ChevronDown>μμ΄μ½μaria-hidden="true"μμ± μΆκ°π― Why
aria-expandedμμ±μΌλ‘ μνλ₯Ό μλ €μ£Όκ³ μμΌλ―λ‘, λΆνμνκ² μ °λΈλ‘ μμ΄μ½μ μ€ν¬λ¦° 리λκ° μ½μ§ μλλ‘ νμ¬ μ¬μ©μ±μ κ°μ νμ΅λλ€.βΏ Accessibility
aria-hidden="true").PR created automatically by Jules for task 1948321501256679692 started by @seonghobae