π¨ Palette: DateRangePicker ν리μ λ²νΌ μ κ·Όμ± ν₯μ#139
π¨ Palette: DateRangePicker ν리μ
λ²νΌ μ κ·Όμ± ν₯μ#139seonghobae wants to merge 11 commits into
Conversation
β¦licate calculation `buildTimelineGroups` was calculated redundantly inside both `EventList` and `SessionActivityRibbon` inside `useMemo` hooks. This commit moves the `useMemo` computation into the parent `page.tsx` component and passes down `groups` as a prop to its children, preventing duplicate O(n) array iterations per `events` change.
Replace chained `.reduce()` and `Object.values()` with a single `for...of` loop over `Object.keys()` to avoid unnecessary intermediate array allocations and improve iteration performance during report aggregation.
overview-stats μ»΄ν¬λνΈμ μ€λͺ ν μ€νΈλ₯Ό νΌμΉκ±°λ μ λ λ²νΌμ ν€λ³΄λ ν¬μ»€μ€ μ€νμΌμ΄ λλ½λμ΄ μμ΄, ν€λ³΄λ λ΄λΉκ²μ΄μ μ¬μ©μμκ² νμ¬ ν¬μ»€μ€ μμΉλ₯Ό λͺ νν 보μ¬μ£Όμ§ λͺ»νλ λ¬Έμ λ₯Ό μμ νμ΅λλ€. Tailwind CSSμ `focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring rounded-sm` ν΄λμ€λ₯Ό μΆκ°νμ¬ ν(Tab) ν€ μ΄λ μ ν¬μ»€μ€ λ§μ΄ 보μ΄λλ‘ μ κ·Όμ±μ κ°μ νμ΅λλ€.
- `TokenUsageChart`μ `WeeklyFlowChart`μ λ°μ΄ν° λ³ν λ‘μ§μ `useMemo`λ₯Ό μ μ©νμ¬ λΆνμν 리λ λλ§ μ΅μ ν.
β¦y-improvements-7782421783208925042
β¦data-8534904799192449677
β¦tats-focus-1138085163110647654
β¦-loops-in-reports-11490543380196529130
β¦line-groups-memo-10280015208843955185
DateRangePickerμ ν리μ
λ²νΌ("7d", "30d" λ±)μ λν΄:
- ν€λ³΄λ λ΄λΉκ²μ΄μ
μ ν¬μ»€μ€κ° λͺ
νν 보μ΄λλ‘ `focus-visible` Tailwind ν΄λμ€ μΆκ°
- μ€ν¬λ¦° 리λ μ¬μ©μκ° νμ¬ μ νλ κΈ°κ°μ μ μ μλλ‘ `aria-pressed` μν μΆκ°
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing as superseded during org-wide PR triage. Keeping #213 as the canonical PR for the same overlapping topic: date range picker/accessibility. This PR is stale/conflicted or has review blockers, so retaining one current PR reduces duplicated review and merge conflict work. |
Understood. Acknowledging that this work is now superseded by #213 and stopping work on this task. |
1 participant
π‘ What: DateRangePicker μ»΄ν¬λνΈμ ν리μ λ²νΌλ€μ
aria-pressedμμ±μ μΆκ°νμ¬ μ ν μνλ₯Ό λͺ μνκ³ ,focus-visibleν΄λμ€λ₯Ό ν΅ν΄ ν€λ³΄λ ν¬μ»€μ€ μ€νμΌμ λΆμ¬νμ΅λλ€.π― Why: κΈ°μ‘΄μλ ν€λ³΄λ ν μ΄λ μ μ΄λ λ²νΌμ ν¬μ»€μ€κ° μλμ§ μκ°μ μΌλ‘ νμΈνκΈ° μ΄λ €μ μΌλ©°, μ€ν¬λ¦° 리λ μ¬μ©μκ° νμ¬ νμ±νλ μΈκ·Έλ¨ΌνΈλ₯Ό μ μ μμμ΅λλ€.
πΈ Before/After: ν΄λΉ μμ (μκ°μ κΈ°λ³Έ μν λ³ν μμ, ν¬μ»€μ€/μ€ν¬λ¦°λ¦¬λ κ°μ )
βΏ Accessibility:
aria-pressedλ₯Ό ν΅ν΄ μ€ν¬λ¦° 리λμ νμ¬ μ νλ λ²νΌ μν μ λ¬focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-1λ₯Ό ν΅ν΄ ν€λ³΄λ λ€λΉκ²μ΄μ μ ν¬μ»€μ€ κ°μμ± ν보PR created automatically by Jules for task 842548458957535016 started by @seonghobae