Skip to content

๐ŸŽจ Palette: [์ ‘๊ทผ์„ฑ ๊ฐœ์„ ] Context Section ํ‚ค๋ณด๋“œ ํฌ์ปค์Šค ๋ฐ ARIA ์ปจํŠธ๋กค ์ถ”๊ฐ€#156

Closed
seonghobae wants to merge 11 commits into
developmentalfrom
palette/context-section-accessibility-14035042064456707482
Closed

๐ŸŽจ Palette: [์ ‘๊ทผ์„ฑ ๊ฐœ์„ ] Context Section ํ‚ค๋ณด๋“œ ํฌ์ปค์Šค ๋ฐ ARIA ์ปจํŠธ๋กค ์ถ”๊ฐ€#156
seonghobae wants to merge 11 commits into
developmentalfrom
palette/context-section-accessibility-14035042064456707482

Conversation

@seonghobae

Copy link
Copy Markdown

๐Ÿ’ก What

ContextSection ์ปดํฌ๋„ŒํŠธ์˜ ์•„์ฝ”๋””์–ธ ํ† ๊ธ€ ๋ฒ„ํŠผ์— ํ‚ค๋ณด๋“œ ํฌ์ปค์Šค ๋ง(focus-visible ์†์„ฑ)์„ ์ถ”๊ฐ€ํ•˜๊ณ  useId()๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ aria-controls๋ฅผ ์—ฐ๊ฒฐํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ทธ๋ฆฌ๊ณ  ์ปดํฌ๋„ŒํŠธ์— ๋Œ€ํ•œ 100% ํ…Œ์ŠคํŠธ ์ปค๋ฒ„๋ฆฌ์ง€๋ฅผ ์ œ๊ณตํ•˜๋Š” ๋‹จ์œ„ ํ…Œ์ŠคํŠธ๋„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐ŸŽฏ Why

๊ธฐ์กด์˜ ํ† ๊ธ€ ๋ฒ„ํŠผ์—๋Š” ์‹œ๊ฐ์  ํ‚ค๋ณด๋“œ ํฌ์ปค์Šค๊ฐ€ ๋ˆ„๋ฝ๋˜์–ด, ํƒญ(Tab) ํ‚ค๋กœ ํƒ์ƒ‰ํ•  ๋•Œ ์‚ฌ์šฉ์ž๊ฐ€ ํฌ์ปค์Šค๋œ ์š”์†Œ๋ฅผ ์ธ์ง€ํ•˜๊ธฐ ์–ด๋ ค์› ์Šต๋‹ˆ๋‹ค. ๋”๋ถˆ์–ด ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž๋ฅผ ์œ„ํ•ด ํŠธ๋ฆฌ๊ฑฐ ๋ฒ„ํŠผ๊ณผ ์ œ์–ด๋˜๋Š” ์ฝ˜ํ…์ธ  ๋ธ”๋ก ๊ฐ„์˜ ์—ฐ๊ด€์„ฑ(aria-controls)์„ ๋ช…ํ™•ํžˆ ๋ช…์‹œํ•  ํ•„์š”๊ฐ€ ์žˆ์—ˆ์Šต๋‹ˆ๋‹ค. ๋งˆ์ง€๋ง‰์œผ๋กœ, ๋ณ€๊ฒฝ๋œ ์ฝ”๋“œ ๋ฐ ๊ธฐ๋Šฅ์ด ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ๋™์ž‘ํ•จ์„ ๋ณด์žฅํ•˜๊ธฐ ์œ„ํ•ด 100% ํ…Œ์ŠคํŠธ ์ปค๋ฒ„๋ฆฌ์ง€๋ฅผ ํ™•๋ณดํ•ด์•ผ ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ Before/After

(๋น„์ฃผ์–ผ ๋ณ€๊ฒฝ ์—†์Œ: ๊ธฐ์กด์ฒ˜๋Ÿผ ์ž‘๋™ํ•˜๋˜ ํƒญ ํฌ์ปค์‹ฑ ๋ฐ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์—์„œ๋งŒ ์ฐจ์ด๊ฐ€ ์žˆ์Œ)

โ™ฟ Accessibility

  • <button> ์š”์†Œ์— focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-inset์„ ์ถ”๊ฐ€ํ•˜์—ฌ ํ‚ค๋ณด๋“œ ํƒญ ์ด๋™ ์‹œ ๋ช…ํ™•ํ•œ ํฌ์ปค์Šค ํ‘œ์‹œ
  • useId()๋กœ ๊ณ ์œ  ID๋ฅผ ์ƒ์„ฑํ•ด <button>์˜ aria-controls์™€ ์ ‘ํžˆ๋Š” <div>์˜ id๋ฅผ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ๋งคํ•‘
  • ์ด๋Ÿฌํ•œ ๋ณ€๊ฒฝ ์‚ฌํ•ญ๊ณผ ์ ‘๊ทผ์„ฑ ์†์„ฑ ์ƒํƒœ๋ฅผ ๊ฒ€์ฆํ•˜๋Š” ํ…Œ์ŠคํŠธ ์ฝ”๋“œ(jsdom ๋ฐ @testing-library/react)๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ, ์ ‘๊ทผ์„ฑ์ด ์ง€์†์ ์œผ๋กœ ์œ ์ง€๋˜๋„๋ก ํšŒ๊ท€ ๋ฐฉ์ง€.

PR created automatically by Jules for task 14035042064456707482 started by @seonghobae

seonghobae and others added 11 commits June 22, 2026 10:26
โ€ฆlicate calculation

`buildTimelineGroups` was calculated redundantly inside both `EventList` and `SessionActivityRibbon` inside `useMemo` hooks. This commit moves the `useMemo` computation into the parent `page.tsx` component and passes down `groups` as a prop to its children, preventing duplicate O(n) array iterations per `events` change.
Replace chained `.reduce()` and `Object.values()` with a single `for...of` loop over `Object.keys()` to avoid unnecessary intermediate array allocations and improve iteration performance during report aggregation.
overview-stats ์ปดํฌ๋„ŒํŠธ์˜ ์„ค๋ช… ํ…์ŠคํŠธ๋ฅผ ํŽผ์น˜๊ฑฐ๋‚˜ ์ ‘๋Š” ๋ฒ„ํŠผ์— ํ‚ค๋ณด๋“œ ํฌ์ปค์Šค ์Šคํƒ€์ผ์ด ๋ˆ„๋ฝ๋˜์–ด ์žˆ์–ด, ํ‚ค๋ณด๋“œ ๋‚ด๋น„๊ฒŒ์ด์…˜ ์‚ฌ์šฉ์ž์—๊ฒŒ ํ˜„์žฌ ํฌ์ปค์Šค ์œ„์น˜๋ฅผ ๋ช…ํ™•ํžˆ ๋ณด์—ฌ์ฃผ์ง€ ๋ชปํ•˜๋Š” ๋ฌธ์ œ๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

Tailwind CSS์˜ `focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring rounded-sm` ํด๋ž˜์Šค๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ํƒญ(Tab) ํ‚ค ์ด๋™ ์‹œ ํฌ์ปค์Šค ๋ง์ด ๋ณด์ด๋„๋ก ์ ‘๊ทผ์„ฑ์„ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
- `TokenUsageChart`์™€ `WeeklyFlowChart`์˜ ๋ฐ์ดํ„ฐ ๋ณ€ํ™˜ ๋กœ์ง์— `useMemo`๋ฅผ ์ ์šฉํ•˜์—ฌ ๋ถˆํ•„์š”ํ•œ ๋ฆฌ๋ Œ๋”๋ง ์ตœ์ ํ™”.
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@seonghobae

Copy link
Copy Markdown
Author

Closing as superseded during org-wide PR triage. Keeping #210 as the canonical PR for the same overlapping topic: ContextSection/accessibility accordion. This PR is stale/conflicted or has review blockers, so retaining one current PR reduces duplicated review and merge conflict work.

@seonghobae seonghobae closed this Jul 7, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded during org-wide PR triage. Keeping #210 as the canonical PR for the same overlapping topic: ContextSection/accessibility accordion. This PR is stale/conflicted or has review blockers, so retaining one current PR reduces duplicated review and merge conflict work.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant