๐จ Palette: [์ ๊ทผ์ฑ ๊ฐ์ ] Context Section ํค๋ณด๋ ํฌ์ปค์ค ๋ฐ ARIA ์ปจํธ๋กค ์ถ๊ฐ#156
Conversation
โฆlicate calculation `buildTimelineGroups` was calculated redundantly inside both `EventList` and `SessionActivityRibbon` inside `useMemo` hooks. This commit moves the `useMemo` computation into the parent `page.tsx` component and passes down `groups` as a prop to its children, preventing duplicate O(n) array iterations per `events` change.
Replace chained `.reduce()` and `Object.values()` with a single `for...of` loop over `Object.keys()` to avoid unnecessary intermediate array allocations and improve iteration performance during report aggregation.
overview-stats ์ปดํฌ๋ํธ์ ์ค๋ช ํ ์คํธ๋ฅผ ํผ์น๊ฑฐ๋ ์ ๋ ๋ฒํผ์ ํค๋ณด๋ ํฌ์ปค์ค ์คํ์ผ์ด ๋๋ฝ๋์ด ์์ด, ํค๋ณด๋ ๋ด๋น๊ฒ์ด์ ์ฌ์ฉ์์๊ฒ ํ์ฌ ํฌ์ปค์ค ์์น๋ฅผ ๋ช ํํ ๋ณด์ฌ์ฃผ์ง ๋ชปํ๋ ๋ฌธ์ ๋ฅผ ์์ ํ์ต๋๋ค. Tailwind CSS์ `focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring rounded-sm` ํด๋์ค๋ฅผ ์ถ๊ฐํ์ฌ ํญ(Tab) ํค ์ด๋ ์ ํฌ์ปค์ค ๋ง์ด ๋ณด์ด๋๋ก ์ ๊ทผ์ฑ์ ๊ฐ์ ํ์ต๋๋ค.
- `TokenUsageChart`์ `WeeklyFlowChart`์ ๋ฐ์ดํฐ ๋ณํ ๋ก์ง์ `useMemo`๋ฅผ ์ ์ฉํ์ฌ ๋ถํ์ํ ๋ฆฌ๋ ๋๋ง ์ต์ ํ.
โฆy-improvements-7782421783208925042
โฆdata-8534904799192449677
โฆtats-focus-1138085163110647654
โฆ-loops-in-reports-11490543380196529130
โฆline-groups-memo-10280015208843955185
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing as superseded during org-wide PR triage. Keeping #210 as the canonical PR for the same overlapping topic: ContextSection/accessibility accordion. This PR is stale/conflicted or has review blockers, so retaining one current PR reduces duplicated review and merge conflict work. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
๐ก What
ContextSection์ปดํฌ๋ํธ์ ์์ฝ๋์ธ ํ ๊ธ ๋ฒํผ์ ํค๋ณด๋ ํฌ์ปค์ค ๋ง(focus-visible์์ฑ)์ ์ถ๊ฐํ๊ณuseId()๋ฅผ ์ฌ์ฉํ์ฌaria-controls๋ฅผ ์ฐ๊ฒฐํ์ต๋๋ค. ๊ทธ๋ฆฌ๊ณ ์ปดํฌ๋ํธ์ ๋ํ 100% ํ ์คํธ ์ปค๋ฒ๋ฆฌ์ง๋ฅผ ์ ๊ณตํ๋ ๋จ์ ํ ์คํธ๋ ์ถ๊ฐํ์ต๋๋ค.๐ฏ Why
๊ธฐ์กด์ ํ ๊ธ ๋ฒํผ์๋ ์๊ฐ์ ํค๋ณด๋ ํฌ์ปค์ค๊ฐ ๋๋ฝ๋์ด, ํญ(Tab) ํค๋ก ํ์ํ ๋ ์ฌ์ฉ์๊ฐ ํฌ์ปค์ค๋ ์์๋ฅผ ์ธ์งํ๊ธฐ ์ด๋ ค์ ์ต๋๋ค. ๋๋ถ์ด ์คํฌ๋ฆฐ ๋ฆฌ๋ ์ฌ์ฉ์๋ฅผ ์ํด ํธ๋ฆฌ๊ฑฐ ๋ฒํผ๊ณผ ์ ์ด๋๋ ์ฝํ ์ธ ๋ธ๋ก ๊ฐ์ ์ฐ๊ด์ฑ(
aria-controls)์ ๋ช ํํ ๋ช ์ํ ํ์๊ฐ ์์์ต๋๋ค. ๋ง์ง๋ง์ผ๋ก, ๋ณ๊ฒฝ๋ ์ฝ๋ ๋ฐ ๊ธฐ๋ฅ์ด ์ฌ๋ฐ๋ฅด๊ฒ ๋์ํจ์ ๋ณด์ฅํ๊ธฐ ์ํด 100% ํ ์คํธ ์ปค๋ฒ๋ฆฌ์ง๋ฅผ ํ๋ณดํด์ผ ํ์ต๋๋ค.๐ธ Before/After
(๋น์ฃผ์ผ ๋ณ๊ฒฝ ์์: ๊ธฐ์กด์ฒ๋ผ ์๋ํ๋ ํญ ํฌ์ปค์ฑ ๋ฐ ์คํฌ๋ฆฐ ๋ฆฌ๋์์๋ง ์ฐจ์ด๊ฐ ์์)
โฟ Accessibility
<button>์์์focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-inset์ ์ถ๊ฐํ์ฌ ํค๋ณด๋ ํญ ์ด๋ ์ ๋ช ํํ ํฌ์ปค์ค ํ์useId()๋ก ๊ณ ์ ID๋ฅผ ์์ฑํด<button>์aria-controls์ ์ ํ๋<div>์id๋ฅผ ์ฌ๋ฐ๋ฅด๊ฒ ๋งคํjsdom๋ฐ@testing-library/react)๋ฅผ ์ถ๊ฐํ์ฌ, ์ ๊ทผ์ฑ์ด ์ง์์ ์ผ๋ก ์ ์ง๋๋๋ก ํ๊ท ๋ฐฉ์ง.PR created automatically by Jules for task 14035042064456707482 started by @seonghobae