Skip to content

๐ŸŽจ Palette: ContextSection ์ปดํฌ๋„ŒํŠธ ํ‚ค๋ณด๋“œ ๋ฐ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์ ‘๊ทผ์„ฑ ๊ฐœ์„ #171

Closed
seonghobae wants to merge 12 commits into
developmentalfrom
feat/a11y-context-section-12633858587200634806
Closed

๐ŸŽจ Palette: ContextSection ์ปดํฌ๋„ŒํŠธ ํ‚ค๋ณด๋“œ ๋ฐ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์ ‘๊ทผ์„ฑ ๊ฐœ์„ #171
seonghobae wants to merge 12 commits into
developmentalfrom
feat/a11y-context-section-12633858587200634806

Conversation

@seonghobae

Copy link
Copy Markdown

๐Ÿ’ก What

ContextSection ์ปดํฌ๋„ŒํŠธ์˜ ์ ‘๊ทผ์„ฑ์„ ํ–ฅ์ƒ์‹œ์ผฐ์Šต๋‹ˆ๋‹ค. ํŽผ์นจ/์ ‘ํž˜ ํ† ๊ธ€ ๋ฒ„ํŠผ๊ณผ ๋‚ด๋ถ€ ์ฝ˜ํ…์ธ  ์š”์†Œ ๊ฐ„์˜ ๊ด€๊ณ„๋ฅผ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”๊ฐ€ ๋ช…ํ™•ํžˆ ์ธ์ง€ํ•  ์ˆ˜ ์žˆ๋„๋ก useId()์™€ aria-controls ์†์„ฑ์„ ํ™œ์šฉํ•ด ๋…ผ๋ฆฌ์ ์œผ๋กœ ์—ฐ๊ฒฐํ•˜๊ณ , ํ‚ค๋ณด๋“œ ๋‚ด๋น„๊ฒŒ์ด์…˜ ์‚ฌ์šฉ์ž(ํƒญ ํ‚ค ์ด๋™)๋ฅผ ์œ„ํ•œ ์‹œ๊ฐ์  ํฌ์ปค์Šค ํ”ผ๋“œ๋ฐฑ(focus-visible ์Šคํƒ€์ผ)์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐ŸŽฏ Why

๊ธฐ์กด ๊ตฌ์กฐ์—์„œ๋Š” ๋ฒ„ํŠผ๊ณผ ๋ณธ๋ฌธ ์˜์—ญ ๊ฐ„์˜ ๊ด€๊ณ„๊ฐ€ ๋ช…์‹œ๋˜์–ด ์žˆ์ง€ ์•Š์•„ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž๊ฐ€ ๊ตฌ์กฐ๋ฅผ ํŒŒ์•…ํ•˜๊ธฐ ์–ด๋ ค์› ์œผ๋ฉฐ, ๋งˆ์šฐ์Šค hover ์ด์™ธ์— ํ‚ค๋ณด๋“œ focus ์ƒํƒœ๋ฅผ ๋ณด์—ฌ์ฃผ๋Š” ์‹œ๊ฐ์  ํ”ผ๋“œ๋ฐฑ์ด ๋ˆ„๋ฝ๋˜์–ด ํ‚ค๋ณด๋“œ ์กฐ์ž‘ ์‚ฌ์šฉ์„ฑ ๊ฒฐํ•จ์ด ์žˆ์—ˆ์Šต๋‹ˆ๋‹ค. ์ด ์ž‘์—…์€ 50์ค„ ๋ฏธ๋งŒ์˜ ์ž‘์€ ๋ณ€๊ฒฝ์œผ๋กœ ์ฆ‰๊ฐ์ ์ธ ์‚ฌ์šฉ์„ฑ ๋ฐ ์ ‘๊ทผ์„ฑ ํ–ฅ์ƒ์„ ์ œ๊ณตํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“ธ Before/After

๋กœ์ปฌ ํ™˜๊ฒฝ์—์„œ Playwright๋กœ ๊ฒ€์ฆ ์‹œ ํƒญ ํ‚ค ์ด๋™์„ ํ†ตํ•ด ํ† ๊ธ€ ๋ฒ„ํŠผ์— ๋ช…ํ™•ํ•œ ํฌ์ปค์Šค ๋ง์ด ํ‘œ์‹œ๋˜๋ฉฐ ์›ํ™œํ•˜๊ฒŒ ์ŠคํŽ˜์ด์Šค/์—”ํ„ฐํ‚ค๋กœ ์กฐ์ž‘๋˜๋Š” ๊ฒƒ์„ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.

โ™ฟ Accessibility

  • useId๋ฅผ ์‚ฌ์šฉํ•œ ๊ณ ์œ  ID ์ƒ์„ฑ
  • <button>์— aria-controls ์ถ”๊ฐ€ ๋ฐ ์ฝ˜ํ…์ธ  ์˜์—ญ id์™€ ์—ฐ๊ฒฐ (์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์ง€์›)
  • focus-visible ์œ ํ‹ธ๋ฆฌํ‹ฐ๋ฅผ ์ ์šฉํ•˜์—ฌ ํฌ์ปค์Šค ๊ฐ€์‹œ์„ฑ ํ™•๋ณด (ํ‚ค๋ณด๋“œ ์ง€์›)

PR created automatically by Jules for task 12633858587200634806 started by @seonghobae

seonghobae and others added 11 commits June 22, 2026 10:26
โ€ฆlicate calculation

`buildTimelineGroups` was calculated redundantly inside both `EventList` and `SessionActivityRibbon` inside `useMemo` hooks. This commit moves the `useMemo` computation into the parent `page.tsx` component and passes down `groups` as a prop to its children, preventing duplicate O(n) array iterations per `events` change.
Replace chained `.reduce()` and `Object.values()` with a single `for...of` loop over `Object.keys()` to avoid unnecessary intermediate array allocations and improve iteration performance during report aggregation.
overview-stats ์ปดํฌ๋„ŒํŠธ์˜ ์„ค๋ช… ํ…์ŠคํŠธ๋ฅผ ํŽผ์น˜๊ฑฐ๋‚˜ ์ ‘๋Š” ๋ฒ„ํŠผ์— ํ‚ค๋ณด๋“œ ํฌ์ปค์Šค ์Šคํƒ€์ผ์ด ๋ˆ„๋ฝ๋˜์–ด ์žˆ์–ด, ํ‚ค๋ณด๋“œ ๋‚ด๋น„๊ฒŒ์ด์…˜ ์‚ฌ์šฉ์ž์—๊ฒŒ ํ˜„์žฌ ํฌ์ปค์Šค ์œ„์น˜๋ฅผ ๋ช…ํ™•ํžˆ ๋ณด์—ฌ์ฃผ์ง€ ๋ชปํ•˜๋Š” ๋ฌธ์ œ๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

Tailwind CSS์˜ `focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring rounded-sm` ํด๋ž˜์Šค๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ํƒญ(Tab) ํ‚ค ์ด๋™ ์‹œ ํฌ์ปค์Šค ๋ง์ด ๋ณด์ด๋„๋ก ์ ‘๊ทผ์„ฑ์„ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
- `TokenUsageChart`์™€ `WeeklyFlowChart`์˜ ๋ฐ์ดํ„ฐ ๋ณ€ํ™˜ ๋กœ์ง์— `useMemo`๋ฅผ ์ ์šฉํ•˜์—ฌ ๋ถˆํ•„์š”ํ•œ ๋ฆฌ๋ Œ๋”๋ง ์ตœ์ ํ™”.
ContextSection ์ปดํฌ๋„ŒํŠธ ๋‚ด ์•„์ฝ”๋””์–ธ ๋ฒ„ํŠผ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ :
- React์˜ `useId` ํ›…์„ ๋„์ž…ํ•˜์—ฌ ํ† ๊ธ€ ๋ฒ„ํŠผ๊ณผ ์ฝ˜ํ…์ธ  ์˜์—ญ์„ ๋™์ ์œผ๋กœ ์—ฐ๊ฒฐํ•˜๋Š” ๊ณ ์œ  ID ์ƒ์„ฑ
- ๋ฒ„ํŠผ์— `aria-controls` ์†์„ฑ์„ ๋ถ€์—ฌํ•˜๊ณ  ์ฝ˜ํ…์ธ  ์˜์—ญ์˜ `id`์™€ ๋งค์นญํ•˜์—ฌ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์—์„œ ๋…ผ๋ฆฌ์  ์—ฐ๊ฒฐ ์ œ๊ณต
- ํ‚ค๋ณด๋“œ ๋‚ด๋น„๊ฒŒ์ด์…˜ ์‚ฌ์šฉ์ž๊ฐ€ ํ˜„์žฌ ํฌ์ปค์Šค๋ฅผ ๋ช…ํ™•ํžˆ ์ธ์‹ํ•  ์ˆ˜ ์žˆ๋„๋ก `focus-visible` ๊ด€๋ จ ์œ ํ‹ธ๋ฆฌํ‹ฐ(`focus-visible:ring-2`, `focus-visible:ring-ring` ๋“ฑ) ์ถ”๊ฐ€
- ๊ด€๋ จ ํ•™์Šต ๋‚ด์šฉ์„ `.Jules/palette.md`์— ๊ธฐ๋ก
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@opencode-agent

opencode-agent Bot commented Jun 30, 2026

Copy link
Copy Markdown

OpenCode Review Overview

  • Head SHA: 5bede4728f1d0977529162d2e449e6536b7ddedb
  • Workflow run: 28480192534
  • Workflow attempt: 1
  • Gate result: CHECK_FAILED (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Check outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The OpenCode approval path reached an APPROVE control result while the separate coverage-evidence job result was failure.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, but leave the PR review unchanged for coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence.

  • Result: CHECK_FAILED

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 5bede4728f1d0977529162d2e449e6536b7ddedb.

  • Head SHA: 5bede4728f1d0977529162d2e449e6536b7ddedb

  • Workflow run: 28480192534

  • Workflow attempt: 1

Coverage evidence

Coverage Evidence

  • Head SHA: 5bede4728f1d0977529162d2e449e6536b7ddedb
  • Required test evidence: supported repository test suites must pass.
  • Required docstring evidence: repository-owned docstring gates must pass when configured; otherwise docstring coverage is advisory.

JavaScript/TypeScript dependencies (npm install)

npm warn deprecated glob@10.5.0: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me

added 209 packages, and audited 210 packages in 13s

65 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
  • Result: PASS

JavaScript/TypeScript docstring coverage

  • Result: PASS
  • Reason: package.json exists, but no check:python-docstrings, docstring:coverage, or docs:coverage script is defined; docstring coverage is advisory.

JavaScript/TypeScript test coverage

  • Result: FAIL
  • Reason: package.json exists, but no coverage or test script is defined.

Coverage Decision

  • Result: FAIL
  • Test evidence: not proven passing
  • Docstring evidence: not proven passing when configured
  • Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (8 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (8 files)"]
  R1 --> V1["required checks"]
Loading

ContextSection ์ปดํฌ๋„ŒํŠธ ๋‚ด ์•„์ฝ”๋””์–ธ ๋ฒ„ํŠผ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ :
- React์˜ `useId` ํ›…์„ ๋„์ž…ํ•˜์—ฌ ํ† ๊ธ€ ๋ฒ„ํŠผ๊ณผ ์ฝ˜ํ…์ธ  ์˜์—ญ์„ ๋™์ ์œผ๋กœ ์—ฐ๊ฒฐํ•˜๋Š” ๊ณ ์œ  ID ์ƒ์„ฑ
- ๋ฒ„ํŠผ์— `aria-controls` ์†์„ฑ์„ ๋ถ€์—ฌํ•˜๊ณ  ์ฝ˜ํ…์ธ  ์˜์—ญ์˜ `id`์™€ ๋งค์นญํ•˜์—ฌ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์—์„œ ๋…ผ๋ฆฌ์  ์—ฐ๊ฒฐ ์ œ๊ณต
- ํ‚ค๋ณด๋“œ ๋‚ด๋น„๊ฒŒ์ด์…˜ ์‚ฌ์šฉ์ž๊ฐ€ ํ˜„์žฌ ํฌ์ปค์Šค๋ฅผ ๋ช…ํ™•ํžˆ ์ธ์‹ํ•  ์ˆ˜ ์žˆ๋„๋ก `focus-visible` ๊ด€๋ จ ์œ ํ‹ธ๋ฆฌํ‹ฐ(`focus-visible:ring-2`, `focus-visible:ring-ring` ๋“ฑ) ์ถ”๊ฐ€
- ๊ด€๋ จ ํ•™์Šต ๋‚ด์šฉ์„ `.Jules/palette.md`์— ๊ธฐ๋ก
- ํ…Œ์ŠคํŠธ ์ปค๋ฒ„๋ฆฌ์ง€๋ฅผ ๊ฒ€์ฆํ•  ์ˆ˜ ์žˆ๋„๋ก `package.json` ํŒŒ์ผ๋“ค์— `"coverage": "vitest run --coverage"` ์Šคํฌ๋ฆฝํŠธ ์ถ”๊ฐ€ ๋ฐ `@vitest/coverage-v8` ํŒจํ‚ค์ง€ ์„ค์ •
@seonghobae

Copy link
Copy Markdown
Author

Closing as superseded during org-wide PR triage. Keeping #210 as the canonical PR for the same overlapping topic: ContextSection/accessibility accordion. This PR is stale/conflicted or has review blockers, so retaining one current PR reduces duplicated review and merge conflict work.

@seonghobae seonghobae closed this Jul 7, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded during org-wide PR triage. Keeping #210 as the canonical PR for the same overlapping topic: ContextSection/accessibility accordion. This PR is stale/conflicted or has review blockers, so retaining one current PR reduces duplicated review and merge conflict work.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant