๐จ Palette: ContextSection ์ปดํฌ๋ํธ ํค๋ณด๋ ๋ฐ ์คํฌ๋ฆฐ ๋ฆฌ๋ ์ ๊ทผ์ฑ ๊ฐ์ #171
๐จ Palette: ContextSection ์ปดํฌ๋ํธ ํค๋ณด๋ ๋ฐ ์คํฌ๋ฆฐ ๋ฆฌ๋ ์ ๊ทผ์ฑ ๊ฐ์ #171seonghobae wants to merge 12 commits into
Conversation
โฆlicate calculation `buildTimelineGroups` was calculated redundantly inside both `EventList` and `SessionActivityRibbon` inside `useMemo` hooks. This commit moves the `useMemo` computation into the parent `page.tsx` component and passes down `groups` as a prop to its children, preventing duplicate O(n) array iterations per `events` change.
Replace chained `.reduce()` and `Object.values()` with a single `for...of` loop over `Object.keys()` to avoid unnecessary intermediate array allocations and improve iteration performance during report aggregation.
overview-stats ์ปดํฌ๋ํธ์ ์ค๋ช ํ ์คํธ๋ฅผ ํผ์น๊ฑฐ๋ ์ ๋ ๋ฒํผ์ ํค๋ณด๋ ํฌ์ปค์ค ์คํ์ผ์ด ๋๋ฝ๋์ด ์์ด, ํค๋ณด๋ ๋ด๋น๊ฒ์ด์ ์ฌ์ฉ์์๊ฒ ํ์ฌ ํฌ์ปค์ค ์์น๋ฅผ ๋ช ํํ ๋ณด์ฌ์ฃผ์ง ๋ชปํ๋ ๋ฌธ์ ๋ฅผ ์์ ํ์ต๋๋ค. Tailwind CSS์ `focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring rounded-sm` ํด๋์ค๋ฅผ ์ถ๊ฐํ์ฌ ํญ(Tab) ํค ์ด๋ ์ ํฌ์ปค์ค ๋ง์ด ๋ณด์ด๋๋ก ์ ๊ทผ์ฑ์ ๊ฐ์ ํ์ต๋๋ค.
- `TokenUsageChart`์ `WeeklyFlowChart`์ ๋ฐ์ดํฐ ๋ณํ ๋ก์ง์ `useMemo`๋ฅผ ์ ์ฉํ์ฌ ๋ถํ์ํ ๋ฆฌ๋ ๋๋ง ์ต์ ํ.
โฆy-improvements-7782421783208925042
โฆdata-8534904799192449677
โฆtats-focus-1138085163110647654
โฆ-loops-in-reports-11490543380196529130
โฆline-groups-memo-10280015208843955185
ContextSection ์ปดํฌ๋ํธ ๋ด ์์ฝ๋์ธ ๋ฒํผ ์ ๊ทผ์ฑ ๊ฐ์ : - React์ `useId` ํ ์ ๋์ ํ์ฌ ํ ๊ธ ๋ฒํผ๊ณผ ์ฝํ ์ธ ์์ญ์ ๋์ ์ผ๋ก ์ฐ๊ฒฐํ๋ ๊ณ ์ ID ์์ฑ - ๋ฒํผ์ `aria-controls` ์์ฑ์ ๋ถ์ฌํ๊ณ ์ฝํ ์ธ ์์ญ์ `id`์ ๋งค์นญํ์ฌ ์คํฌ๋ฆฐ ๋ฆฌ๋์์ ๋ ผ๋ฆฌ์ ์ฐ๊ฒฐ ์ ๊ณต - ํค๋ณด๋ ๋ด๋น๊ฒ์ด์ ์ฌ์ฉ์๊ฐ ํ์ฌ ํฌ์ปค์ค๋ฅผ ๋ช ํํ ์ธ์ํ ์ ์๋๋ก `focus-visible` ๊ด๋ จ ์ ํธ๋ฆฌํฐ(`focus-visible:ring-2`, `focus-visible:ring-ring` ๋ฑ) ์ถ๊ฐ - ๊ด๋ จ ํ์ต ๋ด์ฉ์ `.Jules/palette.md`์ ๊ธฐ๋ก
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Check outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Evidence
JavaScript/TypeScript dependencies (npm install)
JavaScript/TypeScript docstring coverage
JavaScript/TypeScript test coverage
Coverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (8 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (8 files)"]
R1 --> V1["required checks"]
|
ContextSection ์ปดํฌ๋ํธ ๋ด ์์ฝ๋์ธ ๋ฒํผ ์ ๊ทผ์ฑ ๊ฐ์ : - React์ `useId` ํ ์ ๋์ ํ์ฌ ํ ๊ธ ๋ฒํผ๊ณผ ์ฝํ ์ธ ์์ญ์ ๋์ ์ผ๋ก ์ฐ๊ฒฐํ๋ ๊ณ ์ ID ์์ฑ - ๋ฒํผ์ `aria-controls` ์์ฑ์ ๋ถ์ฌํ๊ณ ์ฝํ ์ธ ์์ญ์ `id`์ ๋งค์นญํ์ฌ ์คํฌ๋ฆฐ ๋ฆฌ๋์์ ๋ ผ๋ฆฌ์ ์ฐ๊ฒฐ ์ ๊ณต - ํค๋ณด๋ ๋ด๋น๊ฒ์ด์ ์ฌ์ฉ์๊ฐ ํ์ฌ ํฌ์ปค์ค๋ฅผ ๋ช ํํ ์ธ์ํ ์ ์๋๋ก `focus-visible` ๊ด๋ จ ์ ํธ๋ฆฌํฐ(`focus-visible:ring-2`, `focus-visible:ring-ring` ๋ฑ) ์ถ๊ฐ - ๊ด๋ จ ํ์ต ๋ด์ฉ์ `.Jules/palette.md`์ ๊ธฐ๋ก - ํ ์คํธ ์ปค๋ฒ๋ฆฌ์ง๋ฅผ ๊ฒ์ฆํ ์ ์๋๋ก `package.json` ํ์ผ๋ค์ `"coverage": "vitest run --coverage"` ์คํฌ๋ฆฝํธ ์ถ๊ฐ ๋ฐ `@vitest/coverage-v8` ํจํค์ง ์ค์
|
Closing as superseded during org-wide PR triage. Keeping #210 as the canonical PR for the same overlapping topic: ContextSection/accessibility accordion. This PR is stale/conflicted or has review blockers, so retaining one current PR reduces duplicated review and merge conflict work. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
๐ก What
ContextSection์ปดํฌ๋ํธ์ ์ ๊ทผ์ฑ์ ํฅ์์์ผฐ์ต๋๋ค. ํผ์นจ/์ ํ ํ ๊ธ ๋ฒํผ๊ณผ ๋ด๋ถ ์ฝํ ์ธ ์์ ๊ฐ์ ๊ด๊ณ๋ฅผ ์คํฌ๋ฆฐ ๋ฆฌ๋๊ฐ ๋ช ํํ ์ธ์งํ ์ ์๋๋กuseId()์aria-controls์์ฑ์ ํ์ฉํด ๋ ผ๋ฆฌ์ ์ผ๋ก ์ฐ๊ฒฐํ๊ณ , ํค๋ณด๋ ๋ด๋น๊ฒ์ด์ ์ฌ์ฉ์(ํญ ํค ์ด๋)๋ฅผ ์ํ ์๊ฐ์ ํฌ์ปค์ค ํผ๋๋ฐฑ(focus-visible์คํ์ผ)์ ์ถ๊ฐํ์ต๋๋ค.๐ฏ Why
๊ธฐ์กด ๊ตฌ์กฐ์์๋ ๋ฒํผ๊ณผ ๋ณธ๋ฌธ ์์ญ ๊ฐ์ ๊ด๊ณ๊ฐ ๋ช ์๋์ด ์์ง ์์ ์คํฌ๋ฆฐ ๋ฆฌ๋ ์ฌ์ฉ์๊ฐ ๊ตฌ์กฐ๋ฅผ ํ์ ํ๊ธฐ ์ด๋ ค์ ์ผ๋ฉฐ, ๋ง์ฐ์ค hover ์ด์ธ์ ํค๋ณด๋ focus ์ํ๋ฅผ ๋ณด์ฌ์ฃผ๋ ์๊ฐ์ ํผ๋๋ฐฑ์ด ๋๋ฝ๋์ด ํค๋ณด๋ ์กฐ์ ์ฌ์ฉ์ฑ ๊ฒฐํจ์ด ์์์ต๋๋ค. ์ด ์์ ์ 50์ค ๋ฏธ๋ง์ ์์ ๋ณ๊ฒฝ์ผ๋ก ์ฆ๊ฐ์ ์ธ ์ฌ์ฉ์ฑ ๋ฐ ์ ๊ทผ์ฑ ํฅ์์ ์ ๊ณตํฉ๋๋ค.
๐ธ Before/After
๋ก์ปฌ ํ๊ฒฝ์์ Playwright๋ก ๊ฒ์ฆ ์ ํญ ํค ์ด๋์ ํตํด ํ ๊ธ ๋ฒํผ์ ๋ช ํํ ํฌ์ปค์ค ๋ง์ด ํ์๋๋ฉฐ ์ํํ๊ฒ ์คํ์ด์ค/์ํฐํค๋ก ์กฐ์๋๋ ๊ฒ์ ํ์ธํ์ต๋๋ค.
โฟ Accessibility
useId๋ฅผ ์ฌ์ฉํ ๊ณ ์ ID ์์ฑ<button>์aria-controls์ถ๊ฐ ๋ฐ ์ฝํ ์ธ ์์ญid์ ์ฐ๊ฒฐ (์คํฌ๋ฆฐ ๋ฆฌ๋ ์ง์)focus-visible์ ํธ๋ฆฌํฐ๋ฅผ ์ ์ฉํ์ฌ ํฌ์ปค์ค ๊ฐ์์ฑ ํ๋ณด (ํค๋ณด๋ ์ง์)PR created automatically by Jules for task 12633858587200634806 started by @seonghobae