π¨ Palette: [a11y] λ μ§ λ²μ μ νκΈ° μ κ·Όμ± κ°μ #183
π¨ Palette: [a11y] λ μ§ λ²μ μ νκΈ° μ κ·Όμ± κ°μ #183seonghobae wants to merge 14 commits into
Conversation
β¦licate calculation `buildTimelineGroups` was calculated redundantly inside both `EventList` and `SessionActivityRibbon` inside `useMemo` hooks. This commit moves the `useMemo` computation into the parent `page.tsx` component and passes down `groups` as a prop to its children, preventing duplicate O(n) array iterations per `events` change.
Replace chained `.reduce()` and `Object.values()` with a single `for...of` loop over `Object.keys()` to avoid unnecessary intermediate array allocations and improve iteration performance during report aggregation.
overview-stats μ»΄ν¬λνΈμ μ€λͺ ν μ€νΈλ₯Ό νΌμΉκ±°λ μ λ λ²νΌμ ν€λ³΄λ ν¬μ»€μ€ μ€νμΌμ΄ λλ½λμ΄ μμ΄, ν€λ³΄λ λ΄λΉκ²μ΄μ μ¬μ©μμκ² νμ¬ ν¬μ»€μ€ μμΉλ₯Ό λͺ νν 보μ¬μ£Όμ§ λͺ»νλ λ¬Έμ λ₯Ό μμ νμ΅λλ€. Tailwind CSSμ `focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring rounded-sm` ν΄λμ€λ₯Ό μΆκ°νμ¬ ν(Tab) ν€ μ΄λ μ ν¬μ»€μ€ λ§μ΄ 보μ΄λλ‘ μ κ·Όμ±μ κ°μ νμ΅λλ€.
- `TokenUsageChart`μ `WeeklyFlowChart`μ λ°μ΄ν° λ³ν λ‘μ§μ `useMemo`λ₯Ό μ μ©νμ¬ λΆνμν 리λ λλ§ μ΅μ ν.
β¦y-improvements-7782421783208925042
β¦data-8534904799192449677
β¦tats-focus-1138085163110647654
β¦-loops-in-reports-11490543380196529130
β¦line-groups-memo-10280015208843955185
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds accessibility improvements to the dashboard DateRangePicker presets and introduces React/jsdom-based Vitest setup plus a basic component test to validate the new a11y attributes and navigation behavior.
Changes:
- Add
role="group",aria-label,aria-pressed, andfocus-visiblering styling to the preset button group - Add a new
DateRangePickerReact test with Testing Library + jest-dom matchers - Update Vitest configuration to run in
jsdomand load a setup file; add required devDependencies
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web/vitest.setup.ts | Adds jest-dom matchers registration for Vitest assertions |
| packages/web/vitest.config.ts | Switches Vitest to jsdom, adds React plugin, and registers setup file + TSX tests |
| packages/web/src/components/dashboard/date-range-picker.tsx | Adds ARIA semantics and focus-visible styles to the preset controls |
| packages/web/src/components/dashboard/date-range-picker.test.tsx | Adds initial test coverage for preset rendering and navigation |
| packages/web/package.json | Adds Testing Library, jest-dom, jsdom, and Vite React plugin devDependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import { DateRangePicker } from './date-range-picker' | ||
| import { subDays, format } from 'date-fns' | ||
|
|
||
| const mockPush = vi.fn() |
| it('navigates when preset is clicked', () => { | ||
| render(<DateRangePicker />) | ||
|
|
||
| const button30d = screen.getByRole('button', { name: '30d' }) | ||
| fireEvent.click(button30d) | ||
|
|
||
| const today = new Date() | ||
| const from = format(subDays(today, 30), 'yyyy-MM-dd') | ||
| const to = format(today, 'yyyy-MM-dd') | ||
|
|
||
| expect(mockPush).toHaveBeenCalledWith(`?from=${from}&to=${to}`) | ||
| }) |
| <button | ||
| key={preset.days} | ||
| type="button" | ||
| onClick={() => handlePreset(preset.days)} | ||
| aria-pressed={activePreset === preset.days} | ||
| className={cn( |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head5b11fcbda8e15fa3da6e90636a5e39bd04c4f8df. -
Head SHA:
5b11fcbda8e15fa3da6e90636a5e39bd04c4f8df -
Workflow run: 28624583690
-
Workflow attempt: 1
Coverage evidence
Coverage Evidence
- Head SHA:
5b11fcbda8e15fa3da6e90636a5e39bd04c4f8df - Required test evidence: supported repository test suites must pass.
- Required docstring evidence: repository-owned docstring gates must pass when configured; otherwise docstring coverage is advisory.
JavaScript/TypeScript dependencies (npm install)
added 110 packages, and audited 111 packages in 6s
38 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
- Result: PASS
JavaScript/TypeScript docstring coverage
- Result: PASS
- Reason: package.json exists, but no check:python-docstrings, docstring:coverage, or docs:coverage script is defined; docstring coverage is advisory.
JavaScript/TypeScript test coverage
- Result: FAIL
- Reason: package.json exists, but no coverage or test script is defined.
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (6 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (6 files)"]
R1 --> V1["required checks"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Evidence
JavaScript/TypeScript dependencies (npm install)
JavaScript/TypeScript docstring coverage
JavaScript/TypeScript test coverage
Coverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (4 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (4 files)"]
R1 --> V1["required checks"]
|
β¦label="Log out of your account"` (or `Sign out of your account` in one case) to the logout buttons in `org-sidebar.tsx`, `org-header.tsx`, and `no-organization-state.tsx` to improve accessibility for screen reader users.
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head2132ebfb8374f67b0bba25a4d4dc50697f1ecb47. -
Head SHA:
2132ebfb8374f67b0bba25a4d4dc50697f1ecb47 -
Workflow run: 28635581653
-
Workflow attempt: 1
Coverage evidence
Coverage Evidence
- Head SHA:
2132ebfb8374f67b0bba25a4d4dc50697f1ecb47 - Required test evidence: supported repository test suites must pass.
- Required docstring evidence: repository-owned docstring gates must pass when configured; otherwise docstring coverage is advisory.
JavaScript/TypeScript dependencies (npm install)
added 110 packages, and audited 111 packages in 7s
38 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
- Result: PASS
JavaScript/TypeScript docstring coverage
- Result: PASS
- Reason: package.json exists, but no check:python-docstrings, docstring:coverage, or docs:coverage script is defined; docstring coverage is advisory.
JavaScript/TypeScript test coverage
- Result: FAIL
- Reason: package.json exists, but no coverage or test script is defined.
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (6 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (6 files)"]
R1 --> V1["required checks"]
β¦d `role=\"group\"` and `aria-label` to the container holding the date range preset buttons. Added `aria-pressed` state and `focus-visible` styles to the individual buttons to improve keyboard navigation and screen reader accessibility. Also added tests to ensure proper rendering and functionality.
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head3c1c689234f96fc6c814df02d1408ae514eb6190. -
Head SHA:
3c1c689234f96fc6c814df02d1408ae514eb6190 -
Workflow run: 28652468558
-
Workflow attempt: 1
Coverage evidence
Coverage Evidence
- Head SHA:
3c1c689234f96fc6c814df02d1408ae514eb6190 - Required test evidence: supported repository test suites must pass.
- Required docstring evidence: repository-owned docstring gates must pass when configured; otherwise docstring coverage is advisory.
JavaScript/TypeScript dependencies (npm install)
added 110 packages, and audited 111 packages in 7s
38 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
- Result: PASS
JavaScript/TypeScript docstring coverage
- Result: PASS
- Reason: package.json exists, but no check:python-docstrings, docstring:coverage, or docs:coverage script is defined; docstring coverage is advisory.
JavaScript/TypeScript test coverage
- Result: FAIL
- Reason: package.json exists, but no coverage or test script is defined.
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (4 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (4 files)"]
R1 --> V1["required checks"]
β¦st.setup.ts` to include `jest-dom` matchers for React component testing. Updated `DateRangePicker` tests to import `React` and use `getAllByRole` to fix ambiguous selector errors. Added `coverage/` to `.gitignore` to prevent coverage reports from polluting Git status.
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headc13ee0e0b0e8a1adbed75c7a9b09927d905dcfc0. -
Head SHA:
c13ee0e0b0e8a1adbed75c7a9b09927d905dcfc0 -
Workflow run: 28659183583
-
Workflow attempt: 1
Coverage evidence
Coverage Evidence
- Head SHA:
c13ee0e0b0e8a1adbed75c7a9b09927d905dcfc0 - Required test evidence: supported repository test suites must pass.
- Required docstring evidence: repository-owned docstring gates must pass when configured; otherwise docstring coverage is advisory.
JavaScript/TypeScript dependencies (npm install)
added 110 packages, and audited 111 packages in 6s
38 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
- Result: PASS
JavaScript/TypeScript docstring coverage
- Result: PASS
- Reason: package.json exists, but no check:python-docstrings, docstring:coverage, or docs:coverage script is defined; docstring coverage is advisory.
JavaScript/TypeScript test coverage
- Result: FAIL
- Reason: package.json exists, but no coverage or test script is defined.
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (4 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (4 files)"]
R1 --> V1["required checks"]
|
Closing as superseded during org-wide PR triage. Keeping #213 as the canonical PR for the same overlapping topic: date range picker/accessibility. This PR is stale/conflicted or has review blockers, so retaining one current PR reduces duplicated review and merge conflict work. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
π‘ What
λ μ§ λ²μ μ νκΈ° μ»΄ν¬λνΈμ μ κ·Όμ± κ°μ μ¬νμ μΆκ°νμ΅λλ€.
π― Why
μ€ν¬λ¦° 리λ μ¬μ©μ λ° ν€λ³΄λ λ€λΉκ²μ΄μ μ¬μ©μμ μ κ·Όμ±μ ν₯μμν€κΈ° μν΄ μ μ©νμμ΅λλ€.
βΏ Accessibility
divμμμrole="group"λ°aria-label="Date range presets"μμ±μ μΆκ°νμ¬ μ€ν¬λ¦° 리λ μ¬μ©μκ° ν΄λΉ μμμ λͺ©μ μ μ΄ν΄ν μ μλλ‘ κ°μ νμ΅λλ€.aria-pressedμμ±μ μΆκ°νμ¬ νμ¬ μ νλ μνλ₯Ό μ€ν¬λ¦° 리λμ λͺ νν μ λ¬νλλ‘ νμ΅λλ€.focus-visibleμνμ μ€νμΌμ μΆκ°νμ¬ ν€λ³΄λ λ€λΉκ²μ΄μ μ¬μ© μ νμ¬ ν¬μ»€μ€λ μμλ₯Ό μκ°μ μΌλ‘ μ½κ² μλ³ν μ μλλ‘ νμ΅λλ€.PR created automatically by Jules for task 4605723723398058267 started by @seonghobae