feat(viewer): env-configurable frame-ancestors on default profile (enables naruon embed)#103
Open
seonghobae wants to merge 2 commits into
Open
feat(viewer): env-configurable frame-ancestors on default profile (enables naruon embed)#103seonghobae wants to merge 2 commits into
seonghobae wants to merge 2 commits into
Conversation
The buyer-demo profile exposes CLEARFOLIO_FRAME_ANCESTORS, but the default
application.yml hard-coded 'self', so a production deployment on the default
profile could not allow the viewer to be embedded cross-origin. Mirror the
${CLEARFOLIO_FRAME_ANCESTORS:self} indirection so naruon can embed the /viewer
surface via config. Default stays 'self' — no behavior change when unset.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RkKdtHRLG4wSLh6PVsp8J
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RjGVapDZ3k7V7zKYk16P4C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
naruon will embed Clearfolio's
/viewer/{docId}in a sandboxed iframe.ViewerSecurityHeadersWebFilteralready readsviewer.security.frame-ancestorsand buyer-demo exposes${CLEARFOLIO_FRAME_ANCESTORS:self}, but the defaultapplication.ymlhard-codedself. This wires the same env indirection into the default profile so naruon (and other hosts) can allow cross-origin embedding viaCLEARFOLIO_FRAME_ANCESTORSwithout a profile switch. Default staysself(same-origin) when unset — no behavior change.mvn -DskipTests compileOK.🤖 Generated with Claude Code