Skip to content

๐ŸŽจ Palette: ์ƒˆ๋กœ๊ณ ์นจ ๋ฒ„ํŠผ ๋กœ๋”ฉ ์ƒํƒœ ๋ฐ ๋งํฌ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ #38

Closed
seonghobae wants to merge 3 commits into
mainfrom
palette/ux-refresh-a11y-12953156576872889856
Closed

๐ŸŽจ Palette: ์ƒˆ๋กœ๊ณ ์นจ ๋ฒ„ํŠผ ๋กœ๋”ฉ ์ƒํƒœ ๋ฐ ๋งํฌ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ #38
seonghobae wants to merge 3 commits into
mainfrom
palette/ux-refresh-a11y-12953156576872889856

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

๐Ÿ’ก What: ์ƒˆ๋กœ๊ณ ์นจ ๋ฒ„ํŠผ์— ๋Œ€ํ•œ ๋กœ๋”ฉ(disabled) ์ƒํƒœ ์ถ”๊ฐ€ ๋ฐ Open artifact ๋งํฌ์˜ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์ ‘๊ทผ์„ฑ ํ–ฅ์ƒ
๐ŸŽฏ Why: ์‚ฌ์šฉ์ž๊ฐ€ ๋ฐ์ดํ„ฐ๋ฅผ ๋ถˆ๋Ÿฌ์˜ค๋Š” ์ค‘ ์ค‘๋ณต ํด๋ฆญ์„ ๋ฐฉ์ง€ํ•˜์—ฌ ์ง๊ด€์ ์ธ ํ”ผ๋“œ๋ฐฑ์„ ์ œ๊ณตํ•˜๊ณ , ์™ธ๋ถ€ ์ฐฝ์œผ๋กœ ์—ด๋ฆฌ๋Š” ๋งํฌ์˜ ์šฉ๋„๋ฅผ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ํ™˜๊ฒฝ์— ๋ช…ํ™•ํ•˜๊ฒŒ ์ „๋‹ฌํ•˜๊ธฐ ์œ„ํ•จ์ž…๋‹ˆ๋‹ค.
๐Ÿ“ธ Before/After: (๋กœ์ปฌ ์Šคํฌ๋ฆฐ์ƒท ๋ฐ Playwright ๋™์˜์ƒ ์ฒจ๋ถ€ ์™„๋ฃŒ)
โ™ฟ Accessibility: aria-label ๋ฐ ํ‚ค๋ณด๋“œ/์‹œ๊ฐ์  :disabled ์Šคํƒ€์ผ๋ง ํ–ฅ์ƒ


PR created automatically by Jules for task 12953156576872889856 started by @seonghobae

- ๋ฐ์ดํ„ฐ๋ฅผ ๋ถˆ๋Ÿฌ์˜ค๋Š” ๋™์•ˆ ์ค‘๋ณต ํด๋ฆญ์„ ๋ฐฉ์ง€ํ•˜๊ธฐ ์œ„ํ•ด ์ƒˆ๋กœ๊ณ ์นจ ๋ฒ„ํŠผ(`el.retryBtn`)์— disabled ์ƒํƒœ ์ถ”๊ฐ€
- `viewer.css`์— ๊ธฐ์กด ํด๋ž˜์Šค๋ฅผ ์œ ์ง€ํ•˜๋ฉด์„œ `:disabled` ๋ฐ `:hover:not(:disabled)` ์ƒํƒœ๋ฅผ ํ†ตํ•œ ์‹œ๊ฐ์  ํ”ผ๋“œ๋ฐฑ ์ œ๊ณต
- ์™ธ๋ถ€ ํƒญ์œผ๋กœ ์—ด๋ฆฌ๋Š” artifact ๋งํฌ์— `target="_blank"` ๋ฐ `aria-label`์„ ์ถ”๊ฐ€ํ•˜์—ฌ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์ ‘๊ทผ์„ฑ ๊ฐœ์„ 
- ๋ชจ๋“  ๊ด€๋ จ ํ…Œ์ŠคํŠธ ๋ฐ ์ฝ”๋“œ ์Šคํƒ€์ผ(linter) ์ ๊ฒ€ ์™„๋ฃŒ
Copilot AI review requested due to automatic review settings June 27, 2026 21:15
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds clearer loading/disabled UX for the โ€œRefreshโ€ button during preview polling, and improves accessibility signaling for the โ€œOpen artifactโ€ link when it opens a new tab/window.

Changes:

  • Disable the refresh button while loading/polling and re-enable it on error/success.
  • Add target="_blank" plus an accessible label to the artifact link.
  • Update button hover/disabled styling using native :disabled / :not(:disabled) selectors (and document the design constraint in .Jules/palette.md).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/main/resources/static/assets/viewer/viewer.js Disables refresh during loading; adds new-tab behavior and screen-reader label for the artifact link.
src/main/resources/static/assets/viewer/viewer.css Prevents hover styling on disabled buttons and adds a disabled visual style.
.Jules/palette.md Documents the โ€œno new custom CSS classes for UI stateโ€ approach for disabled states.

๐Ÿ’ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main/resources/static/assets/viewer/viewer.js
Comment thread .Jules/palette.md
@opencode-agent

opencode-agent Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 50424fc5a94dc3ef1b23ff6391e29241fe356c27
  • Workflow run: 28302002520
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode reviewed the current-head evidence but found unresolved human review threads before approval.

Findings

1. HIGH .github/workflows/opencode-review.yml:1 - Unresolved human review thread blocks automated approval

  • Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human review thread evidence on the current pull request.
  • Root cause: Human review feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
  • Fix: Address or resolve the listed human review thread(s), then re-run OpenCode on the current head.
  • Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE.

Review thread evidence

Latest unresolved human review thread evidence

src/main/resources/static/assets/viewer/viewer.js line 77

.Jules/palette.md line 3

Change Flow DAG

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (3 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (3 files)"]
  R1 --> V1["required checks"]
Loading

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode reviewed the current-head evidence but found unresolved human review threads before approval.

Findings

1. HIGH .github/workflows/opencode-review.yml:1 - Unresolved human review thread blocks automated approval

  • Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human review thread evidence on the current pull request.
  • Root cause: Human review feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
  • Fix: Address or resolve the listed human review thread(s), then re-run OpenCode on the current head.
  • Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE.

Review thread evidence

Latest unresolved human review thread evidence

src/main/resources/static/assets/viewer/viewer.js line 77

  • Latest human comment: @copilot-pull-request-reviewer at 2026-06-27T21:16:50Z
  • Comment URL: #38 (comment)
  • Comment excerpt: For links opened with target="_blank", include "noreferrer" in rel to prevent leaking referrer data in browsers that donโ€™t honor the page-level referrer policy consistently, and to follow standard security guidance for external-tab links.

.Jules/palette.md line 3

  • Latest human comment: @copilot-pull-request-reviewer at 2026-06-27T21:16:50Z

  • Comment URL: #38 (comment)

  • Comment excerpt: In HTML, boolean attributes like "disabled" are enabled by presence; using disabled="true" in guidance can mislead readers into thinking disabled="false" would work. Recommend documenting the boolean form (disabled) instead.

  • Result: REQUEST_CHANGES

  • Reason: unresolved human review thread(s) were present before approval.

  • Head SHA: 50424fc5a94dc3ef1b23ff6391e29241fe356c27

  • Workflow run: 28302002520

  • Workflow attempt: 1

seonghobae and others added 2 commits June 29, 2026 01:17
- ๋ฐ์ดํ„ฐ๋ฅผ ๋ถˆ๋Ÿฌ์˜ค๋Š” ๋™์•ˆ ์ค‘๋ณต ํด๋ฆญ์„ ๋ฐฉ์ง€ํ•˜๊ธฐ ์œ„ํ•ด ์ƒˆ๋กœ๊ณ ์นจ ๋ฒ„ํŠผ(`el.retryBtn`)์— disabled ์ƒํƒœ ์ถ”๊ฐ€
- `viewer.css`์— ๊ธฐ์กด ํด๋ž˜์Šค๋ฅผ ์œ ์ง€ํ•˜๋ฉด์„œ `:disabled` ๋ฐ `:hover:not(:disabled)` ์ƒํƒœ๋ฅผ ํ†ตํ•œ ์‹œ๊ฐ์  ํ”ผ๋“œ๋ฐฑ ์ œ๊ณต
- ์™ธ๋ถ€ ํƒญ์œผ๋กœ ์—ด๋ฆฌ๋Š” artifact ๋งํฌ์— `target="_blank"` ๋ฐ `aria-label`์„ ์ถ”๊ฐ€ํ•˜์—ฌ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์ ‘๊ทผ์„ฑ ๊ฐœ์„ 
- ๋ชจ๋“  ๊ด€๋ จ ํ…Œ์ŠคํŠธ ๋ฐ ์ฝ”๋“œ ์Šคํƒ€์ผ(linter) ์ ๊ฒ€ ์™„๋ฃŒ
@seonghobae

Copy link
Copy Markdown
Collaborator Author

์ค‘๋ณต ์ •๋ฆฌ: ์ด PR์€ 'async ๋ฒ„ํŠผ ๋กœ๋”ฉ ์ƒํƒœ' ํด๋Ÿฌ์Šคํ„ฐ์˜ ์ค‘๋ณต์ž…๋‹ˆ๋‹ค. ์ •๋ณธ์œผ๋กœ #71 (APPROVED + CI green + MERGEABLE)์„ ์œ ์ง€ํ•ฉ๋‹ˆ๋‹ค. ๋™์ผ ํŒŒ์ผ์„ ์ˆ˜์ •ํ•ด ๋™์‹œ ๋ณ‘ํ•ฉ์ด ๋ถˆ๊ฐ€๋Šฅํ•˜๋ฏ€๋กœ ์ •๋ฆฌํ•ฉ๋‹ˆ๋‹ค. ๊ณ ์œ ํ•˜๊ฒŒ ํ•„์š”ํ•œ ๋ณ€๊ฒฝ์ด ์žˆ์œผ๋ฉด #71์— ๋ฐ˜์˜ํ•˜๊ฑฐ๋‚˜ ์žฌ์˜คํ”ˆํ•˜์„ธ์š”.

@seonghobae seonghobae closed this Jul 7, 2026
@google-labs-jules

Copy link
Copy Markdown

์ค‘๋ณต ์ •๋ฆฌ: ์ด PR์€ 'async ๋ฒ„ํŠผ ๋กœ๋”ฉ ์ƒํƒœ' ํด๋Ÿฌ์Šคํ„ฐ์˜ ์ค‘๋ณต์ž…๋‹ˆ๋‹ค. ์ •๋ณธ์œผ๋กœ #71 (APPROVED + CI green + MERGEABLE)์„ ์œ ์ง€ํ•ฉ๋‹ˆ๋‹ค. ๋™์ผ ํŒŒ์ผ์„ ์ˆ˜์ •ํ•ด ๋™์‹œ ๋ณ‘ํ•ฉ์ด ๋ถˆ๊ฐ€๋Šฅํ•˜๋ฏ€๋กœ ์ •๋ฆฌํ•ฉ๋‹ˆ๋‹ค. ๊ณ ์œ ํ•˜๊ฒŒ ํ•„์š”ํ•œ ๋ณ€๊ฒฝ์ด ์žˆ์œผ๋ฉด #71์— ๋ฐ˜์˜ํ•˜๊ฑฐ๋‚˜ ์žฌ์˜คํ”ˆํ•˜์„ธ์š”.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants