๐จ Palette: ์๋ก๊ณ ์นจ ๋ฒํผ ๋ก๋ฉ ์ํ ๋ฐ ๋งํฌ ์ ๊ทผ์ฑ ๊ฐ์ #38
๐จ Palette: ์๋ก๊ณ ์นจ ๋ฒํผ ๋ก๋ฉ ์ํ ๋ฐ ๋งํฌ ์ ๊ทผ์ฑ ๊ฐ์ #38seonghobae wants to merge 3 commits into
Conversation
- ๋ฐ์ดํฐ๋ฅผ ๋ถ๋ฌ์ค๋ ๋์ ์ค๋ณต ํด๋ฆญ์ ๋ฐฉ์งํ๊ธฐ ์ํด ์๋ก๊ณ ์นจ ๋ฒํผ(`el.retryBtn`)์ disabled ์ํ ์ถ๊ฐ - `viewer.css`์ ๊ธฐ์กด ํด๋์ค๋ฅผ ์ ์งํ๋ฉด์ `:disabled` ๋ฐ `:hover:not(:disabled)` ์ํ๋ฅผ ํตํ ์๊ฐ์ ํผ๋๋ฐฑ ์ ๊ณต - ์ธ๋ถ ํญ์ผ๋ก ์ด๋ฆฌ๋ artifact ๋งํฌ์ `target="_blank"` ๋ฐ `aria-label`์ ์ถ๊ฐํ์ฌ ์คํฌ๋ฆฐ ๋ฆฌ๋ ์ ๊ทผ์ฑ ๊ฐ์ - ๋ชจ๋ ๊ด๋ จ ํ ์คํธ ๋ฐ ์ฝ๋ ์คํ์ผ(linter) ์ ๊ฒ ์๋ฃ
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Adds clearer loading/disabled UX for the โRefreshโ button during preview polling, and improves accessibility signaling for the โOpen artifactโ link when it opens a new tab/window.
Changes:
- Disable the refresh button while loading/polling and re-enable it on error/success.
- Add
target="_blank"plus an accessible label to the artifact link. - Update button hover/disabled styling using native
:disabled/:not(:disabled)selectors (and document the design constraint in.Jules/palette.md).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/resources/static/assets/viewer/viewer.js | Disables refresh during loading; adds new-tab behavior and screen-reader label for the artifact link. |
| src/main/resources/static/assets/viewer/viewer.css | Prevents hover styling on disabled buttons and adds a disabled visual style. |
| .Jules/palette.md | Documents the โno new custom CSS classes for UI stateโ approach for disabled states. |
๐ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
OpenCode Review Overview
Pull request overviewOpenCode reviewed the current-head evidence but found unresolved human review threads before approval. Findings1. HIGH .github/workflows/opencode-review.yml:1 - Unresolved human review thread blocks automated approval
Review thread evidenceLatest unresolved human review thread evidence
|
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head evidence but found unresolved human review threads before approval.
Findings
1. HIGH .github/workflows/opencode-review.yml:1 - Unresolved human review thread blocks automated approval
- Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human review thread evidence on the current pull request.
- Root cause: Human review feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
- Fix: Address or resolve the listed human review thread(s), then re-run OpenCode on the current head.
- Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE.
Review thread evidence
Latest unresolved human review thread evidence
src/main/resources/static/assets/viewer/viewer.js line 77
- Latest human comment: @copilot-pull-request-reviewer at 2026-06-27T21:16:50Z
- Comment URL: #38 (comment)
- Comment excerpt: For links opened with target="_blank", include "noreferrer" in rel to prevent leaking referrer data in browsers that donโt honor the page-level referrer policy consistently, and to follow standard security guidance for external-tab links.
.Jules/palette.md line 3
-
Latest human comment: @copilot-pull-request-reviewer at 2026-06-27T21:16:50Z
-
Comment URL: #38 (comment)
-
Comment excerpt: In HTML, boolean attributes like "disabled" are enabled by presence; using disabled="true" in guidance can mislead readers into thinking disabled="false" would work. Recommend documenting the boolean form (disabled) instead.
-
Result: REQUEST_CHANGES
-
Reason: unresolved human review thread(s) were present before approval.
-
Head SHA:
50424fc5a94dc3ef1b23ff6391e29241fe356c27 -
Workflow run: 28302002520
-
Workflow attempt: 1
- ๋ฐ์ดํฐ๋ฅผ ๋ถ๋ฌ์ค๋ ๋์ ์ค๋ณต ํด๋ฆญ์ ๋ฐฉ์งํ๊ธฐ ์ํด ์๋ก๊ณ ์นจ ๋ฒํผ(`el.retryBtn`)์ disabled ์ํ ์ถ๊ฐ - `viewer.css`์ ๊ธฐ์กด ํด๋์ค๋ฅผ ์ ์งํ๋ฉด์ `:disabled` ๋ฐ `:hover:not(:disabled)` ์ํ๋ฅผ ํตํ ์๊ฐ์ ํผ๋๋ฐฑ ์ ๊ณต - ์ธ๋ถ ํญ์ผ๋ก ์ด๋ฆฌ๋ artifact ๋งํฌ์ `target="_blank"` ๋ฐ `aria-label`์ ์ถ๊ฐํ์ฌ ์คํฌ๋ฆฐ ๋ฆฌ๋ ์ ๊ทผ์ฑ ๊ฐ์ - ๋ชจ๋ ๊ด๋ จ ํ ์คํธ ๋ฐ ์ฝ๋ ์คํ์ผ(linter) ์ ๊ฒ ์๋ฃ
|
์ค๋ณต ์ ๋ฆฌ: ์ด PR์ 'async ๋ฒํผ ๋ก๋ฉ ์ํ' ํด๋ฌ์คํฐ์ ์ค๋ณต์ ๋๋ค. ์ ๋ณธ์ผ๋ก #71 (APPROVED + CI green + MERGEABLE)์ ์ ์งํฉ๋๋ค. ๋์ผ ํ์ผ์ ์์ ํด ๋์ ๋ณํฉ์ด ๋ถ๊ฐ๋ฅํ๋ฏ๋ก ์ ๋ฆฌํฉ๋๋ค. ๊ณ ์ ํ๊ฒ ํ์ํ ๋ณ๊ฒฝ์ด ์์ผ๋ฉด #71์ ๋ฐ์ํ๊ฑฐ๋ ์ฌ์คํํ์ธ์. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
๐ก What: ์๋ก๊ณ ์นจ ๋ฒํผ์ ๋ํ ๋ก๋ฉ(disabled) ์ํ ์ถ๊ฐ ๋ฐ Open artifact ๋งํฌ์ ์คํฌ๋ฆฐ ๋ฆฌ๋ ์ ๊ทผ์ฑ ํฅ์
๐ฏ Why: ์ฌ์ฉ์๊ฐ ๋ฐ์ดํฐ๋ฅผ ๋ถ๋ฌ์ค๋ ์ค ์ค๋ณต ํด๋ฆญ์ ๋ฐฉ์งํ์ฌ ์ง๊ด์ ์ธ ํผ๋๋ฐฑ์ ์ ๊ณตํ๊ณ , ์ธ๋ถ ์ฐฝ์ผ๋ก ์ด๋ฆฌ๋ ๋งํฌ์ ์ฉ๋๋ฅผ ์คํฌ๋ฆฐ ๋ฆฌ๋ ํ๊ฒฝ์ ๋ช ํํ๊ฒ ์ ๋ฌํ๊ธฐ ์ํจ์ ๋๋ค.
๐ธ Before/After: (๋ก์ปฌ ์คํฌ๋ฆฐ์ท ๋ฐ Playwright ๋์์ ์ฒจ๋ถ ์๋ฃ)
โฟ Accessibility:
aria-label๋ฐ ํค๋ณด๋/์๊ฐ์ :disabled์คํ์ผ๋ง ํฅ์PR created automatically by Jules for task 12953156576872889856 started by @seonghobae