๐ก๏ธ Sentinel: [MEDIUM] Fix XSS Vulnerability in HTML Template#50
๐ก๏ธ Sentinel: [MEDIUM] Fix XSS Vulnerability in HTML Template#50seonghobae wants to merge 1 commit into
Conversation
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
์ ๋ฆฌ(์ค๋ณต): ์ด PR์ด ๋ค๋ฃจ๋ ViewerUiController์ HTML ํ ํ๋ฆฟ XSS๋ #105(fix: friendly viewer shell for non-UUID docIds)์์ escapeHtmlAttribute๋ก ๋์ผ ํ์ผ์ ๋ํด ์์ ๋๋ฉฐ, #105๋ mvn verify ํต๊ณผยทmergeable ์ํ์ ๋ฅ๋ ์์ ๋ณธ์ ๋๋ค. ๋ณธ ๋ธ๋์น๋ DIRTY(๋ณํฉ ๋ถ๊ฐ)ยท8์ผ ์ ์ฒด์ด๋ฏ๋ก #105๋ก ๋์ฒดํ์ฌ ๋ซ์ต๋๋ค. ์ฃผ์: ์ค์ ์์ ์ #105๊ฐ ๋ด๋ณดํ๋ฏ๋ก #105๊ฐ ๋ณํฉ๋์ง ์์ผ๋ฉด ๋ณธ PR์ ์ฌ์คํํด์ผ ํฉ๋๋ค. |
Pull request was closed
Understood. Acknowledging that this work is now obsolete and stopping work on this task. This branch is being closed in favor of #105. |
๐จ Severity: MEDIUM
๐ก Vulnerability: ์ธ๋ผ์ธ HTML ํ ํ๋ฆฟ์ ๋ฌธ์์ด ์นํ ์ HTML ์ด์ค์ผ์ดํ๊ฐ ๋๋ฝ๋์ด ์์ด, ์ ์ฌ์ ์ธ XSS ์ทจ์ฝ์ ์ด ์กด์ฌํ์ต๋๋ค.
๐ฏ Impact: ํฅํ ์ ๋ ฅ๊ฐ์ด ์ฌ์ฉ์ ์ ์ด๊ฐ์ผ๋ก ๋ณ๊ฒฝ๋ ๊ฒฝ์ฐ XSS ๊ณต๊ฒฉ์ ์ ์ฉ๋ ์ ์์ต๋๋ค.
๐ง Fix: HTML ์ด์ค์ผ์ดํ ํจ์(
escapeHtml)๋ฅผ ๊ตฌํํ๊ณ , ํ ํ๋ฆฟ ๋ณ์๋ฅผ ์นํํ๊ธฐ ์ ์ ์ด๋ฅผ ์ ์ฉํ์ฌ ๋ฐฉ์ด ๊ณ์ธต์ ์ถ๊ฐํ์ต๋๋ค. Checkstyle ๊ท์น(final์์ฝ์ด)๊ณผ 100% ํ ์คํธ ์ปค๋ฒ๋ฆฌ์ง ์กฐ๊ฑด์ ๋ชจ๋ ๋ง์กฑ์์ผฐ์ต๋๋ค.โ Verification:
mvn test๋ช ๋ น์ ํตํด ๋ชจ๋ ํ ์คํธ๋ฅผ ํต๊ณผํจ์ ํ์ธํ์ต๋๋ค.PR created automatically by Jules for task 4303989212986322044 started by @seonghobae