π¨ Palette: ν리μ λ²νΌ νμ±ν μν(active state) μκ° νΌλλ°± μΆκ°#206
π¨ Palette: ν리μ
λ²νΌ νμ±ν μν(active state) μκ° νΌλλ°± μΆκ°#206seonghobae wants to merge 1 commit into
Conversation
- `saas_web.py` λ΄ νμΌ ν¬κΈ° ν리μ λ²νΌμ λμ μΌλ‘ `aria-pressed` μμ±μ ν κΈνλ λ‘μ§ μΆκ° - μ¬μ©μκ° λ²νΌμ ν΄λ¦νκ±°λ `target_bytes` μ λ ₯λμ μ§μ κ°μ κ°μ μ λ ₯ν κ²½μ°, ν΄λΉ λ²νΌμ΄ λλ €μ§ κ²μ²λΌ μκ°μ μΌλ‘ νμλλλ‘ `[aria-pressed="true"]` CSS μΆκ° - λ°λ³΅μ μΈ μΏΌλ¦¬λ₯Ό νΌνκΈ° μν΄ μ΄λ²€νΈ 리μ€λ μΈλΆμ ν리μ λ²νΌ μμλ€μ μΊμ±νμ¬ UI μ±λ₯ κ°μ
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Understood. Acknowledging that this work is a duplicate and stopping work on this task. |
π‘ What
target_bytesλ₯Ό λΉ λ₯΄κ² μ λ ₯ν μ μλλ‘ λλ ν리μ λ²νΌλ€("25 MiB", "100 MiB" λ±)μ νμ±ν(active) μν μκ° νΌλλ°±κ³Όaria-pressedμ κ·Όμ± μμ±μ μΆκ°νμ΅λλ€.π― Why
μ΄μ μλ ν리μ λ²νΌμ ν΄λ¦νλλΌλ νμ¬ μ΄λ€ ν리μ κ°μ΄ μ μ©λμ΄ μλμ§ μκ°μ μΌλ‘ μ μ μμ΄ μ¬μ©μμκ² λΆνμ€μ±μ μ£Όμμ΅λλ€. κ°μ νμλ νμ¬ μ λ ₯κ°κ³Ό μΌμΉνλ ν리μ λ²νΌμ΄ λμ μΌλ‘ νμ±ν(λλ¦Ό μν)λμ΄, μ¬μ©μκ° μ¦κ°μ μΈ μν νμΈμ ν μ μκ² λμμ΅λλ€. μ§μ μ λ ₯ μμλ λμΌνκ² μλν©λλ€.
πΈ Before/After
μμ λ UIμμλ μ λ ₯κ°κ³Ό μΌμΉνλ λ²νΌμ΄ νμ λ°°κ²½κ³Ό λ΄λΆ κ·Έλ¦Όμ(inset shadow)λ₯Ό ν΅ν΄ μκ°μ μΌλ‘ λλ ·νκ² κ΅¬λ³λ©λλ€.
βΏ Accessibility
λμ μΌλ‘ μ λ°μ΄νΈλλ
aria-pressedμνλ₯Ό ν΅ν΄ μ€ν¬λ¦° 리λ μ¬μ©μ λν νμ¬ μ νλ λ²νΌμ μνλ₯Ό λͺ ννκ² μ μ μλλ‘ μ κ·Όμ±μ κ°μ νμμ΅λλ€.PR created automatically by Jules for task 18002702006988419411 started by @seonghobae