ci: add least-privilege GITHUB_TOKEN permissions to CI workflow#121
Closed
seonghobae wants to merge 1 commit into
Closed
ci: add least-privilege GITHUB_TOKEN permissions to CI workflow#121seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves CodeQL
actions/missing-workflow-permissionsalerts #16, #17, #18 (CWE-275) on.github/workflows/ci.yml.Root cause
The CI workflow defined no
permissionsblock, so all three jobs (python,rust,package) inherited the repository/org default GITHUB_TOKEN scopes. For repos/orgs created before Feb 2023 the default is read-write, violating least privilege.Fix
Added a top-level
permissions: contents: readblock. All three jobs onlyactions/checkoutthe repo and run build/test steps (pytest, cargo test, python -m build, twine check, smoke scripts) — none push commits, comments, packages, or releases, so read-onlycontentsis sufficient for every job.No workflow thresholds or steps were weakened.