feat(data-ui): data domain local nav as left LNB sidebar (shell parity)#944
Open
seonghobae wants to merge 1 commit into
Open
feat(data-ui): data domain local nav as left LNB sidebar (shell parity)#944seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
The canonical shell (docs/ui-ux/naruon-ui-ux-mapping.md §4.1, mockup_04/19) is top GNB (global) + left LOCAL LNB (current domain's areas) + work area. Data rendered its local areas (문서 저장소/수집 파이프라인/임베딩/품질 점검) as a horizontal top-tab strip instead of the designed left sidebar. - Desktop (lg+): a left <nav aria-label='데이터 로컬 탐색'> sidebar with the domain title + the four areas as vertical nav buttons (aria-current active). - Mobile (<lg): the LNB collapses to the existing horizontal tab strip, so small screens are unchanged. - Areas hoisted to a single DATA_TABS const; activeTab typed from it. Verified: data page tests pass, tsc + eslint clean, and a 1440px runtime capture shows GNB + left LNB + content. First of the per-domain LNB conversions (Calendar already has a left sidebar). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RkKdtHRLG4wSLh6PVsp8J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Canonical Naruon shell (
docs/ui-ux/naruon-ui-ux-mapping.md§4.1 +mockup_04/mockup_19) = top GNB (global) + left LOCAL LNB (current domain's folders/areas) + work area + evidence panel.DataLayoutrendered its local areas (문서 저장소/수집 파이프라인/임베딩/품질 점검) as a horizontal top-tab strip, diverging from the designed left sidebar.What
<nav aria-label="데이터 로컬 탐색">sidebar — domain title + four areas as vertical nav buttons (aria-currentactive), permockup_04.DATA_TABSconst;activeTabtyped from it.Verification (local)
src/app/data/page.test.tsx: passed (tab-switch finds first matching button = the LNB button → still drivessetActiveTab).tscclean,eslintclean.Scope
First per-domain LNB conversion. Mail / Security / Settings / AI Hub / Projects / Tasks follow the same pattern (Calendar already has a left sidebar). Figma canonical shell reflected on the design file (Workspace Shell, node 84:91).
🤖 Generated with Claude Code