Test script for validating XML and badge in the README#132
Open
rbturnbull wants to merge 1 commit intoCopticScriptorium:masterfrom
Open
Test script for validating XML and badge in the README#132rbturnbull wants to merge 1 commit intoCopticScriptorium:masterfrom
rbturnbull wants to merge 1 commit intoCopticScriptorium:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In issue #130 I mentioned that there were XML files that are not valid. I've created a script to count the valid ones:
./tests/test_valid_xml.shThis creates an SVG badge showing the percentage of valid XML files
tests/xml_validation_badge.svgThis badge is displayed in the README
I've added a GitHub Actions workflow to run the script every push to master and it updates the badge.
At the moment, I'm only validating whether it is proper XML. Later on, we can add something else to determine if the XML is valid TEI.