You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Failed, existing baseline: npm run typecheck reports unrelated missing symbols/properties such as recordRequest, maintenanceModeGuard, metricsRouter, dashboardSummaryService, and log.
Failed, existing baseline: npm run lint reports unrelated existing lint errors in src/app.ts, repository tests, metrics tests, PostgresTransactionRepository.ts, and dashboard summary tests.
Failed, existing baseline: npm test reports 32 failing tests unrelated to this branch, including maintenanceModeGuard is not defined, log is not defined, and existing credit/repository expectation drift.
CI note: the fork push workflow is failing during the existing \
pm run typecheck\ step before this PR's OpenAPI drift gate is exercised. The logged errors are from pre-existing baseline symbols/typing issues such as \
ecordRequest\, \maintenanceModeGuard\, \dashboardSummaryService\, and \log\ in unrelated files. The PR-specific validation passes locally with \
pm run validate:openapi\ (spec validation plus the new route drift checker).
Same pre-existing npm run typecheck baseline as #270 (27 errors, all in src/**/*.ts files this PR does not touch).
This PR's own content — the OpenAPI drift gate (scripts/check-openapi-drift.mjs), CI workflow updates, and OPENAPI.md — is unrelated to the typecheck failures. The drift gate itself passes locally (node scripts/check-openapi-drift.mjs).
The typecheck baseline fix belongs in a shared separate PR (see #270 for the full error list). This PR can be reviewed on its own merits.
The pre-existing TypeScript baseline errors blocking CI have been fixed in #271 (fix/baseline-typescript-errors). Once that merges, this PR's CI should pass cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/check-openapi-drift.mjsto compare mounted Express route operations withsrc/openapi.yaml.openapi:driftandvalidate:openapiscripts, then wire the combined validation into both CI workflows.OPENAPI.mdandCONTRIBUTING.md.src/openapi.yamlfor existing mounted routes that were missing from the spec: credit draw, credit repay, and risk admin recalibration.Closes #203
Validation
npm cinpm run validate:openapinpm run typecheckreports unrelated missing symbols/properties such asrecordRequest,maintenanceModeGuard,metricsRouter,dashboardSummaryService, andlog.npm run lintreports unrelated existing lint errors insrc/app.ts, repository tests, metrics tests,PostgresTransactionRepository.ts, and dashboard summary tests.npm testreports 32 failing tests unrelated to this branch, includingmaintenanceModeGuard is not defined,log is not defined, and existing credit/repository expectation drift.