feat(api): add idempotency middleware for POST mutations#272
Open
220nightmore-spec wants to merge 1 commit into
Open
feat(api): add idempotency middleware for POST mutations#272220nightmore-spec wants to merge 1 commit into
220nightmore-spec wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #179.
Idempotency-Keymiddleware for POST mutations with route/principal/request-body scopingidempotency_keysmigrationSecurity notes
409 Conflict409+Retry-Afterfor in-flight duplicates across instances to avoid duplicate mutation executionValidation
vitest run src/middleware/__tests__/idempotency.test.ts --pool=forks --maxWorkers=1eslint src/middleware/idempotency.ts src/services/idempotencyStore.ts src/middleware/__tests__/idempotency.test.tsnode --input-type=module -e "import fs from 'node:fs'; import yaml from 'yaml'; yaml.parse(fs.readFileSync('src/openapi.yaml', 'utf8')); console.log('OpenAPI spec valid');"git diff --checktsc --noEmit --pretty falseis currently blocked by existing unrelated repo errors in files such assrc/app.ts,src/container/Container.ts,src/middleware/requestLogger.ts,src/routes/creditBulk.ts,src/routes/simulation.ts, andsrc/services/drawWebhookService.ts; no idempotency files were reported in that failure list.