Add durable outbound webhook dispatcher#276
Open
220nightmore-spec wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #182.
Summary
GET /api/webhooks/subscriptionsGET /api/webhooks/deliveriesPOST /api/webhooks/deliveries/:id/replayValidation
node node_modules/vitest/vitest.mjs run src/services/__tests__/outboundWebhookDispatcher.test.ts src/db/validate-schema.test.tsnode node_modules/eslint/bin/eslint.js src/services/outboundWebhookStore.ts src/services/outboundWebhookDispatcher.ts src/services/__tests__/outboundWebhookDispatcher.test.ts src/container/Container.ts src/routes/webhook.ts src/db/migrations.ts src/db/validate-schema.ts src/db/validate-schema.test.tsnode --input-type=module -e "import fs from 'node:fs'; import yaml from 'yaml'; yaml.parse(fs.readFileSync('src/openapi.yaml','utf8')); yaml.parse(fs.readFileSync('openapi.yaml','utf8')); console.log('OpenAPI specs valid');"git diff --checkFull
tsc --noEmit --pretty falsestill fails on existing main-branch issues insrc/app.ts,src/middleware/requestLogger.ts,src/routes/creditBulk.ts,src/routes/simulation.ts, legacysrc/services/drawWebhookService.tsmissinglog, and existing route/container test typing. The touched files passed targeted ESLint and focused tests.Security notes
Webhook secrets are never persisted. Subscriptions store only
secret_ref(WEBHOOK_SECRET), and delivery rows store signed payload metadata/status for operator inspection and replay.