Conversation
Offloaded blocking `sysinfo` refresh methods and mutex locking in the `dashboard` handler to `tokio::task::spawn_blocking`. This prevents the async executor threads from being stalled by potentially slow operations such as disk enumeration, which is a critical performance fix for maintaining responsiveness of the Web UI under heavy system load or when dealing with slow hardware. The optimization: - Moves `system.lock()` and `last_system_refresh.lock()` into the blocking task. - Wraps `sys.refresh_cpu()`, `sys.refresh_memory()`, and `sys.refresh_disks()` in `spawn_blocking`. - Extracts all necessary metrics within the blocking task and returns them as a tuple. - Ensures the `AppState` is properly shared via `Arc`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Optimized the
dashboardhandler inserver_manager/src/interface/web.rsby offloading blockingsysinfocalls totokio::task::spawn_blocking. This prevents async executor thread starvation and improves overall system responsiveness.PR created automatically by Jules for task 8243995971626542701 started by @Cylae