Skip to content

Comments

Check, Fix, Optimize and Update README#196

Open
Cylae wants to merge 1 commit intomainfrom
check-fix-optimize-readme-1266073415750486465
Open

Check, Fix, Optimize and Update README#196
Cylae wants to merge 1 commit intomainfrom
check-fix-optimize-readme-1266073415750486465

Conversation

@Cylae
Copy link
Owner

@Cylae Cylae commented Feb 16, 2026

This PR addresses the "Check. Fix. Optimize." task.

Changes:

  1. Optimization (Caching & Async):

    • Refactored server_manager/src/core/config.rs and server_manager/src/core/users.rs to use static OnceLock<RwLock<Cached...>> caches.
    • Implemented 500ms throttling on load_async metadata checks to reduce I/O.
    • Added proper async methods (add_user_async, enable_service_async, etc.) that offload blocking operations (file I/O, system user creation, hashing) to tokio::task::spawn_blocking.
    • Refactored server_manager/src/interface/web.rs to remove local caches and block_in_place, utilizing the new thread-safe, efficient core methods.
  2. Fixes:

    • Added sys.refresh_disks() in HardwareInfo::detect to ensuring disk space usage is populated.
    • Unified path logic in UserManager for consistency between load and save.
  3. Documentation:

    • Updated README.md to reflect version 1.0.8.
    • Bumped Cargo.toml version.

Verification:

  • Ran cargo test - All tests passed.
  • Ran cargo clippy - No warnings in project code.
  • Verified compilation with cargo check.

PR created automatically by Jules for task 1266073415750486465 started by @Cylae

- **Config**: Implemented `CONFIG_CACHE` with 500ms throttling and async methods `enable_service_async`/`disable_service_async`.
- **Users**: Implemented `USERS_CACHE` with 500ms throttling and async methods `add_user_async`, `delete_user_async`, etc., using `spawn_blocking` for CPU/IO tasks.
- **Web Interface**: Refactored to use static async methods from `core`, removing local caches and `block_in_place`.
- **Hardware**: Added `sys.refresh_disks()` to `detect()` for accurate disk stats.
- **Project**: Bumped version to 1.0.8 and updated `README.md`.
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant