Fix hardware detection, optimize dashboard, update README#199
Fix hardware detection, optimize dashboard, update README#199
Conversation
- Added `sys.refresh_disks()` in `HardwareInfo::detect` to ensure disk usage stats are populated. - Offloaded heavy `sysinfo` operations to `spawn_blocking` in `start_server` and `dashboard` to prevent blocking the async runtime. - Updated `Cargo.toml` to enable `async_tokio` feature for `criterion`. - Updated `README.md` with benchmarking instructions.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR addresses the user's request to "Check. Fix. Optimize. Update the README."
Changes:
sys.refresh_disks()inserver_manager/src/core/hardware.rsbecauserefresh_disks_list()only updates the partition list, not usage stats.server_manager/src/interface/web.rsto offload blockingsysinfocalls (initialization and dashboard refresh) totokio::task::spawn_blocking. This prevents the async executor from stalling during heavy I/O or computation.server_manager/Cargo.tomlto includefeatures = ["async_tokio"]forcriterionto support async benchmarking.README.mdto document the requirement of theasync_tokiofeature for running benchmarks.Verification:
cargo checkpassed.cargo testpassed.PR created automatically by Jules for task 11603564308756225289 started by @Cylae