#31: implement global mapping - #32
Merged
Merged
Conversation
lifflander
changed the title
lifflander
force-pushed
the
31-get-new-mapping-globally-after-lb
branch
from
January 14, 2026 00:41
8b02d39 to
75fe5ae
Compare
lifflander
force-pushed
the
31-get-new-mapping-globally-after-lb
branch
from
January 14, 2026 19:07
75fe5ae to
ac9384d
Compare
lifflander
marked this pull request as ready for review
January 14, 2026 19:16
lifflander
force-pushed
the
31-get-new-mapping-globally-after-lb
branch
from
January 15, 2026 15:17
99517ed to
cd6eb4c
Compare
cwschilly
approved these changes
Jan 15, 2026
cwschilly
left a comment
cwschilly
left a comment
Contributor
There was a problem hiding this comment.
LGTM. One suggestion on limiting duplicated code
Comment on lines
+276
to
+277
| collective_ctx_->out_ptr = static_cast<void*>(&out); | ||
| collective_ctx_->done.store(false); |
Contributor
There was a problem hiding this comment.
We could move these steps into a small private method since they'll be called by every collective call needing to clear the context
lifflander
force-pushed
the
31-get-new-mapping-globally-after-lb
branch
from
January 19, 2026 21:01
cd6eb4c to
1242653
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31