Skip to content

Replace postgres: by postgresql: for database_url#87

Open
stweil wants to merge 1 commit into
DCGM:masterfrom
UB-Mannheim:sqlalchemy
Open

Replace postgres: by postgresql: for database_url#87
stweil wants to merge 1 commit into
DCGM:masterfrom
UB-Mannheim:sqlalchemy

Conversation

@stweil

@stweil stweil commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

The latest versions of SQLAlchemy no longer support "postgres:".
That old URL form was deprecated more than 10 years ago:

https://github.com/sqlalchemy/sqlalchemy/blob/8fc5005dfe3eb66a46470ad8a8c7b95fc4d6bdca/lib/sqlalchemy/dialects/postgres.py

Signed-off-by: Stefan Weil sw@weilnetz.de

The latest versions of SQLAlchemy no longer support "postgres:".
That old URL form was deprecated more than 10 years ago:

https://github.com/sqlalchemy/sqlalchemy/blob/8fc5005dfe3eb66a46470ad8a8c7b95fc4d6bdca/lib/sqlalchemy/dialects/postgres.py

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@stweil

stweil commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

See also sqlalchemy/sqlalchemy#6083 (comment).

There are also some files which use SQLite (sqlite:///) instead of PostgreSQL. Which database software is preferred? Should both work?

Perhaps the code could use database_url = args.database, so the database argument would provide the full URL and the user were free to choose either SQLite or PostgreSQL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant