Conversation
Added key signature, notes for first measure
main body complete, need articulations
articulations added, ready for review
johentsch
approved these changes
Apr 26, 2025
Member
johentsch
left a comment
johentsch
left a comment
There was a problem hiding this comment.
Thanks @vzhyu. I've changed the base branch to op2 and updated a few durations according to the new guideline: #261 (comment)
Please have another look and merge if everything seems alright. I suggest to add your ORCiD to a newly added engraver metadata field.
Contributor
Author
|
Thanks @johentsch, some tiny changes in accordance with new standard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first movement ready for review