chore: add formatter and github workflow for format check #245
Closed
yinanazhou wants to merge 2 commits intodevelopfrom
Closed
chore: add formatter and github workflow for format check #245yinanazhou wants to merge 2 commits intodevelopfrom
yinanazhou wants to merge 2 commits intodevelopfrom
Conversation
- Update puppeteer to `^19.7.0`
- Added prettier and updated eslint config - Formatted all files and resolved conflicts - Added format check github workflow on push and PR refs: #243
Member
|
Does the formatter produce a syntax error somewhere? The app crashes upon attempting to load a score file (I tried both with Safari and Firefox, after cleaning caches to be sure). See inspector for error details. |
Collaborator
Author
|
It's crashing because some dependencies are no longer supported. I've already made an issue about that. I'm trying to clean up the codebase, and make small commits along the way. |
yrammos
requested changes
Mar 5, 2025
Member
yrammos
left a comment
yrammos
left a comment
There was a problem hiding this comment.
@yinanazhou I suggest that we produce (and approve) PRs only when the PR leaves the app in a working state (i.e. no crashes). Is that OK with you?
Collaborator
Author
|
Yes, I could do that in the future. But in this case, the crash is not related to the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: #243