fix: move DEV deployment verification to DEV CI/CD workflow#3559
Open
TaprootFreak wants to merge 2 commits intodevelopfrom
Open
fix: move DEV deployment verification to DEV CI/CD workflow#3559TaprootFreak wants to merge 2 commits intodevelopfrom
TaprootFreak wants to merge 2 commits intodevelopfrom
Conversation
The verify-dev-deployment check in api-pr.yaml never ran on auto-created release PRs because GITHUB_TOKEN does not trigger pull_request events. Move the check to api-dev.yaml as a post-deploy step where it reliably runs on every push to develop and appears on the release PR.
davidleomay
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
verify-dev-deploymentcheck inapi-pr.yamlwas supposed to ensure that DEV is running the latest code before a release PR (develop → main) can be merged. However, this check never actually ran on release PRs.Root cause: The
auto-release-pr.yamlworkflow creates the release PR usingGITHUB_TOKEN. GitHub does not triggerpull_requestevents for actions performed byGITHUB_TOKEN(to prevent infinite workflow loops). As a result,api-pr.yamlwas never triggered when the release PR was created, and theverify-dev-deploymentjob was effectively dead code.Solution
Move the DEV deployment verification from
api-pr.yamlintoapi-dev.yamlas a post-deploy step:api-dev.yaml: After deploying to Azure, polldev.api.dfx.swiss/versionuntil the expected commit SHA is live (up to 15 min)api-pr.yaml: Remove the deadverify-dev-deploymentjob and theif: github.head_ref != 'develop'guard on the build jobThis works because
api-dev.yamlruns on every push to develop, and its check status automatically appears on the release PR (since develop is the head branch).Test plan
Verify DEV deploymentstep runs after Azure deploy