Skip to content

fix: move DEV deployment verification to DEV CI/CD workflow#3559

Open
TaprootFreak wants to merge 2 commits intodevelopfrom
fix/auto-release-pr-trigger
Open

fix: move DEV deployment verification to DEV CI/CD workflow#3559
TaprootFreak wants to merge 2 commits intodevelopfrom
fix/auto-release-pr-trigger

Conversation

@TaprootFreak
Copy link
Copy Markdown
Collaborator

@TaprootFreak TaprootFreak commented Apr 9, 2026

Problem

The verify-dev-deployment check in api-pr.yaml was supposed to ensure that DEV is running the latest code before a release PR (develop → main) can be merged. However, this check never actually ran on release PRs.

Root cause: The auto-release-pr.yaml workflow creates the release PR using GITHUB_TOKEN. GitHub does not trigger pull_request events for actions performed by GITHUB_TOKEN (to prevent infinite workflow loops). As a result, api-pr.yaml was never triggered when the release PR was created, and the verify-dev-deployment job was effectively dead code.

Solution

Move the DEV deployment verification from api-pr.yaml into api-dev.yaml as a post-deploy step:

  • api-dev.yaml: After deploying to Azure, poll dev.api.dfx.swiss/version until the expected commit SHA is live (up to 15 min)
  • api-pr.yaml: Remove the dead verify-dev-deployment job and the if: github.head_ref != 'develop' guard on the build job

This works because api-dev.yaml runs on every push to develop, and its check status automatically appears on the release PR (since develop is the head branch).

Test plan

  • Push to develop and verify the Verify DEV deployment step runs after Azure deploy
  • Verify the check appears on the release PR (develop → main)

The verify-dev-deployment check in api-pr.yaml never ran on auto-created
release PRs because GITHUB_TOKEN does not trigger pull_request events.

Move the check to api-dev.yaml as a post-deploy step where it reliably
runs on every push to develop and appears on the release PR.
@TaprootFreak TaprootFreak marked this pull request as ready for review April 9, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants