fix: add timeout and recovery to Spark wallet initialization#3563
Merged
TaprootFreak merged 1 commit intodevelopfrom Apr 9, 2026
Merged
fix: add timeout and recovery to Spark wallet initialization#3563TaprootFreak merged 1 commit intodevelopfrom
TaprootFreak merged 1 commit intodevelopfrom
Conversation
The Spark SDK can throw uncatchable errors from its WASM/gRPC layer via timer callbacks, leaving SparkWallet.initialize() hanging as an unresolved promise. This causes all Spark operations to block forever. - Add 60s timeout per initialization attempt so hanging promises fail and the retry loop can continue - Extract initializeWithTimeout() to race initialization against timer - Add resetWallet() method for external recovery triggers - Improve uncaughtException handler readability
❌ Security: 3 critical vulnerabilities |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SparkWallet.initialize()attempt — if the SDK promise hangs due to a WASM-layer crash, the timeout rejects and the retry loop continuesinitializeWithTimeout()to race SDK initialization against a timerresetWallet()method for external recovery (e.g. from uncaughtException handler)Context
Follow-up to #3561. The Spark SDK can throw
SparkAuthenticationErrorfrom a gRPC timer callback (outside the Promise chain), which theuncaughtExceptionhandler catches. However,SparkWallet.initialize()remains as an unresolved promise, causing all subsequentawait this.walletcalls to hang forever. The timeout ensures the retry loop can recover from this state.Test plan
resetWallet()triggers re-initialization