fix: add unhandledRejection handler and fix Polygon init crash#3566
Open
TaprootFreak wants to merge 1 commit intodevelopfrom
Open
fix: add unhandledRejection handler and fix Polygon init crash#3566TaprootFreak wants to merge 1 commit intodevelopfrom
TaprootFreak wants to merge 1 commit intodevelopfrom
Conversation
Add global unhandledRejection handler to prevent process crashes from escaped promise rejections (Node 22 defaults to --unhandled-rejections=throw). Fix Polygon POSClient fire-and-forget initialization that could crash the process if the RPC endpoint is unreachable at startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unhandledRejectionhandler inmain.tsto prevent process crashes from escaped promise rejections (Node 22 defaults to--unhandled-rejections=throw)POSClientfire-and-forget initialization (void) that would crash the process if the RPC endpoint is unreachable at startupContext
Follow-up to #3562 — after the Spark SDK crash, audit revealed two additional crash vectors from external SDKs:
unhandledRejectionhandler: Any SDK that rejects a promise outside a.catch()chain kills the processvoidinit:void this.initPolygonNetwork(...)silently discards the promise, making any rejection unhandledTest plan
UnhandledRejectionlog entries after deploy