Fix memory leak in TypeHandlerBase.DictionaryKeyComparer.Equals #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug was in line 22 of TypeHandlerBase.cs: if (x != null && y != null) return false; This condition returns false when BOTH objects are non-null, which is the normal comparison case. This caused the ConcurrentDictionary to: 1. Never find existing cache entries (Equals always returns false) 2. Add a new entry for every SetValue() call 3. Grow unboundedly causing memory leaks in production The fix changes the null checks to proper equality semantics: if (x == null && y == null) return true; // Both null = equal if (x == null || y == null) return false; // One null = not equal Added unit test to verify cache reuse behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was in line 22 of TypeHandlerBase.cs:
if (x != null && y != null) return false;
This condition returns false when BOTH objects are non-null, which is the normal comparison case. This caused the ConcurrentDictionary to:
The fix changes the null checks to proper equality semantics:
if (x == null && y == null) return true; // Both null = equal
if (x == null || y == null) return false; // One null = not equal
Added unit test to verify cache reuse behavior.
🤖 Generated with Claude Code