NETCUP: fixup provider to make it pass the latest integration test suite - #4698
Open
kordianbruck wants to merge 3 commits into
Open
NETCUP: fixup provider to make it pass the latest integration test suite#4698kordianbruck wants to merge 3 commits into
kordianbruck wants to merge 3 commits into
Conversation
This was referenced Aug 4, 2026
Contributor
Author
|
I'm assuming we can then also fold this into the release_candidate_v5 branch and see what else needs adaption? |
Contributor
Author
|
In anticipation of me having done the wrong thing, I've updated the same change for the v5 version that I could also instead send as a PR to the release branch and abandon this PR. Let me know what you'd prefer: https://github.com/kordianbruck/dnscontrol/tree/fix-netcup-v5 |
Collaborator
|
Hi there! Yup, you guessed right. I'm focused on changes for v5 only right now. "main" is getting very few updates. Sorry for any confusion! Would you please make a PR based on https://github.com/kordianbruck/dnscontrol/tree/fix-netcup-v5 ? (and close this) Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes to the Netcup DNS provider integration, focusing on API efficiency, compliance with provider limitations, and enhanced record validation. The main changes include batching record operations into a single API call, enforcing new auditing rules for TXT and CAA records, and adding rate limiting to respect Netcup's API restrictions.
Netcup Provider API Improvements:
updateDnsRecords), improving efficiency and reducing the number of API requests. The individualcreateRecord,deleteRecord, andmodifyRecordmethods were removed, and all corrections are now collected and sent together.Provider Limitations and Integration Tests:
Auditing and Validation Enhancements:
Codebase Cleanups:
Other Minor Fixes: