Repository navigation
Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. 📝 WalkthroughWalkthroughThe pull request updates pinned documentation and development dependency versions. It does not change exported or public entity declarations. ChangesDependency updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: 🟡 Moderate · up to The declared Python 3.9 support path can no longer install development dependencies or run CI. Restore compatible pins or raise the supported Python floor and update CI together before merging. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
A rabbit checks each versioned line Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 78e54515-47df-4f3a-b643-a2fa19899553
📒 Files selected for processing (2)
docs/requirements-docs.txtrequirements-dev.txt
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.
📜 Review details
⏰ Context from checks skipped due to timeout. (6)
- GitHub Check: build (3.11)
- GitHub Check: build (3.12)
- GitHub Check: build (3.13)
- GitHub Check: Build documentation
- GitHub Check: build (3.10)
- GitHub Check: check-licenses
🔇 Additional comments (2)
docs/requirements-docs.txt (1)
7-7: LGTM!requirements-dev.txt (1)
3-3: LGTM!Also applies to: 9-9
Comment on lines
+1
to
+2
| setuptools==84.0.0 | ||
| pytest==9.1.1 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🤖 get_repo_knowledge executed:
get_repo_knowledge DagsHub/client /tmp/coderabbit-repo-knowledge/dagshub-client-aa1863f7
Length of output: 384
🏁 Script executed:
#!/bin/bash
set -eu
printf '%s\n' '--- candidate files ---'
git ls-files | rg '(^|/)(requirements-dev\.txt|pyproject\.toml|setup\.py|setup\.cfg|tox\.ini|\.python-version|Dockerfile[^/]*|environment[^/]*|.*ya?ml)$|(^|/)\.github/workflows/.*'
printf '%s\n' '--- requirements-dev.txt ---'
cat -n requirements-dev.txt
printf '%s\n' '--- Python/version references ---'
rg -n -i --glob '!*.lock' --glob '!package-lock.json' 'python-version|requires-python|python_requires|python 3\.[0-9]|py3[0-9]|3\.8|3\.9|3\.10' .github pyproject.toml setup.py setup.cfg tox.ini .python-version requirements-dev.txt 2>/dev/null || true
printf '%s\n' '--- dependency declarations ---'
for f in pyproject.toml setup.py setup.cfg tox.ini; do
if [ -f "$f" ]; then
printf '%s\n' "--- $f ---"
cat -n "$f"
fi
done
printf '%s\n' '--- workflow version lines ---'
if [ -d .github/workflows ]; then
rg -n -C 3 -i 'python|pytest|requirements-dev' .github/workflows
fiRepository: DagsHub/client
Length of output: 12818
🏁 Script executed:
#!/bin/bash
set -eu
python3 - <<'PY'
import json
import urllib.request
packages = {
"setuptools": "84.0.0",
"pytest": "9.1.1",
"pytest-env": "1.7.1",
"pytest-mock": "3.15.1",
"fiftyone": "1.22.0",
"datasets": "5.0.1",
}
for name, version in packages.items():
url = f"https://pypi.org/pypi/{name}/{version}/json"
with urllib.request.urlopen(url, timeout=15) as response:
data = json.load(response)
info = data["info"]
print(f"{name}=={version}: requires_python={info.get('requires_python')!r}")
PY
printf '%s\n' '--- relevant workflow and metadata excerpts ---'
sed -n '15,35p' .github/workflows/python-package.yml
sed -n '65,76p' setup.pyRepository: DagsHub/client
Length of output: 2439
🌐 Web query:
PyPI metadata requires-python setuptools 84.0.0 pytest 9.1.1 pytest-env 1.7.1 fiftyone 1.22.0 datasets 5.0.1
💡 Result:
<source_evidence>
Citations:
- 1: https://www.pypi.org/project/setuptools/84.0.0
- 2: https://raw.githubusercontent.com/pypa/setuptools/main/pyproject.toml
- 3: https://pypi.org/project/pytest/9.1.1/
- 4: https://pypi.org/project/pytest/
- 5: https://pypi.org/project/pytest-env/1.7.1/
- 6: https://github.com/pytest-dev/pytest-env/blob/main/pyproject.toml
- 7: https://pypi.org/project/fiftyone/1.22.0/
- 8: https://pypi.org/project/datasets/5.0.1/
Keep the development pins compatible with Python 3.9 or raise the support floor.
setup.py declares Python >=3.9, and CI installs requirements-dev.txt in its Python 3.9 job. setuptools==84.0.0 and pytest==9.1.1 require Python >=3.10, so dependency installation fails before tests run. Keep Python 3.9-compatible pins, or update python_requires and remove Python 3.9 from the CI matrix in the same change.
Source: MCP tools
Collaborator
Author
|
Closing this in favor of #725 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update sphinx-autodoc-typehints from 3.9.9 to 3.13.7.
The bot wasn't able to find a changelog for this release. Got an idea?
Links
Update setuptools from 80.9.0 to 84.0.0.
Changelog
84.0.0
83.0.0
82.0.1
82.0.0
81.0.0
80.10.2
80.10.1
80.10.0
Links
Update pytest from 8.3.5 to 9.1.1.
Changelog
9.1.1
9.1.0
9.0.3
9.0.2
9.0.1
9.0.0
8.4.2
8.4.1
8.4.0