fix(memory): stop regenerating duplicate agents/docker-compose.yml#226
Open
DammianMiller wants to merge 2 commits into
Open
fix(memory): stop regenerating duplicate agents/docker-compose.yml#226DammianMiller wants to merge 2 commits into
DammianMiller wants to merge 2 commits into
Conversation
startServices() searched only agents/docker-compose.yml and docker/docker-compose.yml — never the canonical tools/agents/docker-compose.qdrant.yml — so it recreated the duplicate (deleted in 46b1741, guarded by test D10) on every `uap memory start`. - Add the canonical qdrant compose to both start/stop search lists so the real file is found instead of recreated. - Point the create-default fallback at tools/agents/docker-compose.qdrant.yml so a fresh project never writes the forbidden path either. - claude-md generator: prefer the canonical path for DOCKER_COMPOSE_PATH. - Add D10b regression tests asserting the regenerator targets the canonical path and the search list includes it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
startServices()insrc/cli/memory.tssearched onlyagents/docker-compose.ymlanddocker/docker-compose.yml— never the canonicaltools/agents/docker-compose.qdrant.yml. Not finding it, it wrote a freshagents/docker-compose.ymlon everyuap memory start, recreating the duplicate that was deliberately deleted in46b1741and is guarded by test D10.The duplicate never fails CI (it's generated at runtime, not in a clean checkout), so the latent bug persisted on master through 1.41.0.
Fix
tools/agents/docker-compose.qdrant.ymlto both the start and stop search lists, so the real file is found instead of recreated.tools/agents/docker-compose.qdrant.yml, so a fresh project never writes the forbidden path either.claude-mdgenerator: prefer the canonical path forDOCKER_COMPOSE_PATH.Verification
npm run build+tsccleanagents/docker-compose.ymlno longer regenerates🤖 Generated with Claude Code