feat: optional callback enabling fuel scripts to call simplevrf#1
Open
DarthBenro008 wants to merge 1 commit intomasterfrom
Open
feat: optional callback enabling fuel scripts to call simplevrf#1DarthBenro008 wants to merge 1 commit intomasterfrom
DarthBenro008 wants to merge 1 commit intomasterfrom
Conversation
IGI-111
reviewed
Aug 26, 2025
| #[payable] | ||
| #[storage(read, write)] | ||
| fn request(seed: b256) -> u64; | ||
| fn request(seed: b256, callback: Option<bool>) -> u64; |
There was a problem hiding this comment.
I'm not sure I understand the logic behind making it an Option. This will still be incompatible with all previous usages, since the function selector hash includes the arguments.
If you want backwards compatibility, a better way would be to have a fn request_without_callback(seed: b256) -> u64.
If you're willing to break the interface however, I think making it an Option<b256> makes more sense, allowing the callback to be another contract than the caller:
// same behavior as current usage
let rid = request(seed, Some(CONTRACT_ID));
// no callback
let rid = request(seed, None);
// call another contract
let rid = request(seed, Some(other_contract_id));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional callback
Noneis passedFeature requested by @IGI-111