Make capsule_cabinet work independently of buildsystem state#725
Open
Make capsule_cabinet work independently of buildsystem state#725
Conversation
mkopec
force-pushed
the
lvfs_script
branch
4 times, most recently
from
2f8cae4 to
225254c
Compare
mkopec
changed the title
mkopec
force-pushed
the
lvfs_script
branch
3 times, most recently
from
dc4919d to
02b92e1
Compare
filipleple
approved these changes
Jul 29, 2025
SergiiDmytruk
requested changes
Jul 29, 2025
Member
SergiiDmytruk
left a comment
SergiiDmytruk
left a comment
There was a problem hiding this comment.
Unless I misunderstand the intend, the changes are incomplete. The script can't be used without .config in the current directory and it will mix configuration from .config and coreboot's config extracted from a capsule's payload.
| @@ -24,17 +27,6 @@ if [ ! -f .config ]; then | |||
| die "No '.config' file in current directory" | |||
| fi | |||
Member
There was a problem hiding this comment.
Existence of .config is checked here.
|
|
||
| capsule=$1 | ||
| date=$(stat -c %w $capsule | cut -d ' ' -f 1) | ||
| vendor=$(cat .config | grep -e "CONFIG_VENDOR_.*=y" | cut -d '=' -f 1 | cut -d '_' -f 3- | awk '{ print tolower($0) }') |
Extract the coreboot config from the capsule itself, in order to be able to use the script on any coreboot capsules. Upstream-Status: Inappropriate [Dasharo downstream] Change-Id: I49f2fb91423b912d98d55ca5e0e008b483d1322c Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
filipleple
force-pushed
the
lvfs_script
branch
from
2018c10 to
4ab4432
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the config from the capsule itself, to avoid depending on .config existing and being up to date.
This depends on edk2 basetools, these can be taken from the edk2 build tree, or specified as an env variable.